From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5435AC636CC for ; Mon, 13 Feb 2023 14:38:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 73E696B0071; Mon, 13 Feb 2023 09:38:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6D096280001; Mon, 13 Feb 2023 09:38:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 540056B0075; Mon, 13 Feb 2023 09:38:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 3BB816B0071 for ; Mon, 13 Feb 2023 09:38:00 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id E3E93A0A90 for ; Mon, 13 Feb 2023 14:37:59 +0000 (UTC) X-FDA: 80462523078.08.366B956 Received: from mail-pg1-f182.google.com (mail-pg1-f182.google.com [209.85.215.182]) by imf18.hostedemail.com (Postfix) with ESMTP id EA7121C0017 for ; Mon, 13 Feb 2023 14:37:57 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=rivosinc-com.20210112.gappssmtp.com header.s=20210112 header.b=SzFpKuzH; spf=pass (imf18.hostedemail.com: domain of debug@rivosinc.com designates 209.85.215.182 as permitted sender) smtp.mailfrom=debug@rivosinc.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676299078; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=v46IGf7aK9w6Ujjdk9pH0Sd2OlQiZacAgD2cBvk1jT0=; b=aWPoe77i/f4tOaC93iceuvI3nCmLSls+9MqOQY3XVc3ZGV3cctqmYojo/ZzU7AAjCJosoQ sSbayuWfGOdo8qgZtMNUdMXc2U/Vg92BdQ6zZ6ITljXS6mLHsoOgqQBdXNqhXczpoLBwcB uLN+jPkWQMkGSe+8QiG1LnB331xJGXs= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=rivosinc-com.20210112.gappssmtp.com header.s=20210112 header.b=SzFpKuzH; spf=pass (imf18.hostedemail.com: domain of debug@rivosinc.com designates 209.85.215.182 as permitted sender) smtp.mailfrom=debug@rivosinc.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676299078; a=rsa-sha256; cv=none; b=bxqW8eYc2h7uAgfGTDNzsbMQePBGempOcRxZQQHxoSi126MnhTiCp43hR2ZOuLvh7KlY+u 3xVPBqo7+03hzWNs0MeO5C640nTfKbE+b8YPOD8l3bnnefxQolqOKGcn0aoKeTVFaZT96K yqh4HN9DJZcfKlNTRBq5KufbHFS8dTs= Received: by mail-pg1-f182.google.com with SMTP id a23so8215371pga.13 for ; Mon, 13 Feb 2023 06:37:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=v46IGf7aK9w6Ujjdk9pH0Sd2OlQiZacAgD2cBvk1jT0=; b=SzFpKuzH1Wg1EhWOGZPaNWQd2POITNEL5ZP8sLHp25iK+Mn6828HZ6U13HeQCN93Sx +0ZNI0ubnqjUSBiqLTF8TSzT8ESdFmVXQ0TpJZ3Qm5ltt+EMXxjri/+uueQF1nGjGMA4 stDvus1Ojiffvsbq+nnE/UFkipL/riZobKSSy4IW/WVEusJyPLHO1nE6z5Bpy4fnOsgP kJ51zGJGuGpgfXmSA8YquHUgckB/TBqhkvuuQyNOeijvGHmV19pXSOA3v2MlP7wD95ls UEl9GtUVFINyfXgxkowUI5R/zjVUa2yd5uwaFVOYIaNuZiIogxSqqpN2//Dbkl2WDX51 yzPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=v46IGf7aK9w6Ujjdk9pH0Sd2OlQiZacAgD2cBvk1jT0=; b=uh0gY027LToFBK6e4WI575FGFvJrVxmJl/7ZKGiQjV5FDNB2YxeA7pAM4O+l4+K5cZ JoDAuoq8TsEtkJ6OBCC2B/i4iP2EXEVIvHrGwUgwIThsMta5uSscowJ8KB/6UFLcb49w DWkrUMFRkjIQ5u8bwA/9L3nWMGGxafmksWt9g7STQrSNxV+VqE8YsQrVCIVLzYijCfvT tXrVqLAk28NnW0fpPLjS6Rak5L32xoSvjVoE+y828hvG1+0ZGJPIorm2WlkjemlXphV6 jj5QMFj4iSIQ0VMQoNKNKBP9w951/JZDV7pNo9+STQzupFIAdYVk92dXxjt/8ad5S7gs bRng== X-Gm-Message-State: AO0yUKVWhid4pn28THm3KsmSUSI2R0Ja0AGKUDdnyp0e4tJIIyWqM782 byxLV2JeDDr8iKVCNl1jOlvYkw== X-Google-Smtp-Source: AK7set/DKESMToA1CvFzD8s7hPzM1C6fYF5uRXkJ8n+Af4LEgHbtdNDBVTegNt3NTjuOhT2mPBEStg== X-Received: by 2002:a62:4ec3:0:b0:5a8:c40e:891c with SMTP id c186-20020a624ec3000000b005a8c40e891cmr1406360pfb.31.1676299076568; Mon, 13 Feb 2023 06:37:56 -0800 (PST) Received: from debug.ba.rivosinc.com ([66.220.2.162]) by smtp.gmail.com with ESMTPSA id t13-20020a62ea0d000000b0057fec210d33sm8028139pfh.152.2023.02.13.06.37.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Feb 2023 06:37:56 -0800 (PST) Date: Mon, 13 Feb 2023 06:37:54 -0800 From: Deepak Gupta To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, Andrew Morton , linux-mm@kvack.org Subject: Re: [PATCH v1 RFC Zisslpcfi 11/20] mmu: maybe_mkwrite updated to manufacture shadow stack PTEs Message-ID: <20230213143754.GC3943238@debug.ba.rivosinc.com> References: <20230213045351.3945824-1-debug@rivosinc.com> <20230213045351.3945824-12-debug@rivosinc.com> <2d6eefb8-c7c5-7d32-9a75-ae716f828cd9@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <2d6eefb8-c7c5-7d32-9a75-ae716f828cd9@redhat.com> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: EA7121C0017 X-Stat-Signature: 7tb8ire7hjyejwpb1fazd8ssrjzygc5g X-Rspam-User: X-HE-Tag: 1676299077-564718 X-HE-Meta: U2FsdGVkX196La6a/5vt5TmDO0OS6xFKzZAIYxkAPayeI25pLjLod3W/MfqIzfs2fE84b63A+9JkvwDCY/92+XL2npwOfxhBjXSrqtRPyaUn81kOtkWgO9XUg2JC1jTHUn5kIQmPW/kE/S/N0agAXlgf8+5Zf2zdTyk4qNbrgYiSVRA7UQ0bw0tT2qSzZlWlclGryZhv3d+NPf5kfx1MU3vRzurlKvT82zXau0LVui61xtgLRSiJlcklKeqk6UJJGjFPCvEkKgW1RUmdHsbz35vRztYdvX16ZM+GuuMzZKlWCpikuHKTahW2oNxV/kgFltxLJ7Y05wXNiEqbERxn+UUpuHKtJVwLGQl6d4QLafq8sQ0IKcE5do8rwfhCeZ6EQCfOVxsSjsv1hCJ/iGB/OAEu4FcdN4RaHpXq1i42o2cyAMJXeoi1VMXYusEJtwTMD9Siiesx4Dm6gTGD2EI6Cc8ZNaf/+zLg81W1oeKpVkrJA6pW+u2/2bluBVJahao7O0c/I2+PgjpqzKL4x0jissmzWOLRSgfr/7Cyu6Jr2knvm8JK0PTTuVY0yzVO2+tWTuyVcVt2U+hYxRm/6jy3eCaEykAgoZcbyTyWvLKI1lGYRA9uyUJbvQg1Hac60jxbr8jgKrHXsi5S4EORDxnodLxLvAk0POAUmR9/EGMamIWsrqztEhj/yc1/wrNODRwg04UIRpkwk0IGNHFSU2gahBsiAcGRAJY63pjd7FeFjBEaTwfq9DN+TPVONWf37enToLadZw5p/65OUepJkmH7eDtgiRxFeEFQfz6IPL01YFltcMJ9LC8bCJUBpWXuJxbwqVfalCiACvoD6Kk7tDYtwHr1OQyY7wZQbYDUl8gEcMYVnWNpJGGf2MDZ7w6RKJYcLIcdLXE1kFs94WCOmz4zZ2UferwRXm28PUuweBRt+cukn3heSCFVqwVDVzOjWe8opCX/V2smKXI1oi6J/12 KjHxHjxe +61a59YLg1H5jwxLXfgw/fSCLygg16Kkp9pB9J8aUNeXYFqkAtzGQm/JhAu7C3fYqRR3UnOl4anTkVPM/mIVxgrHqk6mb87y0SrRiR0exEIleqk9wXoXscQ3+smzeDfkrjn7m03lJsYWGQ9CdSdFqNjj4aEpwLa0eLgcBwN1igzIoBT8CArhIislpnufVFUaUrvIQML1M1Ab3Ba7YED6iBs7pXrxx7aIE8zXgxMryOG4MmtNjCqfeAGKrAqkBa8ENF5ttrNoSY+f+mKJiZeyPtV1YkorOOPyddWFSHNPIM+wlCSLEofqm4pF2EAsBPXtCO4F18VHPSLzPpipJN/HNwObx8XfaNxnrfCs3rVdLleINeGJBIvErgBqTKXBzCIG+5ge5DwZPp577Xry9JU1ibayDDqdfdedTRj8aBAvuUtH5k4ULJjsCaD1CVjh0X++ejSApxY6IyLqgzrvP5+zvGlwx8WaiLsNyuKPCvgYTBF6CpH8VEMQdhdw4LakIuRMfUhCdkLeG63wKY4GQLiuPUWo+OPJgRlhQ5zleVSe23bWCf/MuifI4sUzO+EvO8XuF+z+KNQzwf0MIBPFW6mZGW5dGszBVhk1jPnZ8 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Feb 13, 2023 at 01:05:16PM +0100, David Hildenbrand wrote: >On 13.02.23 05:53, Deepak Gupta wrote: >>maybe_mkwrite creates PTEs with WRITE encodings for underlying arch if >>VM_WRITE is turned on in vma->vm_flags. Shadow stack memory is a write- >>able memory except it can only be written by certain specific >>instructions. This patch allows maybe_mkwrite to create shadow stack PTEs >>if vma is shadow stack VMA. Each arch can define which combination of VMA >>flags means a shadow stack. >> >>Additionally pte_mkshdwstk must be provided by arch specific PTE >>construction headers to create shadow stack PTEs. (in arch specific >>pgtable.h). >> >>This patch provides dummy/stub pte_mkshdwstk if CONFIG_USER_SHADOW_STACK >>is not selected. >> >>Signed-off-by: Deepak Gupta >>--- >> include/linux/mm.h | 23 +++++++++++++++++++++-- >> include/linux/pgtable.h | 4 ++++ >> 2 files changed, 25 insertions(+), 2 deletions(-) >> >>diff --git a/include/linux/mm.h b/include/linux/mm.h >>index 8f857163ac89..a7705bc49bfe 100644 >>--- a/include/linux/mm.h >>+++ b/include/linux/mm.h >>@@ -1093,6 +1093,21 @@ static inline unsigned long thp_size(struct page *page) >> void free_compound_page(struct page *page); >> #ifdef CONFIG_MMU >>+ >>+#ifdef CONFIG_USER_SHADOW_STACK >>+bool arch_is_shadow_stack_vma(struct vm_area_struct *vma); >>+#endif >>+ >>+static inline bool >>+is_shadow_stack_vma(struct vm_area_struct *vma) >>+{ >>+#ifdef CONFIG_USER_SHADOW_STACK >>+ return arch_is_shadow_stack_vma(vma); >>+#else >>+ return false; >>+#endif >>+} >>+ >> /* >> * Do pte_mkwrite, but only if the vma says VM_WRITE. We do this when >> * servicing faults for write access. In the normal case, do always want >>@@ -1101,8 +1116,12 @@ void free_compound_page(struct page *page); >> */ >> static inline pte_t maybe_mkwrite(pte_t pte, struct vm_area_struct *vma) >> { >>- if (likely(vma->vm_flags & VM_WRITE)) >>- pte = pte_mkwrite(pte); >>+ if (likely(vma->vm_flags & VM_WRITE)) { >>+ if (unlikely(is_shadow_stack_vma(vma))) >>+ pte = pte_mkshdwstk(pte); >>+ else >>+ pte = pte_mkwrite(pte); >>+ } >> return pte; > >Exactly what we are trying to avoid in the x86 approach right now. >Please see the x86 series on details, we shouldn't try reinventing the >wheel but finding a core-mm approach that fits multiple architectures. > >https://lkml.kernel.org/r/20230119212317.8324-1-rick.p.edgecombe@intel.com Thanks David for comment here. I looked at x86 approach. This patch actually written in a way which is not re-inventing wheel and is following a core-mm approach that fits multiple architectures. Change above checks `is_shadow_stack_vma` and if it returns true then only it manufactures shadow stack pte else it'll make a regular writeable mapping. Now if we look at `is_shadow_stack_vma` implementation, it returns false if `CONFIG_USER_SHADOW_STACK` is not defined. If `CONFIG_USER_SHADOW_STACK is defined then it calls `arch_is_shadow_stack_vma` which should be implemented by arch specific code. This allows each architecture to define their own vma flag encodings for shadow stack (riscv chooses presence of only `VM_WRITE` which is analogous to choosen PTE encodings on riscv W=1,R=0,X=0) Additionally pte_mkshdwstk will be nop if not implemented by architecture. Let me know if this make sense. If I am missing something here, let me know. > >-- >Thanks, > >David / dhildenb >