From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A971C05027 for ; Tue, 14 Feb 2023 18:07:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9EC8E6B0071; Tue, 14 Feb 2023 13:07:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 975736B0072; Tue, 14 Feb 2023 13:07:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 815AE6B0075; Tue, 14 Feb 2023 13:07:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 6E6ED6B0071 for ; Tue, 14 Feb 2023 13:07:15 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 3E97E160FB1 for ; Tue, 14 Feb 2023 18:07:15 +0000 (UTC) X-FDA: 80466679230.03.ED9504F Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf12.hostedemail.com (Postfix) with ESMTP id 94E4340012 for ; Tue, 14 Feb 2023 18:07:12 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=JSdexqpQ; spf=pass (imf12.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676398032; a=rsa-sha256; cv=none; b=7ZxHWTC9ylzo0I+/3YjaRXx2Kb9QGdoCdB805AtFRO0INpy2KuQfnZFUyhDfhQ0gxsM0OJ xxtiooJOvW2iUefw4G2srPpvsljXdlMFAxlvESGqvFdlhRdc2Y38kQHEHj46GdlMWpNUiL VA/+DcbY1L9TW4tIblFDJkRhdqOZxaU= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=JSdexqpQ; spf=pass (imf12.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676398032; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kAN+l7lPCHdiOwBuOiob8JgqhPDLNbvV9uV2i9FMldE=; b=eoMND/ZlUbWuOKioM3ebB8NIEbvfutkYNSBtn8+vbumCvkAjsVzm+gI/aFYZ2nklAU9Irk +Tso1PiCavfzdzqxpG6UC1w44De9Gk5Q+CeTdZuMYHU8X8ElkzpaxICbReCR/f6fBrKoKZ nDqKjp1ZuFb4e9fLL0YA7emL+yuATFc= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B173F6181A; Tue, 14 Feb 2023 18:07:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 29529C433EF; Tue, 14 Feb 2023 18:07:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676398031; bh=mo5Umjy9gwExO76EH4fhPGRZILkdDvN7zeu4B6IXpbA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JSdexqpQj2D7WoDy+wTQzA6bPbEBFtAFfWpra/k3mZOX8F+YU8l+loixlzfQnHpRl StJQjCZcxfvI1hCGrP9he6SkWulEfL/jl/hQBIE/ccoad3WYovmNOG2qK++T0iBVnx R0DgEQH4KAC0qHSiXbLbDvfEZovk0rupGv8Os8ykx8NK6AUZVXapozkpm9AqDcNA0K OAUpw65ppCoidmkeyOwlZ7ta3bM3oEfzqEz6rRNMP2KuxyYfcHeF5iTFWUvJG/XxOn yNnpVj55odo0KkauUlQInTpPWnipz1DgegvjUw0eRBlMSCe/Sq4eP09OOewJFXco44 LUQpFb1Z23MwA== From: SeongJae Park To: SeongJae Park Cc: Baolin Wang , akpm@linux-foundation.org, torvalds@linux-foundation.org, hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, shakeelb@google.com, muchun.song@linux.dev, naoya.horiguchi@nec.com, linmiaohe@huawei.com, david@redhat.com, osalvador@suse.de, mike.kravetz@oracle.com, willy@infradead.org, damon@lists.linux.dev, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/4] mm: hugetlb: change to return bool for isolate_hugetlb() Date: Tue, 14 Feb 2023 18:07:08 +0000 Message-Id: <20230214180708.71645-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230214180324.71585-1-sj@kernel.org> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Queue-Id: 94E4340012 X-Rspamd-Server: rspam01 X-Stat-Signature: x5oiwq9dmuzgjsaj6dhbza6cwxjkritz X-HE-Tag: 1676398032-275143 X-HE-Meta: U2FsdGVkX19nyygzpf8PJUFmXP964z6JN8Gl+jfw4+HKRAsuz/LtOcA/M+3lSBzy5xOyrpMytDMNOMZfveTVxFY5gR4iKUAzrJw9v16jWRWurYUHVMOPlS41pGe7cPmDy/BMyctSUnxDGIZTZuvhUaVRN0GGZ9bS2ijgxiDVQEfHVYD9OgpzUOjDdmzRPrOAbafsvINiERIgWYriXnEwdwBjuHiJf3LWnLOAJUEnImWqcyavPHnuLb1IO1czx8GeI37aO9NJhHoOeGsnNqMJ9a6+yJRZs5rFJWBLear1x1K42Qmn3bYGGPaYEXxUbn9e/CnD86/KO/PHxb+6c+cL9WaXa8Bd3XgBlEdczcWVlTzP8HOagi6S948Z+on2NXjkVkxWNy0kSD1NoRWO5WIOvX7nDSvIopG6XLv8onBcHi+UIU8dko0DwnD9lIrsjhVsVtj8o2IWve++LsYx42p/+z/h4EBW8scowEloGhS4Vs89lql/aMmUMv8ECA5G/HhAAC1EguJ0LcuatFywpoG599eyNZxos5fOfl6Vbb6QWI1jd5wgvIMlCDTzcx5DVqvesgOKchXz9n4HwJncpegZnLd4k/TPg23LblNGkCc+vJkblcf1b3YQbkeKRvAJVD3Hydozi/v34AUgXx4m2e5vKDlUTzjcfoO6QnFm+GmI8AzUOdKvibUv4SA9ikpsycEK8NzTm6w45qGxbKgtyhHBGiKtD7H2uaAPj5rbuPfSQ8LHXITfM0N6bLWkr5BrT6LI7uufKsY/g1Y0xAK+YVro9wJ+3Hh72wHdTzf8lxS/MTI9ADZiaadN7JkQntjx0axOBhuBzs6Zz3Ybm2LQ9vc10RE9YLK+pxlbvz4v5zRX2BdYdOOyzg3xzY3s87TU31y5NQAKztqHhZtsVcVH8XqRnWVcFm5tIlPxRJj6En0Ld6rSvlSPab3WqzkxRYOEKwmiiiu9q0ABxOFmCWF12TW ubw56nmX FmBrERziSWvXefAFkjt9D975C6MS9bvnBML9nbg1YQk1d6jLDeh2PB1UXNGGaYv+5QA6UzJbx5HizuCnJlKCUy7NwgxbzsWDw+kgbYVDyRZdfnSAOH4hCSBQ8U7eohRh/3ZHKZ/fns2ZnJGSXIKFC6lbiAcYkHJbNspIBfGj9tDa7q34hDlJX1OfYb1TTbB6Sb6T6Fwi2cAOthHIZLZQNyY80rGl1WwEAdfFacofksg9Z2ncTQzy7DnCIAol72noxVPANuTiDh+DTy8OjpzLHmHejbW2ArY44fYFbbP8kM0v1uif4qk2iU6QDeEO29fJiQYeCYPZZxVfp8/wkm4cgEAWy2g7vR2pIsS/lTgqOpiEIPUySRVSRUgrMA4nO1q4PungicfWSu+pZoSWCe3vLfre1U4E+vR8anotqxF6fk8P705I= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 14 Feb 2023 18:03:24 +0000 SeongJae Park wrote: > On Tue, 14 Feb 2023 21:59:31 +0800 Baolin Wang wrote: > > > Now the isolate_hugetlb() only returns 0 or -EBUSY, and most users did not > > care about the negative value, thus we can convert the isolate_hugetlb() > > to return a boolean value to make code more clear when checking the > > hugetlb isolation state. Moreover converts 2 users which will consider > > the negative value returned by isolate_hugetlb(). > > > > No functional changes intended. > > > > Signed-off-by: Baolin Wang > > --- > > include/linux/hugetlb.h | 6 +++--- > > mm/hugetlb.c | 12 ++++++++---- > > mm/memory-failure.c | 2 +- > > mm/mempolicy.c | 2 +- > > mm/migrate.c | 2 +- > > 5 files changed, 14 insertions(+), 10 deletions(-) > > > > diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h > > index df6dd624ccfe..5f5e4177b2e0 100644 [...] > > diff --git a/mm/migrate.c b/mm/migrate.c > > index 53010a142e7f..c5136fa48638 100644 > > --- a/mm/migrate.c > > +++ b/mm/migrate.c > > @@ -2128,7 +2128,7 @@ static int add_page_for_migration(struct mm_struct *mm, unsigned long addr, > > if (PageHead(page)) { > > err = isolate_hugetlb(page_folio(page), pagelist); > > if (!err) > > - err = 1; > > + err = -EBUSY; > > Again, I think this is confusing. 'err' is 'bool', not 'int'. I mean, 'err' is not 'bool' but 'int', sorry. See? This confuses me ;) Thanks, SJ > > > Thanks, > SJ > > > } > > } else { > > struct page *head; > > -- > > 2.27.0 > >