From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFC48C05027 for ; Tue, 14 Feb 2023 19:32:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3B47C6B0072; Tue, 14 Feb 2023 14:32:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 365276B0073; Tue, 14 Feb 2023 14:32:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2538B6B0074; Tue, 14 Feb 2023 14:32:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 1573D6B0072 for ; Tue, 14 Feb 2023 14:32:16 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id DEDCEA0F92 for ; Tue, 14 Feb 2023 19:32:15 +0000 (UTC) X-FDA: 80466893430.08.103BFE8 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf12.hostedemail.com (Postfix) with ESMTP id 8FC8F40025 for ; Tue, 14 Feb 2023 19:32:13 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=I9qpkspE; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf12.hostedemail.com: domain of sj@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676403134; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/DxGlxY1qi2sytCCzTKISSxxlzMJvXzdy0dbV098EE0=; b=khvkia/G47FPByfeo5agZ8Gi6Bj5xrNfSLQOlpsc5tgLRip9IOZsmxfZYDZLOwUGkZSzT/ Xx1t7I6HS12phHobc/aB9l/XohztFidcmb5swOuhulX1LbaMRroDPJHV75DBDwvr7z8w6o /Da2puqgmRCW2tfa41DcWGFHi2pf6mE= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=I9qpkspE; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf12.hostedemail.com: domain of sj@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676403134; a=rsa-sha256; cv=none; b=KVDisIcO0m4KWi60DaUKildvlIhgjsJVM7MRdp6DEfnMC/20kF/EjQGgtbsJmBEdeXs0e9 fZXgL9YOo5jAlD1uHWY+rHfJcQHhjy1rj/s61ak+ID3PugCi0LUBdbW13uallcL/So//ds F7XJZ5TfEQ2pdJHyd4Qq73pW61puktg= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id E65B5CE21B2; Tue, 14 Feb 2023 19:32:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D80D9C433EF; Tue, 14 Feb 2023 19:32:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676403127; bh=Fcfd+XUY443lS17mBcRjKXrbkxgWMqAwxcoIbwYGHKc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=I9qpkspERTRIi+Leb8IhtQMgifKx4zfEwJxHOVJyt0mvyeXuGqF5zEaCuALu2Sm/s 6PdXI5r0SCDKJvgD75s0aquFCymiUnbsITRT49SqpDKcQnGibnGrbGKo80N3Sl+wCo sYy1fYk8PjHZueGkaf5ZcOZWdsNxaQNfj1dTlueCAHXFRsEE4/KMF7cfRZHOiCeZvJ sAXLvzwg20UnL2ghQeeOJ1WFX6hfcNZVGtA7XL8GetYTT7Z5UXs+MLRBALbMFAkX7O YdnuV3q3KDAsNBLIH4B/hD/NhiZXbp4rf5IqRTmvJPcgPEo+DHB1Sl+BJWzBMYF/hm t4YH+RsjZnhtA== From: SeongJae Park To: Baolin Wang Cc: akpm@linux-foundation.org, torvalds@linux-foundation.org, sj@kernel.org, hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, shakeelb@google.com, muchun.song@linux.dev, naoya.horiguchi@nec.com, linmiaohe@huawei.com, david@redhat.com, osalvador@suse.de, mike.kravetz@oracle.com, willy@infradead.org, damon@lists.linux.dev, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/4] mm: change to return bool for isolate_lru_page() Date: Tue, 14 Feb 2023 19:32:04 +0000 Message-Id: <20230214193204.72057-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <3635a17b9a0cf4be011a886415bf620b1c682ff6.1676382188.git.baolin.wang@linux.alibaba.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 8FC8F40025 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: cs5ixw6awj6r7ohauohdnyfu5ga76jjt X-HE-Tag: 1676403133-70585 X-HE-Meta: U2FsdGVkX184fN4+xigiOqz+4htU4ozNZ9cDHt3QlpMxxscjpJgIMpxzqqoSARvsHPsJ3OS7cuQ/H4kIhxCwmhNdlCr2z9wKn0Rv0Fi87Qpfve5BAxVpq3ulenVowVUZlCiLah/5iZrvDEDMJIiPgwL5MiNdiFW+HN4/85uTj6Ls2brus+qPDtdny3fLw6mz0ErDZCo7f4RuvedX+W7pwZi1C65fxCBeVohcCkX4c1Y02JaMBeQg8n7ajL3P808kmL2Yf5rIqEYBk+G+Gsdc8y/xxpRGsrXlqKPgLu+8qKFxGp7YpEigs7Z/d4ApkqGriYQjuWTHjbCx7ofZ1zMZZHFBcnzdPJufcxi9tvoYjuAxK5jeYqlymGmZjSTQUsfUohUq9KKkdez8EIkwcpiwxHNCc1XJN/1+l6274dyI7wIDXK8znlTkF209Cc8gStRg2RzF2MxWZXgWeDYJfxyYHQVob1XWVdDtiSkVEs8NkLk0QSMQvt/CtqTpFar+zuZRSJWL8OQX+45DGYmk+Gr9SxA6XLvf/CA8kwWGwTDcgrIhMgOX2hWteCOzjIAHDEKfyUuDHKOXfVpLig+t0uhPu8xsxQaY9UH+prrWbkVjPmLmxcxmdkCaxdW+TqlCAemsyVg3bugWoz2Nyckyt9qE3tsCBXOf1gO9Vv4jhu/g3sWvFDMw589f0Oms/4EjG4sMO3Z07eF0A3AVpuwbgH6ShS+aq893aYXf3j2WFAF1XzOls7HDtk+AWL3o0tIuozjN9pD+ML8/psjyClkzym6aLEE4HwJMjsz4FXayQ6Tont+sxx22wLMv2Q0z2aSW2ry8iP9mlAh+jokaahECSK6AhOYMUa7G1k2YppcBpRClSE7jXNvJvbeiYaiIBsCARKliwqBaWQTqGgMi7tV9gIOaYBJanscILN9JieFOl54+D8xNeIaYIYYBeUqw/3yr4kXCkyErU+dQa9Yv6PPfJCX h/HMUMHI jf/H0cdGs7RJ45VUtqyAZpoBvxbixcCTmPHWBRQZZi5zr1+jiCP+0plYWrd69ICTVZCmmEhBrq7jry0C5GPPvf2+EPUGOjLs9ikxVhSA2fM+OJhtfSR7sElIf7hstMaPUb8j7WRTKOnsvkodfehR2KZiq7yv5Nay8bGpUdt/eoNkz5vhhvtaX2i/N45B+Quo8XYa+7mGXwN6NXmQkIrLFw5LIMcssHP/YqGCalB5vf08r0MOxcLLsznySLtC4IDHnHqAjKOqUVV0/NY40z0YsbqP1K5BW6wqxqHb7w6VOkrxiCjDES/i7YKIi69+LRvQIRTFVaEHkERPtTKYBug4R3M//JPzOorO6+uh7+zc2MHpVCUc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 14 Feb 2023 21:59:30 +0800 Baolin Wang wrote: > The isolate_lru_page() can only return 0 or -EBUSY, and most users did > not care about the negative error of isolate_lru_page(), except one user > in add_page_for_migration(). So we can convert the isolate_lru_page() to > return a boolean value, which can help to make the code more clear when > checking the return value of isolate_lru_page(). > > Also convert all users' logic of checking the isolation state. > > No functional changes intended. > > Signed-off-by: Baolin Wang > --- > mm/folio-compat.c | 12 +++--------- > mm/internal.h | 2 +- > mm/khugepaged.c | 2 +- > mm/memcontrol.c | 4 ++-- > mm/memory-failure.c | 4 ++-- > mm/memory_hotplug.c | 2 +- > mm/migrate.c | 9 ++++++--- > mm/migrate_device.c | 2 +- > 8 files changed, 17 insertions(+), 20 deletions(-) > [...] > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index a1e8c3e9ab08..17ed80707518 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -1668,7 +1668,7 @@ do_migrate_range(unsigned long start_pfn, unsigned long end_pfn) > * LRU and non-lru movable pages. > */ > if (PageLRU(page)) > - ret = isolate_lru_page(page); > + ret = !isolate_lru_page(page); This may change return value of this function. That is, this function will return 1 instead of -EBUSY after this change. It's not a real issue as no caller of this function takes care of the return value, though. Thanks, SJ > else > ret = isolate_movable_page(page, ISOLATE_UNEVICTABLE); > if (!ret) { /* Success */ [...]