From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B32EC636D4 for ; Wed, 15 Feb 2023 20:25:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F2F816B0072; Wed, 15 Feb 2023 15:25:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EB8276B0073; Wed, 15 Feb 2023 15:25:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D592A6B0078; Wed, 15 Feb 2023 15:25:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id C6AEE6B0072 for ; Wed, 15 Feb 2023 15:25:57 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 7F38D1C61FB for ; Wed, 15 Feb 2023 20:25:57 +0000 (UTC) X-FDA: 80470657554.16.8637B8F Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf26.hostedemail.com (Postfix) with ESMTP id 290C214000B for ; Wed, 15 Feb 2023 20:25:53 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=se8sumWA; spf=pass (imf26.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676492754; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rQkjKrRxCmt/vx4EhzA4dpr+k4XVRdLC/hFeZbePbqo=; b=S2LIIRXN9AZLUITO9gI3b4+apHpXUE0pkdzieLiH2KVPP8u42JSNx9nI2e8e9n4K+XaaBM 7sfiU3fJhuyLc43SaMJ/W9FyEv2EvMUtCB8xRzV05EQbiGNe9pEdTuITPvrRMzAqZCQmS6 /lQmnmRzkSAHWgocuriZE4+t05LTIIs= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=se8sumWA; spf=pass (imf26.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676492754; a=rsa-sha256; cv=none; b=7QlWAyskB84sNoINszV9ytmL9WtqxoV39CUeaNHwH2ozqp8sF7kH1yEP5maB4q/8hoO0tY V9YcyfFZdAE5Gp3VT+TdLycrisEPFa8Q1+Q28Ki2YAKJxCJy/g4kg4hmwEuglxvBQzBt5s hFmmosGL1+SC3q76CIcdnOe3ivVucZs= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 73F38B823AD; Wed, 15 Feb 2023 20:25:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BD2FBC433D2; Wed, 15 Feb 2023 20:25:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676492751; bh=os1l2QpY3JmJBjUKP58QMx61GxEfMBxX9wW/qhau3Wc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=se8sumWAp4cC6xYEvZm0k/vTiSQ5XuMVkJ5esfyL9vk8I7RlFF6ai7V1E3jZtBRLc Bo3gpsa6aDzKYdqhFYfcVcwCotOIi6qZoeKMMUTMPUnbzPC5pnOB0dy74FSMfLij37 vHVqCj7ejNc1HvWWfKN/rkVt2NQim6+7Oab4AF9vbqcVCkg9ximutnuxZ0SB0hroOu iol6UlKKhsGXSGaPMukXtraayv4cKe4cjvO/nk76IQRLkVC3ABAxMbIbj8mmWKoMlk qZvnipkjfdfe6xjVAQkaI0vPIL0ELw3ZkLZE8nCE9GsFvxOG+QPHxDZwizBmgcz+RF DYBmr2aIWSREQ== From: SeongJae Park To: Baolin Wang Cc: akpm@linux-foundation.org, torvalds@linux-foundation.org, sj@kernel.org, hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, shakeelb@google.com, muchun.song@linux.dev, naoya.horiguchi@nec.com, linmiaohe@huawei.com, david@redhat.com, osalvador@suse.de, mike.kravetz@oracle.com, willy@infradead.org, damon@lists.linux.dev, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 3/4] mm: hugetlb: change to return bool for isolate_hugetlb() Date: Wed, 15 Feb 2023 20:25:48 +0000 Message-Id: <20230215202548.92462-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <12a287c5bebc13df304387087bbecc6421510849.1676424378.git.baolin.wang@linux.alibaba.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 290C214000B X-Stat-Signature: 16894bgmicjxu4dfuipd7a8qum9xm5kj X-HE-Tag: 1676492753-827990 X-HE-Meta: U2FsdGVkX18suCYxzAmVkTB8a3F/YLGEU2WiX7+w15Df85tRfl/cfwOZ1cSbAqND5k04AG6VjaXFGgrwcaG6Boxz8e9nFj1hRct9lT2jNoccibX0nn0EZsxdEIfEKNVw4yU8VAjKHS/BvDM2aTmhtfQGZ4XWuZBIm2+G6a8V8PT6vu9r/MdOMeqndzDVpY56O/cFSOwSJqSJnAKNd9ZzRITXL6FqF5GfYlqljS6wzVHE8txG14eDkwJG72QBov/L8eU9kudRKFBXMX/2rTD43MWqnUQ4mcAO1mxP/v4SsYTCgFt7SbdrpoSi63TrZ6pbyZ4elYGKyMAYg8XbBwaWnG0MMdqXaXQBMPQopJgd71MqpFjtuHt7htFcFCz/9cwr93dME5OASCWMl532t5hbC++Lxpo2TjJbxc6RFCiSmNsb9wQYPY1Xp2DjJat+/TyulRUsAOi85Z8IYRyBsD+9Kaw1l7/x/yPWTGNYuqR+AgGg2bNURcOLN2HfT77Fjat5CUjkmEBG3RmnH436XTBwrTefEO4c6K9oIeb7YYiKq1TeYfApfmV0J6wvNHLgI8n1z6/o3r5t4gCCBvT6orF9ulgXJbTn9hRYwTwAicO1h+MbGqFxKFo3X9eUVmGE5aRcPfq44xRhQPllFdVMaCgWTaz0DRXoJMvS0HTtFYUJV2pPb04BHZrVIOq5ur3YKFUKduJEz3TsTj/W7tU8yMQLwpTSPS6biWs5NGiPmQAMoMxq8y3yncSNLUTgO6tgdPpxMLny3Y6bTdps0H3sx6gQmXozFXsSKtQ5vWgwWBXVVVkBBwwmVOYwAFmUhtRdVeZPCgAbEee4iELlAhXQz3LvvzwPIWXowwUjQKUcNPMqkF1ke8eFCdN11gIAAwDpgF1EZo6V8HA4DGKNb6obIOjbD1qFgGLtvN23fBomEsY4aTWpERuyukfrqNYPzo/Slp73pTjZaH6knVNd0SlPUu9 O+djmXer 9Am9yXv+USbVyw5A/+rsC08CT05vXzhj5D0tTLvtP4GT2mHdtQo9RJl6vn9Qcg/OpsTWWzfjFHb3NhKX27n4xJ5wrlnL0Cuu1oo11Z9AjDlh1sJJSF6TRGoqjxx2v220NYzB+kUpyDauSc/ijSfEenyV4+qGXM3WFsRY2XvFUDJN7qVopI71oZh1AVct9fsYSozFd5C5fP1nAmtCf7Q1/69EME6iNJpXuURj3yk+5BKklR/a+hDZL5k2C2VdFf+x0isDA1f4KssFd63i0yv4WVB5zt2KfthSR9rfGnis2ZHIyfWFmzqGBcDt7n23vs/NpRGRrEHPU+wE76CaLXtduvq7SOJflltp7u5s7bLlk0LQNVCryZltVhKEZRYFaIdVQDg9LsLkvBh2DEuo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 15 Feb 2023 18:39:36 +0800 Baolin Wang wrote: > Now the isolate_hugetlb() only returns 0 or -EBUSY, and most users did not > care about the negative value, thus we can convert the isolate_hugetlb() > to return a boolean value to make code more clear when checking the > hugetlb isolation state. Moreover converts 2 users which will consider > the negative value returned by isolate_hugetlb(). > > No functional changes intended. > > Signed-off-by: Baolin Wang > Acked-by: David Hildenbrand > --- [...] > include/linux/hugetlb.h | 6 +++--- > mm/hugetlb.c | 13 ++++++++----- > mm/memory-failure.c | 2 +- > mm/mempolicy.c | 2 +- > mm/migrate.c | 7 +++---- > 5 files changed, 16 insertions(+), 14 deletions(-) > [...] > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index 3a01a9dbf445..16513cd23d5d 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -2925,13 +2925,16 @@ static int alloc_and_dissolve_hugetlb_folio(struct hstate *h, > */ > goto free_new; > } else if (folio_ref_count(old_folio)) { > + bool isolated; > + > /* > * Someone has grabbed the folio, try to isolate it here. > * Fail with -EBUSY if not possible. > */ > spin_unlock_irq(&hugetlb_lock); > - ret = isolate_hugetlb(old_folio, list); > + isolated = isolate_hugetlb(old_folio, list); > spin_lock_irq(&hugetlb_lock); > + ret = isolated ? 0 : -EBUSY; > goto free_new; Nit. I'd personally prefer to set 'ret' before entering this critical section to keep the section short, but this would be just a mean comment that wouldn't worth request respin. Thanks, SJ [...]