From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BD6FC636D4 for ; Wed, 15 Feb 2023 20:26:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 173876B0072; Wed, 15 Feb 2023 15:26:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0FCEF6B0073; Wed, 15 Feb 2023 15:26:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EDFAF6B0078; Wed, 15 Feb 2023 15:26:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id DB70C6B0072 for ; Wed, 15 Feb 2023 15:26:54 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 76A8E41124 for ; Wed, 15 Feb 2023 20:26:54 +0000 (UTC) X-FDA: 80470659948.24.9F0DC77 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf25.hostedemail.com (Postfix) with ESMTP id ACAC5A000E for ; Wed, 15 Feb 2023 20:26:52 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=QiKfIFOo; spf=pass (imf25.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676492812; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=T+tRh/PnKoD1Mn8ut2lMo/bl1cofEaKADW/2dv+ok1Y=; b=ns1OKiPZ8Vhb1UqNxOwkKYcoX7piHiIZihQSrgLwJceOruXYdqGftYIBfoPOR1LppHKqjU R9qNyn4WiLfdLzeYp9oMAdx43VPUo7/5s3qgVRk8xpbeVgruNfAw7cjG7h1KrEE16HZkWH 0/f+Dvh416ebWAP6IwHkyJshjL3P8PY= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=QiKfIFOo; spf=pass (imf25.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676492812; a=rsa-sha256; cv=none; b=ClQHN4tmd2NL29W82lNfOUZ7UyS7pj+IkVse5hzzEz7UO8DSCoXlo1kzBFR6KraapyqicL kMtiPQ6t4s/+0P5DQyMzvFbDpThxjRcN9u6wnx9HzUhrqwlel1FGC4N4qwANwMJIZAV4gv SOp8UAf+lqOuEf5JFYut8F0HPPHUn/Y= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BE9E561D25; Wed, 15 Feb 2023 20:26:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 44C26C433D2; Wed, 15 Feb 2023 20:26:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676492811; bh=2B6OYT9baMUmpj081N8ApuyZRaf3nEcY8nE/MG7VCLo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QiKfIFOoUtM5otYmOb4O15O0dd+y9jtdA0UPtxP+BzMwcPKnA86t78F5aDKbxDUNy T/vJvHYUQfceohEwF4AHNCxD6Wpeq94+aTuEB8ZB7V1gqm8ntK5e2800CP2aoYKu7z PhEemm418KOfo5AyZsrbrzzSzYXGiPvQMqxa2A6xlFUyhNYriVakJCZIIgYT6hGgve jDL9lq9U8roY2wHXkAqsyNZ2JQeesizuQ20V8+zfX4b4cRB7U3qgwS2tqvpSIA6+Wi MbGX5r3DSAjg5OEalCoR5xTSmn2WUTDPEPA8+IariufCKZFD2uRE9+nujtdOHnqfE2 xwXkeEd3X8gBw== From: SeongJae Park To: Baolin Wang Cc: akpm@linux-foundation.org, torvalds@linux-foundation.org, sj@kernel.org, hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, shakeelb@google.com, muchun.song@linux.dev, naoya.horiguchi@nec.com, linmiaohe@huawei.com, david@redhat.com, osalvador@suse.de, mike.kravetz@oracle.com, willy@infradead.org, damon@lists.linux.dev, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 0/4] Change the return value for page isolation functions Date: Wed, 15 Feb 2023 20:26:48 +0000 Message-Id: <20230215202648.92523-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: mec9mwbpgt5kbdy57ccc1ddohcppjiuu X-Rspamd-Queue-Id: ACAC5A000E X-HE-Tag: 1676492812-812187 X-HE-Meta: U2FsdGVkX19PBSZKnlY58QM2lIgYp6LM6FXYyixfCfmFP/OcbMVcMdRsEwAs5xOiREbT7LRMRpTDU7YroIRaPD6MDRQmSDH7yHGia18iT8k0+0VFIKlfA/HKuMu7Yolv7aC4lY1618sEKbkAFRz97eJIYxQM7IgxAYeYXigdzIheuNg1HrNs+1fupx11DdDGw/esgltMfZ2FCF6rrqUQUEr0nCEfJvgu/NwIEO5aehejdQt43R8Yg7I/5+HWbr0yhjvAG0DzYv7dH28njZWPrmkedfsDn3oyWWyFIS/JuqAcSp0eo1sgd60w0hJtSeACXdRweHmm1U7cgdaIV/1sQ1aD8qX89pwKuzKJ0OgNwtw/XsY0XJhPnoTQ3fKqEMYtLRSppDuGmUPuWXiTkoFkNey4dYvAHayfTQaOCl3gnegMtsf0wwQtbioO4+JUx/7CDdwVOih2Dh6C7ZARIpxAJh2FsWQpsYeOUqVejgro7sxMtWXs4+eR1cWiAkKkPzPlHQ51AWs9PtWBTpCdmLTaujqpidZAOxSFBOu7FvEwvTv9ORzGDxeSIQm+wQMr7PCg5Qo3WNUaRxTDTo23DEfvWAz2SzrylGHYJDZ2TAsd8pKZT8MKu0zYjqKaI4zt8K0PZl8zkDqFzx/lyRkWoqgCvOblJClWhPrLvXNpD9hJTXrfSY0H1oQt7pW2ilaGAvNYcJrQGtXdu/EVcxSpuIqhGT6hxObXfzSlntvZ4sCoTU933Tj2Dp65V1vMAaR7oxCXboh4h0yuNmtAaHSab5/RI1puNszTSFvUiSJvGi0Qm40oHPdh3qGcZJK0eOUx+1ONrF5EqZRgNICZtSfqIVU007lNqI8Y5MiPcgO/+unCt1bCCdBsgMY4pIQf4YJaut4Dm0H68alDuLHb+V1MI6A7OxDgF2JuaKRT4KCCOD53Cy40djrnJ1krRWogU7hzw0+CpI7/5Aph9RfRW1U72kJ Sggg43jK UZH3Bo5wtm0LrwFL/8KCAmniBduthV5X5v/aYV2UxD1LaJTEkrczN+UWHRW/i7ml4BuhWHyN2XKqLUfAjsdrZX6bD69phZ8rYLhWNd8sbULjZ/C8xk61pwkzDgzM7jbfzBtTZCGM8LK65yh+Ujw0nh7fZgvrjtDf1E/6IUsq5rs34+yhijqBu5hbaF/R37gxHGL1IAwLq08VO+ToD1J8bVClbrQ7ibQBdktmCYMWcX3oaV5y6v1fx/28ft2ZpNLjHu6HZGJ44PWiGVfArVnUsM7SMAVgNxy3AHX2H+bPZtfKhEvLOWY/nytatAKfEBHMpiDXJCJS2TX7U7Jj2HlrmYEeaWMP3f9f3jm1ZRr9g5G5GgEROlzFUZI6UC3haDXfe4/ID X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Baolin, On Wed, 15 Feb 2023 18:39:33 +0800 Baolin Wang wrote: > Now the page isolation functions did not return a boolean to indicate > success or not, instead it will return a negative error when failed > to isolate a page. So below code used in most places seem a boolean > success/failure thing, which can confuse people whether the isolation > is successful. > > if (folio_isolate_lru(folio)) > continue; > > Moreover the page isolation functions only return 0 or -EBUSY, and > most users did not care about the negative error except for few users, > thus we can convert all page isolation functions to return a boolean > value, which can remove the confusion to make code more clear. > > No functional changes intended in this patch series. For the series, Reviewed-by: SeongJae Park Thanks, SJ [...]