From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53BE3C61DA4 for ; Thu, 16 Feb 2023 16:51:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D1DE56B0071; Thu, 16 Feb 2023 11:51:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CCE626B0072; Thu, 16 Feb 2023 11:51:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B95B46B0073; Thu, 16 Feb 2023 11:51:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id A58D46B0071 for ; Thu, 16 Feb 2023 11:51:08 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 5C91FC0BF7 for ; Thu, 16 Feb 2023 16:51:08 +0000 (UTC) X-FDA: 80473745016.17.B5C70A2 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf21.hostedemail.com (Postfix) with ESMTP id B0E7C1C001E for ; Thu, 16 Feb 2023 16:51:05 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ZhxMfgpo; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf21.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676566265; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qsuqqqka4Dh5Lx8AxAIcKybwbe758UfPpp1Jp+Uo14Q=; b=GZpS2dTo5Y4iXOTjTHnwpG27k2AAy8oJ9bgLff/+nGzcZQpDrBlPm5iT98JNVsZtecewtj oOuzGDQFEs6Z5UYLXSB7kPkNJM30C1y70FIDdkxfCddkI5d1RUgKrZEth5m0NNEcHIrl7E VSurx0HtkGNv0JE7wMDfTwehpeh4RQI= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ZhxMfgpo; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf21.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676566265; a=rsa-sha256; cv=none; b=2AN/Uo53uiN5o7z+5R5Rc9bOSy56oXsPtgRpmStPGldeeVG4L8ljLU7lwWXxBn/G2XO4LG 9+/psApgYXMwjG4EF7xgUSZjXE5JV3TRzITuCOa4Wn83sbhKoZ+0Qrfs6oWaZPoQq/jVkm /JdQTQMTmNWKY5RgSMP65Xsvj8qhXuQ= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AE5F862027; Thu, 16 Feb 2023 16:51:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 94DDCC4339C; Thu, 16 Feb 2023 16:51:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676566264; bh=WV879P792kJsz5SaPeIjsyqXQTDsaVQ+LnKlf858IWk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZhxMfgpoRyg1L/xuvXXWMx23CzWRC5drIzOh51SnRipAVzc/qvv5xbyMSJW9v0U12 rOPlEF8P3fivVfY2kVT6h3gbL53YZH0UZHPUgruXcvdQXeq4floSjJEJUJu5FmBbsw Po3Nga6EjuuyWiK9MNnvQ0bm6pFFzOX0NURCXlz/9VhzTTwOe7mD2mP0D1cr9ak2MU x9FTF7dOiWFurVDaxafY9g27V+11h3q24eG9ZLw2X7Wcmq0rDU1e6AYVHDxh6O03EQ CsMtwEFELmz7AlL5bG4Kxo0MIfrKiNnGX1jbzSU6vwRyMi9Lva4sQ60HpMa8FAatG5 CLrSnlw4Mq95A== From: SeongJae Park To: David Hildenbrand Cc: SeongJae Park , Andrew Morton , Oscar Salvador , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] mm/memory_hotplug: return nothing from do_migrate_range() Date: Thu, 16 Feb 2023 16:51:02 +0000 Message-Id: <20230216165102.64115-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <9c274928-1118-1b31-9aff-07cd246cbbcf@redhat.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: B0E7C1C001E X-Stat-Signature: ku6bhq9p1ij1u8goa9qrkjiqdnbxqrad X-HE-Tag: 1676566265-601533 X-HE-Meta: U2FsdGVkX1/ArLEe7PQYxptN0bKzjuUL5Ls809e9RTuxMu9NPJ8pYJgXXv8gCURu5cH9F99rLrMX3c6Z3G7+MvQctXNDQLzF3l7YtgNqa53rFaspzF/5RkEr+IfKyObk/rR+QD6gngZlQ2iqdvsScA5MtpJR1sRolaLmTbGaIXOb66NWK5U4Z1N9bNsFshQwwGKcl3ImCoeDJuxWq/2T2DQM3FaPVIGmpPPg7bhOFZWWgi0hadDH3ZEyoYSxep24WR2esJIuvMAn3Ob8NasM7GbCl9dltxNChv66og7iUCIYtUpl+fHxmAhKGfFogT+brTdomfGP+fAFiP84xqfys+ebCB9H/XfMY2ae1xB4v+Q/uWVVI07DGyEFLNqEA2o/fELxFaJUSOlnjVxzj9dJOeDkr6Rjlpd+druonRdOZkGcd6NjWWQtppLPTOFEfhNuockDHPRjIakzoNXLSQzdzXaU6UUX4zGEPZyibDgam2UdKRGK1poLN+7CZlvDiLULK2JAiiwhiieFBJXFW5UxF7WYmyrR3JlbcF6ALvbUAdpKO7LuqRfSLLqqntkJ1oD8IScC1SV/BZR+ExpxpdnkXYXkM6UEywiqvNWZ3qlHnAoe40HCC/0JKIBgWAgnMvWd4T6Sph7sm7GDSx32+MVuFooCCeLFsL4Y4kqhE1tIFh8ozyndnvBEleNp8bGdRPpLQ4eyjPWZX3CdizhkzhBP+WokuCwaxmaXjIHT2r4zKSYGvc4YDTuMn5cE0AnTsbMnK4CElaiut2HsIABHs8TWwGRAZ6mqpSx+aawZTCC4ImV7Qw5ZIaF+ogMzaE4hYpm8Z/Zbaur2JAXdN6h2gBJjPhpXc3wa0gxnRVXc4dP1kInT0M8P92oyVS+NzIH/R4iQNuhvKvMBqC5Ej8qzKUrQq7iSuGOOEl/qi0XhfORo1FxOQos5yjNc5HLMKttT+YIIZIZmKC7Enu64Uu51q+h IO7/t34g NIBxb/wpXSiHGVrNyj2pstlg9vhYct2Y1wqXzsW+JFtV4OA5+HpxtHu4VZFH98pksmkFXPb3MtiqjSU/42LhWTwWuXd0S6G5IGBzm2hk94VMo4sJdrxm5bWsk9SYAAMeQOpUppzJeGeqr0VrhMeID90QAxmYnJtvBSiz0/PyRSijhBXK1VMlxBStNg4m70TKxlHFoZlXHFPz9XJLa5gJW2sG6L1hae8xVQufJlbHRjh86wgga1xVe1zCczzlKdLREVOnW/VMtbTBrEnYwcSefcRN5A0SJQEWKeqFqn8OSKm5y0fJVQyfMWITHuaaPzLoLtOeM08yyeQ/11SUzSO4g19JBk9Mz5SbyaorCHteBf23LfWsGVp4tLwC9ZrPjBVnCD2YdVPyAe+6o7KhjUt2pOfa/lNEhiFmv/3ScFiVowV+IVFA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi David, On Thu, 16 Feb 2023 10:46:59 +0100 David Hildenbrand wrote: > On 16.02.23 00:02, SeongJae Park wrote: > > Return value mechanism of do_migrate_range() is not very simple, while > > no caller of the function checks the return value. Make the function > > return nothing to be more simple. > > > > Suggested-by: David Hildenbrand > > Signed-off-by: SeongJae Park > > --- > > mm/memory_hotplug.c | 5 +---- > > 1 file changed, 1 insertion(+), 4 deletions(-) > > > > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > > index bcb0dc41c2f2..6c615ba1a5c7 100644 > > --- a/mm/memory_hotplug.c > > +++ b/mm/memory_hotplug.c > > @@ -1620,8 +1620,7 @@ static int scan_movable_pages(unsigned long start, unsigned long end, > > return 0; > > } > > > > -static int > > -do_migrate_range(unsigned long start_pfn, unsigned long end_pfn) > > +static void do_migrate_range(unsigned long start_pfn, unsigned long end_pfn) > > { > > unsigned long pfn; > > struct page *page, *head; > > @@ -1721,8 +1720,6 @@ do_migrate_range(unsigned long start_pfn, unsigned long end_pfn) > > putback_movable_pages(&source); > > } > > } > > - > > - return ret; > > } > > I think this patch should also stop initializing ret = 0 inside that > function. The second patch does it, and I read your reply to the patch asking squashing it in this one. I will send the new version soon. > > With that > > Acked-by: David Hildenbrand Thanks you. Thanks, SJ > > -- > Thanks, > > David / dhildenb > >