From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83160C636CC for ; Thu, 16 Feb 2023 16:55:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EA1C46B0073; Thu, 16 Feb 2023 11:55:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E51796B0074; Thu, 16 Feb 2023 11:55:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D71076B0075; Thu, 16 Feb 2023 11:55:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id C70D96B0073 for ; Thu, 16 Feb 2023 11:55:20 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 870D8807DA for ; Thu, 16 Feb 2023 16:55:20 +0000 (UTC) X-FDA: 80473755600.13.B19D18B Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf15.hostedemail.com (Postfix) with ESMTP id BA6F8A0018 for ; Thu, 16 Feb 2023 16:55:17 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=uGfq53E8; spf=pass (imf15.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676566517; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hNATUVHPxhXh0fzXFWY0osOJlyyCU/kEWuX+fz95P78=; b=XlONIJJ2rEKxM1PTO3Y/q0PupauelOgIqR++8a7UM4EeFwwsc13tsV0f2PKMO71r1+gSvt JIAah1NTuvxxzmLVn33G8U9Ljqnwgjwkq1iUPb+5uW3Ypsb5tpnbZgHlX8DHDN/y7A1Dk5 hfVkZJb4FWU10rYxl0KPYlO5j+viuAk= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=uGfq53E8; spf=pass (imf15.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676566517; a=rsa-sha256; cv=none; b=ysmjCnl1c5gfmdY1AlWI99r1Bggs4RQuhLfEYGeMSpBAQvb6RsCiRhubBPCevLK5YfHQkU WghWXmBBTfghxvYBL49bkw9bdETybb5+NudI/QEldTYfqaJ3TYbYbtnnlBAJI2VLq+h7c6 fyV+Mm01khX7/aTmXL5FnvzsPfyxKv8= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 1D11BB82921; Thu, 16 Feb 2023 16:55:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2764EC4339C; Thu, 16 Feb 2023 16:55:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676566514; bh=j40lAfOGkYAWZrfnC2JLolxDDNUNCyY2yYONJ77J6eE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uGfq53E8knZz63Z/Z1BUIIQouGs6NmKzkS5GvuZ0VXxmkJBAYMyX2cg8yDYEkDnXV EOnpHaTw5WLfjp00KpXtWJbwQF+z10XlMT95sO3BOUtQz0gNoQUB141IhJsOxr4WV6 Ktt9UksOczzASr3JjyLTqTWAjYxuAZv+GAd9NuQkZQU3mub9IbaOZzxBhxxz6e9TR7 S3wV0VTkUM4k044ISB8ktQ4g4Q3JlqoYL9rKFC6g+2cpeMHoVHBm0TRDOVmAVI4Ki3 9sS/WAW6bRZ9HRuaOZoc2vkR37+F8BuWbuVvPfksDKOEEuYJ3EdweTyHEeFT8lUVoW jXoPtNDpeCL9A== From: SeongJae Park To: Baolin Wang Cc: SeongJae Park , Andrew Morton , David Hildenbrand , Oscar Salvador , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] mm/memory_hotplug: return nothing from do_migrate_range() Date: Thu, 16 Feb 2023 16:55:12 +0000 Message-Id: <20230216165512.64177-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: 9tynw5t1h79idewjf4w44uy5mb57gcdb X-Rspamd-Queue-Id: BA6F8A0018 X-HE-Tag: 1676566517-396020 X-HE-Meta: U2FsdGVkX19JrolNdywpJ7FeeFF33VgM96GIyw6NkfqOE4GW33bbfoutr7IEOFbRneY7ydlyCz8B041oo7ECSIdjEd2Sp2LGPmMqFxStyrRo9ODkR1YsM+U8Lb5MCzDh50SlYacbJzwVi2KRpMD7kX8Wkw2XkZFxXUGLhsbWvr5Ly7u0wEcZw/wg+YmR+jrDmZ+Z+psui70LLQzsFlNPhGQ1gMAMnAjSpZCQFCr3hEDNdkENIdPXf2bM7o+Ecy2AGHtj14XDfJ1bNg0j8HYs5HGeZzgxLPVRAj5cPUEL6lUc4Hfbw8lIF4cyoSpe2hfEB/2wnaOnyeNM8YSgDvlzo9C9nFTfQOs+lxVonaalweYOwc3dPhDP9cPmw1/IMsUqjUhvyTX8HLczsYD4lHpmlf7UPYL93KoL3A0b3/XYVAs17EG9N84cNzQjuTEUe1gxbPdVCI/mreXAK6uTFNzhdSODnDiwW1Kb/zPfjja0IsG66oGf3lnA32R6KSP2Gss6x31UjDBwHZQ5yC0WQJZQiLHjILa86Sg283BSG/xCfAuQu8o6T+TOiyzTRpN0y/ajw4edShvKSDg4+v8YkmTCsQr0Yt5IyU4CoTGGiz/k0mb/nVIeMpyFrayrQqGGSMlIvwHUHJJT1zkJAKLv4dEWAFXI3+FscciRadKrLPgO/7BfdakDSiDINJYcae36z6jVPTdc594gMLCs4QqpO0okVXVqebmJ7cta7BbnNZqnzI1x5Gbe6KBQelabk6ZPQuYPEfAouJmiiAIRvvPwtdcIafhQlmeO5ymR7TCKYiIBglUTLcAzVoJ9RPPGJ7nvN35WFR+c7ZZWdFoao61mQzshfb4FsDs8dfipUYgs+5PYy+2xZrG4rq9JcRh41ZnE0CwrWFdgO6IKz8L8FXFTljAHRlwxviHNc0zyK7J0IX/OeBAqYhVfHOWrRDS4mfuCXfbvknDiU1ZUZpomYmcwte4 kFHKkoQ5 1WYvF4NcS5DjI4gnUxFs6tWnNT/IDmVG/rR+iY8G1CdmWb47Sk8DMjefD0fIzQPyeViGAwJ6R98dlCSDob60tGYyfvBqeXVJulAAY82It9Lwz0lGW1bhEfQNEkf5Qr54zgmmK8MuKx9edHRlDv/M9ndu5l0yJWRfz5tHNdCliJ2L9x51BPuZH+PGKI2E63k4F/zt+lMcEQwPbF9VIpoVOQfoFn2FPEm6VzGhbzi4g0uZHIrEGObQPOiXpciw7TMAfKjrAy39hSHzlyH0LrEQqc66t2kJcZRez3EAOR7RYvBnciSdIC2vLgSzK6PUdoUy5yev4xuE0hozlH0L8oyaB1RxUKyrc/wjKU1PjjG+nIwCR88W9aEsoEwjONQtEGXcqEPpA8aX14fu7uV7txkzkkjE/4CFx6odieKmVp21wAC/83lz3AgXDI1nRyoG1gknU28zD X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Baolin, On Thu, 16 Feb 2023 18:53:34 +0800 Baolin Wang wrote: > > > On 2/16/2023 7:02 AM, SeongJae Park wrote: > > Return value mechanism of do_migrate_range() is not very simple, while > > no caller of the function checks the return value. Make the function > > return nothing to be more simple. > > > > Suggested-by: David Hildenbrand > > Signed-off-by: SeongJae Park > > --- > > mm/memory_hotplug.c | 5 +---- > > 1 file changed, 1 insertion(+), 4 deletions(-) > > > > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > > index bcb0dc41c2f2..6c615ba1a5c7 100644 > > --- a/mm/memory_hotplug.c > > +++ b/mm/memory_hotplug.c > > @@ -1620,8 +1620,7 @@ static int scan_movable_pages(unsigned long start, unsigned long end, > > return 0; > > } > > > > -static int > > -do_migrate_range(unsigned long start_pfn, unsigned long end_pfn) > > +static void do_migrate_range(unsigned long start_pfn, unsigned long end_pfn) > > { > > unsigned long pfn; > > struct page *page, *head; > > @@ -1721,8 +1720,6 @@ do_migrate_range(unsigned long start_pfn, unsigned long end_pfn) > > putback_movable_pages(&source); > > } > > } > > - > > - return ret; > > Nit: while we are at it, can we also remove the "TODO" comment in > offline_pages()? > > ret = scan_movable_pages(pfn, end_pfn, &pfn); > if (!ret) { > /* > * TODO: fatal migration failures should bail > * out > */ > do_migrate_range(pfn, end_pfn); > } > > With David's comments: > Reviewed-by: Baolin Wang As David mentioned we're just still unclear what issues are fatal[1], I was thinking we didn't forgive the future work, so left the comment. If anyone has different opinion or I'm getting something wrong, please let me know. [1] https://lore.kernel.org/linux-mm/388b9a93-423f-33f8-0495-2a4a290fd1aa@redhat.com/ Thanks, SJ