From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A51B0C05027 for ; Fri, 17 Feb 2023 12:51:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3089D6B0072; Fri, 17 Feb 2023 07:51:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2B8756B0073; Fri, 17 Feb 2023 07:51:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 180066B0074; Fri, 17 Feb 2023 07:51:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 0C90D6B0072 for ; Fri, 17 Feb 2023 07:51:14 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id B9E7C140335 for ; Fri, 17 Feb 2023 12:51:13 +0000 (UTC) X-FDA: 80476769226.06.35F3590 Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) by imf04.hostedemail.com (Postfix) with ESMTP id 0393E40017 for ; Fri, 17 Feb 2023 12:51:11 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=VBbJd3E2; spf=pass (imf04.hostedemail.com: domain of alsp705@gmail.com designates 209.85.167.49 as permitted sender) smtp.mailfrom=alsp705@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676638272; a=rsa-sha256; cv=none; b=aT7oNzn5HEw1tqgOZRYAJL1IXKTpBUU2+C9Vm/XO8ii5nLfIZ/nGOkcS83DpNSQ3PPsRFW 6fhvs77YyU2zzBpWPbWt3lIt9U6ZZcgbZxvc3+P6vwbccxZvjnJ7AaZF3YNMPN3VY5TmqC tdzfBEyrbksZeYS6eDKKBYskQ1dubgg= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=VBbJd3E2; spf=pass (imf04.hostedemail.com: domain of alsp705@gmail.com designates 209.85.167.49 as permitted sender) smtp.mailfrom=alsp705@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676638272; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=jgNqnsBkYaCl5xkY3KlgmTZm82cO+lOw99V4TeAbx8s=; b=lPrdRiLAq925Hp7ECz3VjsnZVyIDv0GbEyUN3dTZ4ZHG3dyIRd07nQ39rj0giuSaWjZ3NG flq7fRPg98eMNlduGMZhti8wb2jAC+WV/RB+IkzN/iufYTdcvPK1qhcDNPdofbMrZUoojE gQ7qx/qZxRaqCIk4yhhYqMq4xoCH3H8= Received: by mail-lf1-f49.google.com with SMTP id i13so1671792lfe.1 for ; Fri, 17 Feb 2023 04:51:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=jgNqnsBkYaCl5xkY3KlgmTZm82cO+lOw99V4TeAbx8s=; b=VBbJd3E2ahAuXoQ9gq2Evs4X9KEgqjGa4Tg5BkFu4z4jBSrk/PVVxjvR4dZbujdofX YS5LZ6jXtenSdl63536STE/eRY4ZcTZYN15BG6apVceJJE6ccdNfsIwwsKMln2LpzYo0 eWZm1DWVTwx8B8YV4IDspQcY4RsAgauDE2IzlruIXBPEUqHyXPJ170g7DaC3M1OZsr7u 3ytd2ubOA4wXKi8dwRvmRn0hnGqs5GyQTOayR6KXGpBQNlDYvb598wy/qGWLtnGiqrmF Xao3BKYqV6rUO/3lQjMTD6ZbIPQ8ROtRor2QaUaJG32k98uY7kOiUJICTkoh2umfFX5s lHUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jgNqnsBkYaCl5xkY3KlgmTZm82cO+lOw99V4TeAbx8s=; b=CrQBcM7ZDy1WRYgGwPY20HfbLtDrjlK9Fm8DQgfldZdny5ZZedTljapd3ruMDfau8V Qt6jAjiOCBcVz1aApgZbOwEqe03ppmTYilx2NrAFh+nQsobrpTKF/mMq32vN/xjZYToG iixy9nNzujPo3P85pFV9GzAlCIbxvmdkD6SgTtQm7m7wxHa93yfo7ia1Y23cmeRWipoZ ex616lCb6IL/+lLhKb4LCkP6HMNPsdq1RTh4lz1fw4m1a7AD+7YNqncLTsot7Xrs9ilF FHaHYiJDaQHa2C9p2nGkBSRejIaFwgA8lgjGyT2cdZ02Xr0Qthl7AD5eRzLaSxYhemFB MYQg== X-Gm-Message-State: AO0yUKXsVirODXr4uSZR/jKg4Iy2R2vzYrgarFQaG0sRi554W1qbfnQc REX3qCvZhpkBMk1jXVIsYKw= X-Google-Smtp-Source: AK7set/1BG58dEEH7rx4ZHr9S10NWckBjtDSjNDcX+jBE02MDMlxlumkQDceZsPwi7VpNoJroONmwA== X-Received: by 2002:ac2:5972:0:b0:4d8:6540:a72f with SMTP id h18-20020ac25972000000b004d86540a72fmr369208lfp.46.1676638269937; Fri, 17 Feb 2023 04:51:09 -0800 (PST) Received: from alsp.securitycode.ru ([2a02:2168:8bff:fb00:c81a:1ac1:84a6:458f]) by smtp.googlemail.com with ESMTPSA id v24-20020a197418000000b004db250355b3sm673997lfe.138.2023.02.17.04.51.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Feb 2023 04:51:09 -0800 (PST) From: Alexander Sapozhnikov To: Andrew Morton Cc: Alexander Sapozhnikov , Uladzislau Rezki , Christoph Hellwig , linux-mm@kvack.org, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org Subject: [PATCH] mm/vmalloc: fix unsafe dereference of potential null ptr in vmalloc_init() Date: Fri, 17 Feb 2023 15:51:05 +0300 Message-Id: <20230217125105.12385-1-alsp705@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Queue-Id: 0393E40017 X-Rspamd-Server: rspam01 X-Stat-Signature: amo7ot1f6qdmgznwfxkaktgxea6ushps X-HE-Tag: 1676638271-964485 X-HE-Meta: U2FsdGVkX19I4Y8EfSEvbCRztFxga76BcAgHcUoLuzc0BE7KRugs7i9UDvGmn0XArTn9PBoN/pqrg77tQ1M14nSAnH3II0OeC83OOnkTGrE/o4EnpB0cnPMOObdm9TCPMpy9eGhK7zITOQHPz4z8d3F09uST+UsaBraOJZSn0qO4sI3h7Nri5P6XtALQjVSklcJNCB3wxlWG1kGe/BPRDepipG/j/3PAtoI0TT7qDDHrQybS7YtnU5hdCw1l4Ky8ngV61VXH/oPO4OsbDo28lYp1GoVcOydyGyq3k6VoCjOQApwNbjI9u1zvSyuCo7Bu2s3C07CSD0CLHrZqGDPKC/BOPmMZWF58CcpP4ixztSJZR/EGC0gmu+squQMzn9CpyD39C7Ko83f2lw4spC9wf9Cf7SQUoX/bJ01cTRWhUchGCY0O0fyBElMw+N4apK1QX/UnZR/0cXSkSAiVJlzzJD4yncfkRSCCHN02Vjz93xB4NLvD6xhZN5GGeXOeC8z3JTVw5fOiMFySF5e4vgUlQ9bvlulz+F5V5Z7FyGxl97E1F/thjWeWklPckvrDV+xeYON/qViDu5tAFNvgMjdj1k0A5gMQTE0ryXq9+4FckduIX3NOpCJI831bNqI79iMcZlhe731REkdWJ2yJG4V3wVgu9zjbvN5aAMnveO3xjVkX+/gn7TCFbtogu0NAPdhQLYSJ30y3K9Via8KbxV4Ah0dVZySkdos8v2MUdjPXAh3cEu+mPFKF9jrl8J57FX2wt6F0cEdkX7BDBD1rUdOSJy30yLRcr2tCBGLsttWn7S7sXeSjKqnozBdFWq/mlJgaWoVRk/1YbDIaLq8QW34TOTIyLxOrADW/C1WLDfZ2Wyrozyfz9stHitWEHhgBjzSkZz0gvTsGnc/NPsKX6oTlu2htQDn/7TWn74ca3sJDui5vazVbYci59Z/L35cNPMD6plKIlB05upVyevGFrgJ e4zYESpH RDrK6WGnAwdFSFPDRgMx+0mX9uPbqPKsqAt/CIhVL9bHztvUVInjSZuUzGh4xr25qr0qSdL1xZdI98dLJpjQoqZykoCmf7nJr0DoeGVsITAW6S8Oyc2VMFzI7DOTnY4o4AKd59eAdXK+sQ01dmBdBRK7SPG3Hg8muKjjVuErbX0oT1TUyjdEHKbw9ib/1l8kPT61lSc8Z2fnOtvLZv3+N3VV8+FoTHSg8fZLL0SdNL1jh1+p/VEyvXwMrTio8ZN+CDEFRSly1PtsAcl1c6CvB3ntfMbkh9+Kvbp1MDcFTZWrmxXmXnWf4xi3IzzU+pHysv1PfMOFmYW5a1shCxVpQGT0/m+DK6y/Q9Mf4Ki3o6pdcFTADirU5UVW3hwXJr6YPBj7r3cEa5sxODEEcgEViuaRNjBP+/M354R+EC7IdQkzVPntsMGMn2sw4D0CEUIlzy+CidiqbmoJZUHtXmATWAJjfjuml+lH9WrWhTi3siydaQMlMJqAIKj47n31Ed7aIMaFVHw5lY2uSf9vg8ayuwfuCA9As3MX1EBCStwfG9aZ+knk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Return value of a function 'kmem_cache_create' is dereferenced at vmalloc.c:2444 without checking for null, but it is usually checked for this function. Found by Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Alexander Sapozhnikov --- mm/vmalloc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/mm/vmalloc.c b/mm/vmalloc.c index ca71de7c9d77..ed75dfd44b85 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -2426,6 +2426,8 @@ void __init vmalloc_init(void) * Create the cache for vmap_area objects. */ vmap_area_cachep = KMEM_CACHE(vmap_area, SLAB_PANIC); + if (!vmap_area_cachep) + return; for_each_possible_cpu(i) { struct vmap_block_queue *vbq; -- 2.34.1