From: Vlastimil Babka <vbabka@suse.cz>
To: linux-mm@kvack.org, "Liam R. Howlett" <Liam.Howlett@oracle.com>
Cc: linux-kernel@vger.kernel.org, patches@lists.linux.dev,
maple-tree@lists.infradead.org, Vlastimil Babka <vbabka@suse.cz>
Subject: [RFC 08/11] mm/mmap/vma_merge: rename adj_next to adj_start
Date: Fri, 24 Feb 2023 11:00:19 +0100 [thread overview]
Message-ID: <20230224100022.11268-9-vbabka@suse.cz> (raw)
In-Reply-To: <20230224100022.11268-1-vbabka@suse.cz>
The variable 'adj_next' holds the value by which we adjust vm_start of a
vma in variable 'adjust', that's either 'next' or 'mid', so the current
name is inaccurate. Rename it to 'adj_start'.
Signed-off-by: Vlastimil Babka <vbabka@suse.cz>
---
mm/mmap.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/mm/mmap.c b/mm/mmap.c
index e05bbcaf7b61..8c2bdf9e3f94 100644
--- a/mm/mmap.c
+++ b/mm/mmap.c
@@ -903,7 +903,7 @@ struct vm_area_struct *vma_merge(struct vma_iterator *vmi, struct mm_struct *mm,
bool vma_expanded = false;
struct vma_prepare vp;
unsigned long vma_end = end;
- long adj_next = 0;
+ long adj_start = 0;
unsigned long vma_start = addr;
validate_mm(mm);
@@ -971,7 +971,7 @@ struct vm_area_struct *vma_merge(struct vma_iterator *vmi, struct mm_struct *mm,
remove = mid;
} else { /* case 5 */
adjust = mid;
- adj_next = (end - mid->vm_start);
+ adj_start = (end - mid->vm_start);
}
}
} else if (merge_next) {
@@ -979,7 +979,7 @@ struct vm_area_struct *vma_merge(struct vma_iterator *vmi, struct mm_struct *mm,
if (prev && addr < prev->vm_end) { /* case 4 */
vma_end = addr;
adjust = next;
- adj_next = -(prev->vm_end - addr);
+ adj_start = -(prev->vm_end - addr);
err = dup_anon_vma(next, prev);
} else {
vma = next; /* case 3 */
@@ -1002,7 +1002,7 @@ struct vm_area_struct *vma_merge(struct vma_iterator *vmi, struct mm_struct *mm,
if (vma_iter_prealloc(vmi))
return NULL;
- vma_adjust_trans_huge(vma, vma_start, vma_end, adj_next);
+ vma_adjust_trans_huge(vma, vma_start, vma_end, adj_start);
init_multi_vma_prep(&vp, vma, adjust, remove, remove2);
VM_WARN_ON(vp.anon_vma && adjust && adjust->anon_vma &&
vp.anon_vma != adjust->anon_vma);
@@ -1018,10 +1018,10 @@ struct vm_area_struct *vma_merge(struct vma_iterator *vmi, struct mm_struct *mm,
if (vma_expanded)
vma_iter_store(vmi, vma);
- if (adj_next) {
- adjust->vm_start += adj_next;
- adjust->vm_pgoff += adj_next >> PAGE_SHIFT;
- if (adj_next < 0) {
+ if (adj_start) {
+ adjust->vm_start += adj_start;
+ adjust->vm_pgoff += adj_start >> PAGE_SHIFT;
+ if (adj_start < 0) {
WARN_ON(vma_expanded);
vma_iter_store(vmi, next);
}
--
2.39.2
next prev parent reply other threads:[~2023-02-24 10:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-24 10:00 [RFC 00/11] cleanup vma_merge and improve mergeability tests Vlastimil Babka
2023-02-24 10:00 ` [RFC 01/11] mm/mremap: fix dup_anon_vma() in vma_merge() case 4 Vlastimil Babka
2023-02-24 10:00 ` [RFC 02/11] mm/mmap/vma_merge: use only primary pointers for preparing merge Vlastimil Babka
2023-02-24 10:00 ` [RFC 03/11] mm/mmap/vma_merge: use the proper vma pointer in case 3 Vlastimil Babka
2023-02-24 10:00 ` [RFC 04/11] mm/mmap/vma_merge: use the proper vma pointers in cases 1 and 6 Vlastimil Babka
2023-02-24 10:00 ` [RFC 05/11] mm/mmap/vma_merge: use the proper vma pointer in case 4 Vlastimil Babka
2023-02-24 10:00 ` [RFC 06/11] mm/mmap/vma_merge: initialize mid and next in natural order Vlastimil Babka
2023-02-24 10:00 ` [RFC 07/11] mm/mmap/vma_merge: set mid to NULL if not applicable Vlastimil Babka
2023-02-24 10:00 ` Vlastimil Babka [this message]
2023-02-24 10:00 ` [RFC 09/11] mm/mmap/vma_merge: convert mergeability checks to return bool Vlastimil Babka
2023-02-24 10:00 ` [RFC 10/11] mm/mmap: start distinguishing if vma can be removed in mergeability test Vlastimil Babka
2023-02-24 10:00 ` [RFC 11/11] mm/mremap: simplify vma expansion again Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230224100022.11268-9-vbabka@suse.cz \
--to=vbabka@suse.cz \
--cc=Liam.Howlett@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=maple-tree@lists.infradead.org \
--cc=patches@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).