From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFCF0C61DA4 for ; Mon, 6 Mar 2023 13:03:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 521D6280001; Mon, 6 Mar 2023 08:03:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4D2B86B0075; Mon, 6 Mar 2023 08:03:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3C111280001; Mon, 6 Mar 2023 08:03:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 2C2F16B0074 for ; Mon, 6 Mar 2023 08:03:53 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id EAB8A120BA1 for ; Mon, 6 Mar 2023 13:03:52 +0000 (UTC) X-FDA: 80538490704.18.C9C1235 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf02.hostedemail.com (Postfix) with ESMTP id BCB7D80019 for ; Mon, 6 Mar 2023 13:03:49 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=none; dmarc=none; spf=none (imf02.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678107830; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CvRetN84RizM8fo+ocdh9g2DFYywrhPV8mFZfDntuZI=; b=iKapYN5RLUx0aNAKuZNX/83rWxaLgIW+MBsZ3BO19mdMBlYDpbp1sIGKb81ui6xA0HEfhe ffdQCKTP5TuRq51c1SyfXihl5gSVIx97GqrL+k7MTyWUJZJjNXP/WNZQy2nSTef6KIQ9Q/ l3zibUx2AIesJfb3+Kmi8yiSpz+5/28= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=none; dmarc=none; spf=none (imf02.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678107830; a=rsa-sha256; cv=none; b=lxoJdxZXyotDBgKW0fFTIXDKwk+8y7AiZRNOs6oDbo30eSKbXCiYQ4Bbg4v/UiQUKz7VR+ Q5dzwmohgARBEotpwoaLzxza7eJK+jPb5NMwewZj54j2I786Mg3RiJ0xHsj5BAhmKwVN4E vSun23h+P7lMWtjR8aqe2OhX2UEbEv4= Received: by verein.lst.de (Postfix, from userid 2407) id EB2CB68B05; Mon, 6 Mar 2023 14:03:44 +0100 (CET) Date: Mon, 6 Mar 2023 14:03:44 +0100 From: Christoph Hellwig To: Stefan Roesch Cc: "Darrick J. Wong" , Matthew Wilcox , Stefan Roesch , io-uring@vger.kernel.org, kernel-team@fb.com, linux-mm@kvack.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, david@fromorbit.com, jack@suse.cz, hch@infradead.org, axboe@kernel.dk, Christoph Hellwig Subject: Re: [RESEND PATCH v9 04/14] iomap: Add flags parameter to iomap_page_create() Message-ID: <20230306130344.GA14467@lst.de> References: <20220623175157.1715274-1-shr@fb.com> <20220623175157.1715274-5-shr@fb.com> <0d43e015-057f-2379-a0fb-d55539b803eb@meta.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0d43e015-057f-2379-a0fb-d55539b803eb@meta.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspamd-Queue-Id: BCB7D80019 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: tfxdnqkhiq3iqw79mmse9xswsrjsi4m9 X-HE-Tag: 1678107829-266101 X-HE-Meta: U2FsdGVkX1+sIGrOzO92LGjDj7yIFKNQKOiURCPPX/WJ+K6MC3/Lzj5coBnTEhrWC5/dJcCtKa0D31PZ640fwY2yUdxu498O+QoWTfGutQhnkYc8pC8f6vo1M26EZlh+xt7QxGALlSc4EsKQ8kHO9+VTw+00Xgw7eKh8X98jVY1zLNEgQb2s+1o2AseNXgO8OQLivN8btPAuBI1oWNJnHV8xuh5tbdc8ag9CCrHNyrXyzt3E3Mi/KBwOhjg1s5Kte/s8jdX2zqhdKv10ChqsTMWWbw0OPI2kt/fTxQ7siXUC1I94xiyxlLHwGsw2ETGdzK3b3NEGdg/eEXptW5qRp0oKuf4hnv0BsOzLLwcX8LzfBwE+alsSVbCUddxI/wA3odORl584oRJ27TipREU9mHpyOgZZ4ABcmNQcP26qgGgXW2tE74epkTV/nUHCbXks3Zjhtc48QZF5X44ilLWYAogIBK7oVIb8NJs+UQtJlO1x99CwMoyj5RZFiOxAnbToUhLpbhY0cKun28M6L48fS/dasmZavi9vUzMhgqf4QbSVNbAj94MB2BxOOkVg2qAdVAr1ArKws8KGC5yJu+nqDnpK7XWPXET0ZOf4HfeubRCLaFGaCa8xj9mFUVEHw+8m5xdBDpRdmz0Y7cfKStoiOPHDYTbIixF2Pcg//QZCS4YG6Os4x93WXto1N0fkFdqoBtbE36qLpKJ/sSGh/Pvp9NqBNTcUq1++DT9kqlObUSaiOoGV+vr75HmAmCF3HBOuFObrBWcloCYpZXkn4wOaZt9+KRibkygh+Wv8JDuM7w8X/pBw70bO0r792u6YE0gKBQd9I+4eOzOKdoMbPFYz2bxk48kq1bNHbvqlbMWckXHaLIN9DpDCy6OzXwfD9EAEx5IgBySS71xw9VfbQxIxS1RPS2bJ0C0VyPI7BCqzW7mBvEnNNE8rNIBj+t6GnRzlvgK3K1hApVBYtxo+xkJ M4x85qIW YJBHMSkSdQmz3ocqPwBgGzl/H/3Gu/tK2MwAZAgH0IE3jiPz8cu7EMtO23o1XkeXYKLM70aNYtoAqlKcnRtv6qsGd/D8qDYh8/FFC2wqYV/vubIILL8/vqcDxZm8epWHq1ng3/jQZF79Cq9Y= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Mar 03, 2023 at 09:29:30AM -0800, Stefan Roesch wrote: > If IOMAP_NOWAIT is set, and the allocation fails, we should return > -EAGAIN, so the write request is retried in the slow path. Yes. Another vote for doing the ERR_PTR. willy, are you going to look into that yourself or are you waiting for someone to take care of it?