Re: [PATCH v16 03/13] overlayfs: Implement splice-read

Christoph Hellwig
2023-03-09T09:29:15Z

On Wed, Mar 08, 2023 at 04:04:39PM +0000, David Howells wrote:
> Christoph Hellwig <hch@lst.de> wrote:
>
> > On Wed, Mar 08, 2023 at 03:54:36PM +0000, David Howells wrote:
> > > Using do_splice_to() as a helper is probably a good idea, though both Willy
> > > and Christoph seem to dislike it.
> >
> > That's not true. What I'm fundamentlly against is pointless wrappers
> > like the call_* that add no value. do_splice_to adds useful checks,
> > so if properly named and documented, I'm absolutely in favour.
>
> Fair enough. Rename to vfs_splice_read() okay with you?

Yes.