Re: [PATCH v3, 0/4] mm, memcg: cgroup v1 and v2 tunable load/store tearing fixes

Michal Hocko
2023-03-08T17:40:16Z

On Thu 09-03-23 00:25:51, Yue Zhao wrote:
> This patch series helps to prevent load/store tearing in
> several cgroup knobs.
>
> As kindly pointed out by Michal Hocko, we should add
> [WRITE|READ]_ONCE for all occurrences of memcg->oom_kill_disable,
> memcg->swappiness and memcg->soft_limit.
>
> v3:
> - Add [WRITE|READ]_ONCE for all occurrences of
> memcg->oom_kill_disable, memcg->swappiness and memcg->soft_limit
> v2:
> - Rephrase changelog
> - Add [WRITE|READ]_ONCE for memcg->oom_kill_disable,
> memcg->swappiness, vm_swappiness and memcg->soft_limit
> v1:
> - Add [WRITE|READ]_ONCE for memcg->oom_group
>
> Past patches:
> V2: https://lore.kernel.org/linux-mm/20230306154138.3775-1-findns94@gmail.com/
> V1: https://lore.kernel.org/linux-mm/20230220151638.1371-1-findns94@gmail.com/
>
> Yue Zhao (4):
> mm, memcg: Prevent memory.oom.group load/store tearing
> mm, memcg: Prevent memory.swappiness load/store tearing
> mm, memcg: Prevent memory.oom_control load/store tearing
> mm, memcg: Prevent memory.soft_limit_in_bytes load/store tearing
>
> include/linux/swap.h | 8 ++++----
> mm/memcontrol.c | 30 +++++++++++++++---------------
> 2 files changed, 19 insertions(+), 19 deletions(-)

Acked-by: Michal Hocko <mhocko@suse.com>

Btw. you could have preserved acks for patches you haven't changed from
the previous version.

--
Michal Hocko
SUSE Labs