From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64EA4C6FD1C for ; Thu, 9 Mar 2023 09:29:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E29CA6B0075; Thu, 9 Mar 2023 04:29:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DD9F86B0078; Thu, 9 Mar 2023 04:29:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CC9F3280001; Thu, 9 Mar 2023 04:29:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id B98566B0075 for ; Thu, 9 Mar 2023 04:29:14 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 878C78020F for ; Thu, 9 Mar 2023 09:29:14 +0000 (UTC) X-FDA: 80548836228.02.3C5B386 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf06.hostedemail.com (Postfix) with ESMTP id CA24D18001B for ; Thu, 9 Mar 2023 09:29:11 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=none; spf=none (imf06.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678354152; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1fgPTKOpVp6UsA5UFeLdljrKu9KH70wgFuby19I3goY=; b=oBcbdcWYJw/9hpZkZ4y5wen26F2lzdtLf2r/pDCZQjveEKUo1k7LH3QvUAvjgcuXMnhZub cLYPtc8aJSdzUYl0q1Plw4vUNna7JL2vCUWEfG+Fey7z+xOGKnYnSprL4MhpyyPT/qVCFD vsDqrPTVYsSKjK5XRetahrCTmkSEbPg= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=none; spf=none (imf06.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678354152; a=rsa-sha256; cv=none; b=nAvk/2AvGTrOlm7T1k01mlSILM7OZpj80bJRq+TbdTGGoixeKvCaxLy39REnbDCvYr7JO3 8CB5ZarKpSix9x3OsTfD4uV1D69wTr7BVI+A4HNCdamLBf2XYEUahBv6gMYFK15SfOyoZJ dG3adGYlBWMdeA4FQzQxDnliLGinG8s= Received: by verein.lst.de (Postfix, from userid 2407) id 2C6DB68BEB; Thu, 9 Mar 2023 10:29:07 +0100 (CET) Date: Thu, 9 Mar 2023 10:29:07 +0100 From: Christoph Hellwig To: David Howells Cc: Christoph Hellwig , Miklos Szeredi , Jens Axboe , Al Viro , Christoph Hellwig , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, John Hubbard , linux-unionfs@vger.kernel.org Subject: Re: [PATCH v16 03/13] overlayfs: Implement splice-read Message-ID: <20230309092906.GA23816@lst.de> References: <20230308155609.GA21508@lst.de> <20230308143754.1976726-1-dhowells@redhat.com> <20230308143754.1976726-4-dhowells@redhat.com> <2011735.1678290876@warthog.procyon.org.uk> <2012343.1678291479@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2012343.1678291479@warthog.procyon.org.uk> User-Agent: Mutt/1.5.17 (2007-11-01) X-Stat-Signature: r4rnxhau46ex9np7mnucrb34yow1mqfh X-Rspam-User: X-Rspamd-Queue-Id: CA24D18001B X-Rspamd-Server: rspam06 X-HE-Tag: 1678354151-997092 X-HE-Meta: U2FsdGVkX1/C9CN+Xw1PofQe3lBY6vxOVN4dwUL7a4D11PpRU01RMQUm6Y7CA5XQzsG1hf8QK9JyS2mqQ7OogOy0bhbuq+dyxm52e/KtDFGGCr15QtWU87g9UDXFp0R0WQXEqwX330cIDorEAHW2+eP5lCTX8v/VIaaNaBQrfG21JD+tlUjl2O4yadF8wxCspC3v3qpaeDYydZlleb4WO3zSpdl9HftgCRmd0GyOisE1qaHO0fI985vzE6Vp6HJcN63s/zmKz42tIkg0JhEd14Kg2D7+HNQxdI2Gnwa0zz9oWFaME5WHAigLaFSwOhfIuWbNSwJvgw0lVVMqSpuRcWidIhMjz01fAW3fu01FKJOu3Ob/HeFPNEHE8UzDpxHokkg4GPHN8of9P0PJAXlkrnXyTl/6+1Mw6yzyvJHMck31it0ZwGmRYJUOh/C+K+ujWHn1tQPlHXWYScUxRcUUEn8f/wHDiMCGWkdKJV97c4Ds1zrOesQUJyAFpaSALFrtf4QyFsl4CeXVnbXQL29UI4/f8wLng8HqbedJPdhXf59mOzs6HACvcyYp7NrTlKoS6JvZJqD64KHgxN36adzvFYZL4PJkBbBUMDwmnvChAmxht8LMW1yadhvNDE2yaf6LMkzSDYA8d49SSshK6MPds+lYePTPazHlDzoT9J48jSUE9Vkz0P6ImCt1DnhKRC6JFUcQGWnwiKGUQQcErdfPTPx4otdZ3DpuX0KbKEjcbSKGxrxf/Y3hpN41+H6giFzEaUZ2oXwzOObfDj5irQrxcnTrtwTrskTrWQGapLarX9F1/dNW2m9Q2rTIWwCvuqXK/PUz2lafOU9tAlpaprO2T7q+s1huBA3LU1GzaK5mICnMRHLrIC4xkIh8r4D1dvPhPxaGYSiTV311nTDRjqqtqVfKekv3DjNq9UMzxB0eBCK0FsKn/Lh4YcrIgr4V4a58DzkNqV7VbU/fkyHg1o0 iVKw2Ncj ldBeDFLfsJ0IHzs8+ZH4yENWsv1YuRis3zgzv+yisP6ct8JCEbkdl8k+aKYOyGtxBzBtg+gzi/80XopM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 08, 2023 at 04:04:39PM +0000, David Howells wrote: > Christoph Hellwig wrote: > > > On Wed, Mar 08, 2023 at 03:54:36PM +0000, David Howells wrote: > > > Using do_splice_to() as a helper is probably a good idea, though both Willy > > > and Christoph seem to dislike it. > > > > That's not true. What I'm fundamentlly against is pointless wrappers > > like the call_* that add no value. do_splice_to adds useful checks, > > so if properly named and documented, I'm absolutely in favour. > > Fair enough. Rename to vfs_splice_read() okay with you? Yes.