From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F340C64EC4 for ; Fri, 10 Mar 2023 06:38:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AE470280001; Fri, 10 Mar 2023 01:38:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A94D06B0074; Fri, 10 Mar 2023 01:38:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9838E280001; Fri, 10 Mar 2023 01:38:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 89E636B0072 for ; Fri, 10 Mar 2023 01:38:03 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 3625914163B for ; Fri, 10 Mar 2023 06:38:03 +0000 (UTC) X-FDA: 80552033646.30.7ECC037 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf04.hostedemail.com (Postfix) with ESMTP id 4817040009 for ; Fri, 10 Mar 2023 06:38:00 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=none; dmarc=none; spf=none (imf04.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678430281; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=My8kCtKqeDKR5ImFpUYe+8dSD05+fHXvl5GfG7BXthY=; b=0tbtvx+ps1NAj0Kej4mLmC0WlfIarAovzXhzailLvaQfaodO4nBqc7oGpokmYxoxMgUijY fvebvNrif30R3qj43l3H6/kJMCMeUkMpDYyxMVm/+GyyjTZ1ttPyHCVl4Bo7CB3ofMWukV 3oyBeNx4p8X5tO0Ek9dH92XQuZNrBtM= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=none; dmarc=none; spf=none (imf04.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678430281; a=rsa-sha256; cv=none; b=g+kz/AHlGqnqtPBW8zN5cLq0au0iOyMTZu+pz2UB4ZPyd+jgHhWZ/SYyEEeLMJFlTf4PX6 bUN4BFU7NN5uQ7hP497O32RkUx6eAKTR2L0E+W7DpfBNrT8RUKAxaZf/kVxFhdSJNfy9nO 8vlEP5nn/m6dsSRyHGO7QQk4wBTqM8Q= Received: by verein.lst.de (Postfix, from userid 2407) id 4AC1168AA6; Fri, 10 Mar 2023 07:37:56 +0100 (CET) Date: Fri, 10 Mar 2023 07:37:56 +0100 From: Christoph Hellwig To: Al Viro Cc: Christoph Hellwig , Andrew Morton , Mark Fasheh , Joel Becker , Joseph Qi , Evgeniy Dushistov , "Matthew Wilcox (Oracle)" , ocfs2-devel@oss.oracle.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 1/3] ufs: don't flush page immediately for DIRSYNC directories Message-ID: <20230310063756.GA13484@lst.de> References: <20230307143125.27778-1-hch@lst.de> <20230307143125.27778-2-hch@lst.de> <20230310035353.GM3390869@ZenIV> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230310035353.GM3390869@ZenIV> User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspamd-Queue-Id: 4817040009 X-Stat-Signature: jtxe93wjb6qf1jxfetcibd8bs8kwh1pm X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1678430280-249275 X-HE-Meta: U2FsdGVkX1876BTiJHNuAtRlMpGi4q2Pj4+JZimGaZNC/0ocZUXbSA26ZLhqfsoPgvxA11qrRL9VLSzd6fQHKWyoYyeCwW0APgqZVjMswWmLVvxR1ILIEG7yUPDvazyk1MP8EEm/cRrIdKjPwZVOfg/s5E8aDQ6afGSs3lBz8U1XxuirrPdqL7337wIU2M2BOeSt2yZE2k2JftcImuZrYE5huxtAZjF6Y3EVkAt3jE2kz31xPlfWlcsr02NX//P5Ba3Lfv1M84JREh72IUPySpQQGAIbe0+EzN9RGbsr/x8Ro+ldkHG4G0vV305XGTk4au1kbpZ0CW5uZcJxCY3wGr7eBwF/CZs+9JpIOB4FhJip/C49wvXFctUeS8IyK/ncsIYqjIZ0hiHYgOznLIdmi8eq10Md0rN2PE95vAKJqK4pG5U0cz5xXY88DBmIzgjQDBoo6Y6HcFs5wQQUO5+775QKHpRQOtyBlLZ1EmZpDHKPRnB/jiU1xfSN36W/mo6SCOEbHzHL2wG43uWpolbfSkFJoV7tlbdou+UW/VoH4w2KjMQgP6GxcDmjlj7Me3aRm1Cc031t/QzJfaoSqNcOz+3Bdt6D1jlaB8LBoQxGNI2WneSEp/XNT83t/bA/01SokyqG3+hixdA6fWlLmCy/H/a6V88RxEFlBE00eXlh4tfd85xDJB6YXezpF4AHiwsgkfXd7JDXEflv6+rVCJOEvpN2JEqqdqrQ3r98AUABBMN8P50OtMRbpds5CJgX4otuRSjoayOZNfEe4mETY0pg8nlqtHP8mHJijoMUmUnZYJNoTWfinvVHTo9lwpEJldraullkboMt9eMvU4TLDdo3MeMFpTA+VkpNnqSbf33koyExO/Yh00yhxTIzvWEqb21vkG1kDNIVFi9gXADoBqxv17zqn+WhfKUH5KOs4cP65oqqnPjKnKQcYLibqQc548d7cheXlG8ebUePCfHpJDs VhSyBfIr XmQc2Jas3RAprZQyphEmQ0NAtWrzke9XGtl9AO+AjF7SW7zK8+zOP/YV63929EOCJIDp4ZsSBI08iUtE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Mar 10, 2023 at 03:53:53AM +0000, Al Viro wrote: > On Tue, Mar 07, 2023 at 03:31:23PM +0100, Christoph Hellwig wrote: > > We do not need to writeout modified directory blocks immediately when > > modifying them while the page is locked. It is enough to do the flush > > somewhat later which has the added benefit that inode times can be > > flushed as well. It also allows us to stop depending on > > write_one_page() function. > > > > Ported from an ext2 patch by Jan Kara. > > Umm... I'll throw it in ufs pile, I guess (tomorrow - I'll need to > sort out Fabio's patches in the area as well; IIRC, the latest > had been in late December). Well, the three patches really should go together, otherwise we miss yet another merge window.