From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABFE5C74A5B for ; Tue, 21 Mar 2023 11:21:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C757F6B007B; Tue, 21 Mar 2023 07:21:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C25806B007D; Tue, 21 Mar 2023 07:21:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AC5C06B007E; Tue, 21 Mar 2023 07:21:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 9AE3D6B007B for ; Tue, 21 Mar 2023 07:21:42 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 6A31CA123D for ; Tue, 21 Mar 2023 11:21:42 +0000 (UTC) X-FDA: 80592665244.01.A24A3B6 Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) by imf12.hostedemail.com (Postfix) with ESMTP id 721DB40011 for ; Tue, 21 Mar 2023 11:21:40 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Jlq4oSD6; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf12.hostedemail.com: domain of zhi.wang.linux@gmail.com designates 209.85.167.50 as permitted sender) smtp.mailfrom=zhi.wang.linux@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679397700; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uoj6FCTyIPYbsFB5rJ42Dq7STG9j1TgfTfZlYEk8Sgk=; b=uRmOJWMRh1d7nlv3MfeDaB+NCVwuAYqCCsTw4cySpl1erv6UwaB7l1yxRAXVDbQADu7ick k0lvFs5u5zDcoibuqvn+NWBjlQicgUqdpR67jtRFhJZe8ksaxI3oAk5SB35kidpmPJF4oH Prqohp5aJQFSuG2bFefOwqVnq0i3mQw= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Jlq4oSD6; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf12.hostedemail.com: domain of zhi.wang.linux@gmail.com designates 209.85.167.50 as permitted sender) smtp.mailfrom=zhi.wang.linux@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679397700; a=rsa-sha256; cv=none; b=Dr08hJH1T9kAZrLznmk8GxU0mwhB9qvw6tFSmLsS6Ay2D3T7DFsJcCLd8x+ugOQIeHaKKN 7T8xGShjizi3ET9N807/9qdNuHGsqQ6PG2gKegZmQz1k7Len75hRwloK+I0aDpM0ZQR87z AFOXghPHk9q+ok9x2UBqawzCC61OL1g= Received: by mail-lf1-f50.google.com with SMTP id y15so18628188lfa.7 for ; Tue, 21 Mar 2023 04:21:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679397699; x=1681989699; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=uoj6FCTyIPYbsFB5rJ42Dq7STG9j1TgfTfZlYEk8Sgk=; b=Jlq4oSD6AonPaeW/84Mh0G2R75J7skPB7leE2fkyeIQ3Z+LuE+DzxR2NHCq0cr72BJ fa8weee6OgtFNlZgnWeztPNBsknxKtAe8LA72glyHGDk1Kjtzkf0VI9wWaHzR/6HT81X wa7DtoRQEVBpF+PN9nc3c5hdnn94tRKUpYtkmAcwJpV9MinaSrg3rvl6jJSG/+OayG1e stXojfFbTfajHJEFwu39eJacf//zjBiwTIozAmJmxOQlaZSZ9l0+9/ylDeJBcDsHIBJU kSrMFxdSd2EQGfStequq70RCoV+zsORs64i9qDjtKioBqWQlatL4IbComMy07E2jQjlS slng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679397699; x=1681989699; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uoj6FCTyIPYbsFB5rJ42Dq7STG9j1TgfTfZlYEk8Sgk=; b=jFUvzzzYXAjS1xLBRXQTXWaOPbFmLLBOx37zJEkIZwK5NsIddIe914an10L4DQpidG Uqd2tOyTbqDtaXYePPWd4mQ8UT/A729Oa93Aj+sWth5Fk30d3GRY1ydcURzoRXrXGH5g rupAPbx5QTXSCrKOaoD5b5m1RveMnvel4XYKulYGsH417h8kZhfrR9536Ddz41/luszK bGxD5S19CvxkgarbOJxm0T+Iz3Y3l3MQcFKgELR2nrZtmLlc8I7w+BNFtQh+INSeVIuR 9QEIi74rE4QFqTx9uK1jQY0XemXia2i3iAh7vh3vvc7fFw6Oz0pLAnnunqX+K331hCFm vacQ== X-Gm-Message-State: AO0yUKXX8P+FAq3USzGwoKPQdw9NIF2ohHgJV72T/eBPgHwzTsd7Ygsc EuWncsNK6OyTfb5D7OlAT1g= X-Google-Smtp-Source: AK7set9bY/lyZSGlVklHq9mvTnu5/lAB25Bco255g2AVLzu76Lg82+AplHYe7EPwKFdh0BWGqavn+Q== X-Received: by 2002:a19:5502:0:b0:4e7:ed3c:68ec with SMTP id n2-20020a195502000000b004e7ed3c68ecmr561246lfe.3.1679397698595; Tue, 21 Mar 2023 04:21:38 -0700 (PDT) Received: from localhost (88-115-161-74.elisa-laajakaista.fi. [88.115.161.74]) by smtp.gmail.com with ESMTPSA id l12-20020a19c20c000000b004e9b42d778esm1217900lfc.26.2023.03.21.04.21.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Mar 2023 04:21:38 -0700 (PDT) Date: Tue, 21 Mar 2023 13:21:36 +0200 From: Zhi Wang To: Michael Roth Cc: Isaku Yamahata , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH RFC v8 02/56] KVM: x86: Add 'update_mem_attr' x86 op Message-ID: <20230321132136.00005234@gmail.com> In-Reply-To: <20230320180543.ly4jgu54hyamy2gl@amd.com> References: <20230220183847.59159-1-michael.roth@amd.com> <20230220183847.59159-3-michael.roth@amd.com> <20230318045611.GE408922@ls.amr.corp.intel.com> <20230320180543.ly4jgu54hyamy2gl@amd.com> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 721DB40011 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: hhte1qcoue8zy3dy3ubz6gb9ym185jh9 X-HE-Tag: 1679397700-843895 X-HE-Meta: U2FsdGVkX1/XqgxWrCxO76CO9/2gW9Z0mZUPFhNVa0XEquQ+3IyFzi3a+3Upirw/iwSb2ZLE3VmoJ9cn4umQtfarlu8TTtnn5QymKBdgSB9sGloAjG4qI/oIHQtLaInfzWAIhsx1LhxBgTb7UFoFbg+FhziKroXQeHEelwMcfanGFPevRTv82rBG1olbe6zzMoAABMpoJ8ZnRfEvHD9Q9txw1BnKuS7geNeRPvKPnfYze3f81r/Ow0WSGT9hsV179C9WVTaYCv+8m9YLYDcSnaM7stmP5NYuBVEXEgNmFHWLThi/zzDHuKYfojqjyk+XerDq0FsqBCpZSpY+Ffr5FRLR1dU3zg+eM0IrN7suv73ktrsLNccxPG0DhxUSaCV5sYcYAJIRERqIXULvyus4mfYeCUQvIBwSJj9KNTR9jic16be34evpkEDRc83/VGdZlj/NZCB1XoKWGrgNE4VdQF198C44SzoeEpJAkJYKzzkXikrVV6yfViJYEqyLP2dqbQP3fUbZnJp4vLI+S6HU2+ObQN9eW8VyLu9x7ZN32+fpoTPowMe9gr6nFl/kiYGgmtjbFEw+rELk8GY1FqA9pRmsP4Zce2I84PVs0M7GCnJBPo/VKk3ehHoxoHXt9XFNSDaUfclesgzemwPuN0uXol9S2iooT1uD63cK8xVBXHs7UcU8SuhmfKexjEiQFzAWUO19DNcOzH580Ug/IcRQUAxpiUEQjm3PnuN332G6UpBb5ycwjrAaeQxS0YLJXHPowhf/g+YDXIanl6ORcmT8c0yibqWy8LP5mtRlRPxVQ2IA7deuDThZ4BVUA51/THetefEmiId8TgO3KkntgBDYka7d5XlD/UMZGFnqv4uHwFuXZ28rT+fmWoS1aVwfftq1MnQRoX1zREp4V5a+9lnXAXrY5OwFlAM7HPpN8VR26WLqgkL2l8YMdzdj+eO77TozROdj2mHQWMXpsx/3sod hUwsmXVe Hc2ViBl7Z9MQf05aI5L4Ite+Yz1zAg+uDhhz5RntmVl1HAiqsAwNNLVjKiMoLmUiHFw4EMmOkDfRnT56lpqNx1cGnjyi+wPm20VznVApFq8e3KJeJMNfECaHMxXiCWI9YQEGLaFWGu93VgNJQODHp7BASEotXO3pZD5usaCs1L9dp+ovZQswoeFwnsS4nvNDT54maTRPefu0j0qEHeRcEZYLVdWfkv3kynq1jpjq3GK4pXcQTlSUHpSClrWQVXQnblX/0PdR3DEvovV4HG/GMsGDvvk5GXOpnAJT5kdcfJnxBOS+LKTaC0W0ScSP4gv+dr9Z+0h/qNxaFbphvupAZ9gQdpzKzdjIn33DMtIufFoywTpstF/+VbtIoI1PZr1QcdtCAfVlA4TOCES5R7O2PXVvtfJCLzPmJP5MHwm17N9L1mfIvVfgo/93BQaZPYKAIJtxGr51pqPhBLOMr/yW79/EGBvBYEGUbUiAkBu3LBde1Jryk/rmSfV+FKr/bhjsehsrcWM0RAyjWPMXVfjcdYDG3ytywK1QwdwADu4cdBd2u6nYS8k491E+8zgkKbtwyqpm1Skp2APWq3lJkOcCWisJvj/1r+6oyHYo90vemQDyW6A5Zu84TIk5LUwtJOFV/KDXGiMdnaB5HmrzzmIV9WNQlYZOvt1gUz1+DTOb+U2MqfoyIZi7jUY0SHGcGkpeIpWBVlU9N+/go00II3lIzIePGP4P2llgB7BJG X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 20 Mar 2023 13:05:43 -0500 Michael Roth wrote: > On Fri, Mar 17, 2023 at 09:56:11PM -0700, Isaku Yamahata wrote: > > On Mon, Feb 20, 2023 at 12:37:53PM -0600, > > Michael Roth wrote: > > > > > This callback will do any platform-specific handling needed for > > > converting pages between shared/private. > > > > > > Signed-off-by: Michael Roth > > > --- > > > arch/x86/include/asm/kvm-x86-ops.h | 1 + > > > arch/x86/include/asm/kvm_host.h | 2 ++ > > > arch/x86/kvm/mmu/mmu.c | 13 +++++++++++++ > > > include/linux/kvm_host.h | 4 ++++ > > > virt/kvm/kvm_main.c | 29 +++++++++++++++++++++++++++++ > > > 5 files changed, 49 insertions(+) > > > > > > diff --git a/arch/x86/include/asm/kvm-x86-ops.h b/arch/x86/include/asm/kvm-x86-ops.h > > > index 72183da010b8..a8aaf532c2ab 100644 > > > --- a/arch/x86/include/asm/kvm-x86-ops.h > > > +++ b/arch/x86/include/asm/kvm-x86-ops.h > > > @@ -132,6 +132,7 @@ KVM_X86_OP(complete_emulated_msr) > > > KVM_X86_OP(vcpu_deliver_sipi_vector) > > > KVM_X86_OP_OPTIONAL_RET0(vcpu_get_apicv_inhibit_reasons); > > > KVM_X86_OP_OPTIONAL_RET0(fault_is_private); > > > +KVM_X86_OP_OPTIONAL_RET0(update_mem_attr) > > > > > > #undef KVM_X86_OP > > > #undef KVM_X86_OP_OPTIONAL > > > diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h > > > index f856d689dda0..2da3fb2d5d1b 100644 > > > --- a/arch/x86/include/asm/kvm_host.h > > > +++ b/arch/x86/include/asm/kvm_host.h > > > @@ -1644,6 +1644,8 @@ struct kvm_x86_ops { > > > void (*load_mmu_pgd)(struct kvm_vcpu *vcpu, hpa_t root_hpa, > > > int root_level); > > > bool (*fault_is_private)(struct kvm *kvm, gpa_t gpa, u64 error_code, bool *private_fault); > > > + int (*update_mem_attr)(struct kvm_memory_slot *slot, unsigned int attr, > > > + gfn_t start, gfn_t end); > > > > > > bool (*has_wbinvd_exit)(void); > > > > > > diff --git a/arch/x86/kvm/mmu/mmu.c b/arch/x86/kvm/mmu/mmu.c > > > index fb3f34b7391c..053bd77bbf52 100644 > > > --- a/arch/x86/kvm/mmu/mmu.c > > > +++ b/arch/x86/kvm/mmu/mmu.c > > > @@ -7251,4 +7251,17 @@ void kvm_arch_set_memory_attributes(struct kvm *kvm, > > > linfo_update_mixed(gfn, slot, level, mixed); > > > } > > > } > > > + > > > +void kvm_arch_post_set_memory_attributes(struct kvm *kvm, > > > + struct kvm_memory_slot *slot, > > > + unsigned long attrs, > > > + gfn_t start, gfn_t end) > > > +{ > > > + int ret; > > > + > > > + ret = static_call(kvm_x86_update_mem_attr)(slot, attrs, start, end); > > > + if (ret) > > > + pr_warn_ratelimited("Failed to update GFN range 0x%llx-0x%llx with attributes 0x%lx. Ret: %d\n", > > > + start, end, attrs, ret); > > > +} > > > #endif > > > diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h > > > index fdc59479b3e2..d200b8f45583 100644 > > > --- a/include/linux/kvm_host.h > > > +++ b/include/linux/kvm_host.h > > > @@ -2330,6 +2330,10 @@ void kvm_arch_set_memory_attributes(struct kvm *kvm, > > > struct kvm_memory_slot *slot, > > > unsigned long attrs, > > > gfn_t start, gfn_t end); > > > +void kvm_arch_post_set_memory_attributes(struct kvm *kvm, > > > + struct kvm_memory_slot *slot, > > > + unsigned long attrs, > > > + gfn_t start, gfn_t end); > > > > > > static inline bool kvm_mem_is_private(struct kvm *kvm, gfn_t gfn) > > > { > > > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > > > index b68574ff6c30..8ec985f1c57d 100644 > > > --- a/virt/kvm/kvm_main.c > > > +++ b/virt/kvm/kvm_main.c > > > @@ -2561,6 +2561,32 @@ static void kvm_mem_attrs_changed(struct kvm *kvm, unsigned long attrs, > > > kvm_flush_remote_tlbs(kvm); > > > } > > > > > > +static void kvm_post_mem_attrs_changed(struct kvm *kvm, unsigned long attrs, > > > + gfn_t start_orig, gfn_t end_orig) > > > +{ > > > + struct kvm_memory_slot *slot; > > > + struct kvm_memslots *slots; > > > + struct kvm_memslot_iter iter; > > > + int i; > > > + > > > + for (i = 0; i < kvm_arch_nr_memslot_as_ids(kvm); i++) { > > > + slots = __kvm_memslots(kvm, i); > > > + > > > + kvm_for_each_memslot_in_gfn_range(&iter, slots, start_orig, end_orig) { > > > + gfn_t start, end; > > > + > > > + slot = iter.slot; > > > + start = max(start_orig, slot->base_gfn); > > > + end = min(end_orig, slot->base_gfn + slot->npages); > > > + > > > + if (start >= end) > > > + continue; > > > + > > > + kvm_arch_post_set_memory_attributes(kvm, slot, attrs, start, end); > > > + } > > > + } > > > +} > > > + > > > static int kvm_vm_ioctl_set_mem_attributes(struct kvm *kvm, > > > struct kvm_memory_attributes *attrs) > > > { > > > @@ -2602,6 +2628,9 @@ static int kvm_vm_ioctl_set_mem_attributes(struct kvm *kvm, > > > kvm_mmu_invalidate_end(kvm); > > > KVM_MMU_UNLOCK(kvm); > > > > > > + if (i > start) > > > + kvm_post_mem_attrs_changed(kvm, attrs->attributes, start, i); > > > + > > > > Doesn't kvm_arch_set_memory_attributes() work for you? i.e the following patch. > > The error check and pr_warn_ratelimited() can be pushed down into the callback. > > This is originally how I had but when CONFIG_PREEMPT_COUNT is set this > will generate warnings for this callback as well as the invalidation > callback as reported in v7 here: > > https://lore.kernel.org/lkml/Y80vhKwQyw8hS%2F22@notebook/ > > The main issue is that kvm_mem_attrs_changed() is called while holding > the KVM MMU lock, which disables preemption. But when updating > attributes for SNP, we also need to remove private pages from kernel > directmap, which involves acquiring a mutex which results in > "BUG: scheduling while atomic" warnings. > > So that's why we ended up somewhat duplicating some of the logic and > using a separate callback chain that happens out of KVM MMU lock. Let's split the things of changing memory attributes: 1) Update the memory attributes in the xa array (Both TDX and SNP) 2) Zapping the EPT/NPT mappings (Required by TDX) 3) Update RMP table (Required by SNP) 4) Update the directmap of kernel (SNP, but I guess TDX needs it as well) Does SNP really need to zap the NPT mappings when changing the memory attributes? (The new mappings will be created later in the fault). I don't find this requirement from APM. If yes, can we postpone the update of the RMP table in the later fault, like TDX? So that we can save this update_mem_attr x86 ops as things will be solved in the SNP-specific fault handler. If no, guess we need a x86 ops to tell if a zapping is required. Back to the lock, updating RMP table doesn't require a mutex. Taking the lock is required when updating the directmap. both TDX/SNP requires this update the directmap when changing memory attributes. Wouldn't it better to factor the touching directmap of kernel part out? Then you can call the x86 ops.update_mem_attr() in kvm_mem_attrs_changed(). And update the direct kernel mapping for both TDX/SNP in the kvm_post_mem_attrs_changed(). > > -Mike > > > > > From 7c618c1f3c236c382e64680efcbe7d8a672aa870 Mon Sep 17 00:00:00 2001 > > Message-Id: <7c618c1f3c236c382e64680efcbe7d8a672aa870.1679114841.git.isaku.yamahata@intel.com> > > In-Reply-To: <428a676face7a06a90e59dca1c32941c9b6ee001.1679114841.git.isaku.yamahata@intel.com> > > References: <428a676face7a06a90e59dca1c32941c9b6ee001.1679114841.git.isaku.yamahata@intel.com> > > From: Isaku Yamahata > > Date: Fri, 17 Mar 2023 12:00:09 -0700 > > Subject: [PATCH 4/4] KVM: x86: Add 'set_mem_attr' x86 op > > > > This callback will do any platform-specific handling needed for > > converting pages between shared/private. > > > > Originally-by: Michael Roth > > Signed-off-by: Isaku Yamahata > > --- > > arch/x86/include/asm/kvm-x86-ops.h | 1 + > > arch/x86/include/asm/kvm_host.h | 2 ++ > > arch/x86/kvm/mmu/mmu.c | 1 + > > 3 files changed, 4 insertions(+) > > > > diff --git a/arch/x86/include/asm/kvm-x86-ops.h b/arch/x86/include/asm/kvm-x86-ops.h > > index dc5f18ac0bd5..956db2ee25a5 100644 > > --- a/arch/x86/include/asm/kvm-x86-ops.h > > +++ b/arch/x86/include/asm/kvm-x86-ops.h > > @@ -100,6 +100,7 @@ KVM_X86_OP_OPTIONAL_RET0(set_identity_map_addr) > > KVM_X86_OP_OPTIONAL_RET0(get_mt_mask) > > KVM_X86_OP(load_mmu_pgd) > > KVM_X86_OP(fault_is_private) > > +KVM_X86_OP_OPTIONAL(set_mem_attr) > > KVM_X86_OP_OPTIONAL(link_private_spt) > > KVM_X86_OP_OPTIONAL(free_private_spt) > > KVM_X86_OP_OPTIONAL(split_private_spt) > > diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h > > index 0382d236fbf4..88e11dd3afde 100644 > > --- a/arch/x86/include/asm/kvm_host.h > > +++ b/arch/x86/include/asm/kvm_host.h > > @@ -1731,6 +1731,8 @@ struct kvm_x86_ops { > > void (*load_mmu_pgd)(struct kvm_vcpu *vcpu, hpa_t root_hpa, > > int root_level); > > bool (*fault_is_private)(struct kvm *kvm, gpa_t gpa, u64 error_code); > > + void (*set_mem_attr)(struct kvm *kvm, struct kvm_memory_slot *slot, > > + unsigned int attr, gfn_t start, gfn_t end); > > > > int (*link_private_spt)(struct kvm *kvm, gfn_t gfn, enum pg_level level, > > void *private_spt); > > diff --git a/arch/x86/kvm/mmu/mmu.c b/arch/x86/kvm/mmu/mmu.c > > index 0ec94c72895c..329333486e64 100644 > > --- a/arch/x86/kvm/mmu/mmu.c > > +++ b/arch/x86/kvm/mmu/mmu.c > > @@ -7908,6 +7908,7 @@ void kvm_arch_set_memory_attributes(struct kvm *kvm, > > gfn_t start, gfn_t end) > > { > > kvm_update_lpage_mixed_flag(kvm, slot, true, attrs, start, end); > > + static_call(kvm_x86_set_mem_attr)(kvm, slot, attrs, start, end); > > } > > > > void kvm_memory_attributes_create_memslot(struct kvm *kvm, > > -- > > 2.25.1 > > > > -- > > Isaku Yamahata