From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 953ACC77B60 for ; Wed, 29 Mar 2023 23:56:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0EE206B0072; Wed, 29 Mar 2023 19:56:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 077076B0078; Wed, 29 Mar 2023 19:56:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EB1FE6B0072; Wed, 29 Mar 2023 19:56:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id D65D76B0072 for ; Wed, 29 Mar 2023 19:56:21 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 7C3A640F42 for ; Wed, 29 Mar 2023 23:56:21 +0000 (UTC) X-FDA: 80623597362.07.02720AB Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf13.hostedemail.com (Postfix) with ESMTP id 9F78020008 for ; Wed, 29 Mar 2023 23:56:19 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=none; dmarc=none; spf=none (imf13.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680134179; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ynVtF+YOYIyQtBcdE/PIBgbLo/mO1vbRxbSD4nziyRU=; b=3mOPDKnp3rsewT1WtUjIZQtkZGmKOv6I84LE0sTnlinm5JblTadeZMnYzSLpe1jn9HQqP3 pRyGfOmlVL1YmOVvw3s2LlqSkEiJqgoNkupULEbtJ1W3ZytiC3Ez9IlUTwNz6PNxatSLJl wNgwXTm67/txErpwXwQtA9KUYQovpgs= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=none; dmarc=none; spf=none (imf13.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680134179; a=rsa-sha256; cv=none; b=2IMigAeUVlHJ2kOXmur01bYUjwmvHxzYWFHfwPydCMV9I018z0LqhJyAPZ9DVEhwmvncUZ wMCs0+0E6vF2GNhbx9W0dAEY35xBSkNrzi00kQY9ULanWDQ8yd4leosRtgmnsfZOVal+LR AaY7rbreuPC1ryJOUMa3w0Rt/XATpyE= Received: by verein.lst.de (Postfix, from userid 2407) id EB42C68C7B; Thu, 30 Mar 2023 01:56:15 +0200 (CEST) Date: Thu, 30 Mar 2023 01:56:15 +0200 From: Christoph Hellwig To: Andrew Morton Cc: Christoph Hellwig , Matthew Wilcox , Hugh Dickins , linux-afs@lists.infradead.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, cluster-devel@redhat.com, linux-mm@kvack.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-nilfs@vger.kernel.org Subject: Re: return an ERR_PTR from __filemap_get_folio v2 Message-ID: <20230329235615.GA2012@lst.de> References: <20230121065755.1140136-1-hch@lst.de> <20230328160433.4f3dc32b480239bce9e2f9ef@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230328160433.4f3dc32b480239bce9e2f9ef@linux-foundation.org> User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 9F78020008 X-Stat-Signature: uj8azpa9mu4zp6t1fgir8ts3bpc44byx X-HE-Tag: 1680134179-983825 X-HE-Meta: U2FsdGVkX18o9Z24wVLtX3dWKorM2x9Cm6AL2tbqFI5iKZBHLVv1ZUP/WeiMwRZadFhu9W2EVnp1J57IkZ0APMkYktgToQHPS97SVL7UhuElgcZP5wkVvOQmQtcGO0IR7+yOoSWIVCoR4/PU0lii8EEIOY1oHLYHTCQ4o8y/yiIrXj3iQs9meJQJOEcwJzj+3Wnrs4vwlplikCk8K3HdL7VKNEOnVWaJPIfnN9eSJePA4L8sI2WqgBGRls0PawGsX/SgR8EsbmcY4MuZR8k4Zc8vVpKrfE6EMoggA2V/xPaGhw0A/JoPl/ma9TI3STQgQz2WkL+z7XeARfXUZFlb6RxXwIjIC8PAXAVMge8qMjYsAU/jONCau7w/A8wPPFsBWI+Wd/f5mhzHW1U50WGThi3kQAmXJULGjG2lLpV+FKH857vwV74Q36Gwx6z6cJsnB7VHnrDbxQ2oeoRLcd+bPvgybbGCKcDeKNee5DHIVwkfMqfhijj4pMsYX6tGx4f85ssaHJuI53zFqMR2Fmv4r5nE93/toDeMxx91On29D/frqXBjNe+WdUYruYGlXwyufK9bMuJ8XWeyrgQ8XVXWdshRoNz+h0BijQEi41iAAke3WW+0xKJpyYqevF3/ALVXIoeHW5fP+N+1lrdU/DfBeECo8yxxtfkFIWwZktgVxCr0EeiHysX4jjd1sQZ8x0vmxoXNfjZhaAfjFuj1vQk9/vLIUc7t5d8kqNqEczI0UCYbBl2zDuYYhoztLPcO7WlrDzmJMnghnlDuuV83g3eBM+BLzzo4D2pfdDHojx5WcSoOiBw3lOy72gljpVmKpRORoyKU3xKWvCSUDTmIAG8kbPKBSQQoaD212nKaLn+IHnmDWvQ2MYIFMPQgY1ZqjR2CUl2paXMg8J0GzNG4E1kSvvj762x8JDYN4H2Cs8ipqRj9guKb0Gku0nBWHOnKkbek9fQqxxpwbwia8FMyIxC qeZSs26K 1/W4afuxLpKO4JDMXnE7J0Q/J6uhFClFHyTAjFIzz7rwlFQArRGuyk/+KtVKc8oHectHtqdnm/9HOadzbnd87/Y94bzwLtZuqls66BL5ndMB6GZRg8uNGNdI8LA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Mar 28, 2023 at 04:04:33PM -0700, Andrew Morton wrote: > > Note that the shmem patches in here are non-trivial and need some > > careful review and testing. > > How are we going with the review and testing. I assume that > we're now OK on the runtime testing front, but do you feel that > review has been adequate? Yes, I think we're fine, mostly due to Hugh. I'm a little sad about the simplification / descoping from him, but at least we get the main objective done. Maybe at some point we can do another pass at cleaning up the shmem page finding/reading mess.