From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FD42C76196 for ; Tue, 4 Apr 2023 02:11:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CE08C6B0074; Mon, 3 Apr 2023 22:11:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C90B2900003; Mon, 3 Apr 2023 22:11:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B3181900002; Mon, 3 Apr 2023 22:11:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id A4F806B0074 for ; Mon, 3 Apr 2023 22:11:47 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 785771C6023 for ; Tue, 4 Apr 2023 02:11:47 +0000 (UTC) X-FDA: 80642082654.11.61739A6 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) by imf27.hostedemail.com (Postfix) with ESMTP id A743B40007 for ; Tue, 4 Apr 2023 02:11:45 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=V0ZDkZK6; spf=pass (imf27.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.216.50 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680574305; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YmzxGemT5yHNlzf3st/lwgXJFDKKSFWcvdc6KEpYYJ4=; b=ulo56jvVpyJ/aY0TXqaX/tE6kdClR1MY1sjZIQXPVgyHI9/A8cST2lolNHnGcyfLzhpRwT jzWmRVrcvpmd/eA3aZli5BUU7VeLPMlFhgIpta8aZcKWnqYHJ24iazLLi1TvyXHxIajxE7 PUQij28nzbchhZBiMe21OrM9/Sejx1k= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=V0ZDkZK6; spf=pass (imf27.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.216.50 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680574305; a=rsa-sha256; cv=none; b=Q7xEIt2OYXh9r92f4zkcidB8A5ooKKUI3QyW47vkUoKJpS7E9gagEV7nWStTyd242o4hx1 D/YwwSj85/0oREujg9t1kehM6ZQ19dM+HHI+NNGqtSKOrhm4+3gKY86RRVYnrVaAL2H1Ku 7/7tk5zCTDWKOkMmmNJGjexEszNKKLQ= Received: by mail-pj1-f50.google.com with SMTP id q102so29057088pjq.3 for ; Mon, 03 Apr 2023 19:11:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1680574304; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=YmzxGemT5yHNlzf3st/lwgXJFDKKSFWcvdc6KEpYYJ4=; b=V0ZDkZK6qkr8h3KAauZlWp7KFDESNfIjcyxhIq1JLIouJHzWikxT4G2euuZIBZhQ5y QS0AoK2vrCukzOatFLNLkICdyju15qXoWAKo6IeqgnI5KH3NIPRy025cIM9qNLkI2gRt 83cer81VuvXKwPHssdCfbpLpCZ+1iFmK2wAxQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680574304; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=YmzxGemT5yHNlzf3st/lwgXJFDKKSFWcvdc6KEpYYJ4=; b=UPOnplP1XrSTyBGeBp0rP4fdQ7Mr9i8jUv2AWq/LQ1DQCWHD7Mix+kWQOeCF0IDpQ7 HiXm07Zvo4PIT7RUM1b2xpcKO1cWzH8zGWE+dMbLbsZEuGRAKoP3rJmvY0N0iMzXhgks l4BEtxHnQa26VL3N12FH95EQPXM5GICmxlBAFpeuyzRVyqrZsiJklKo4awpb1NwSfJRz 0bJftDFRzqpieKKk/L8HovFr7jiTTkp/6Z12bPGsr1wSDEooyzgE8eoUTkJ4+/WNQkHc HDNxip8RA9QaaBwPxhQxJSVEKjOPOE3NWhV9t8B12b2x5l12aeeUS8w7uOoxM9ve4wRD E5EQ== X-Gm-Message-State: AAQBX9fs9N44FFKqrhD9QWxBZSm13glw4mQo1F2eMpF+Zrr39UCDR3bn SP/8BqTXnMdVWeLUvkuQ6Acwpg== X-Google-Smtp-Source: AKy350YX7VuJTSNsSEfhM6Ewte3fLN0L33kqHj3tPWHeXZGadovXjastqBVyInDAK86QY13mVUw4Vw== X-Received: by 2002:a17:903:228b:b0:19e:6cb9:4c8f with SMTP id b11-20020a170903228b00b0019e6cb94c8fmr1206171plh.41.1680574304469; Mon, 03 Apr 2023 19:11:44 -0700 (PDT) Received: from google.com (KD124209188001.ppp-bb.dion.ne.jp. [124.209.188.1]) by smtp.gmail.com with ESMTPSA id u4-20020a170902bf4400b0019f39e4f120sm7265326pls.18.2023.04.03.19.11.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Apr 2023 19:11:43 -0700 (PDT) Date: Tue, 4 Apr 2023 11:11:38 +0900 From: Sergey Senozhatsky To: Tetsuo Handa Cc: Petr Mladek , Michal Hocko , Patrick Daly , Mel Gorman , David Hildenbrand , Andrew Morton , Sergey Senozhatsky , Steven Rostedt , John Ogness , syzkaller-bugs@googlegroups.com, Ilpo =?iso-8859-1?Q?J=E4rvinen?= , syzbot , linux-mm Subject: Re: [PATCH] mm/page_alloc: fix potential deadlock on zonelist_update_seq seqlock Message-ID: <20230404021138.GH12892@google.com> References: <000000000000b21f0a05e9ec310d@google.com> <78ff6e70-e986-1fcb-eafb-3edd5f2bceae@I-love.SAKURA.ne.jp> <6266b161-e4c3-7d65-6590-da6cc04d93ec@I-love.SAKURA.ne.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6266b161-e4c3-7d65-6590-da6cc04d93ec@I-love.SAKURA.ne.jp> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: A743B40007 X-Rspam-User: X-Stat-Signature: 1g1c3ooo1t7w3wtsosrpkcpag7bc1fgf X-HE-Tag: 1680574305-934828 X-HE-Meta: U2FsdGVkX1+hrV6snzQeCb9hW1u2XHgblLXGV3pn5jxf21E6tlzE0Jd7LPhnii31s7ovuHUNC8+0eYAyiJvgYhydtoEDbV9SNVhwWjP/NZ38pA6dmDnSZ6GeyPi9TdPya166DQa+1jFyyZEYnHpNtBmVOItnE1+NPdg4cpVDyFNau7QmgGUXGiYG/OqPZ6hiswHDcVkK3uvWxMKc3HNW0i9MEmVfZJkKccehiY8c9NhhCT9r/KbrP5+inp/YyR34AtXp0+LMlLdU6k7KQ4BQqTejRKL0oZdiMhpsGvFqZj0SRXC4hfMS43B08zGyedhVzuh4jlveo8Yds7vXJRQkLNiUkFCCmY1o27O8Zv2V+2RsgcFYBWEfr/R7QvOyhokJWxETz+qO91GDJV5DBorWflWw9TWNLvAx8xl6HRA844I3hblIximEjpMdVks8lakpLYzkNLsIv+Z3CWFnX9Fl7tXgSZUmxwje2N1+7NcP0hOw3L/ZUruYkC/NvuojQZ3JvhIjgnMBHAtWeJwk69VcF5oi+wfYxEYWQxPPa3fGQQzMDBO1iFl7M8+jElqo4BEcUUr+VFwZoZ0icSf7jJDo9FuUSpSet9p34v1JtL/OYYkVyZa1TV7AoWRR1CtNHQUb8l4cF/XztTb+4b2RvKf8rQsdNyLCt/3U3T9rimnTlxjf8JwEQhC8ei7tGXAXIuz7On/bP/TEUbDXdWdJNaFILDHfWviupwPjE/4wl/LnDOMkn3w2Ks8JKgAPxtwm6U80x5PGsNE/uzRrkvP+SuoQr7A1K/xEqCqxvqA5/5Wg4cANgxn/pV9PrgN1lJxxFIEFSRPGi+Atb1AnaZTmcXrd789lCNjDAMY6L9KryY7gQ7WW7+nKR3KblDx8oHQzCk+hUwj84R6TNX2YKerk5XVXFy4bznwVYHVRbdfbxootsZFlwId/KBjpmQD3D8Ygn8Es90tTd3bEwM/xJM0sV2I PxN+1UNg lgxSw1LiFDYhDecDpocjwBJy2wu8jB4nmzmMRyszcqFDlgXnd9oDjaOu4j9XkeSCKH1PAoRbckOZtIfgChvWL8/C7UIcxdcaJLdbL6yFE6PcdoOO/gtsKYsWZWHbMgidddd14Iu5rVbPOuHRVibzI/rLF4yUNzATsIkUfziSrD5CEvCr+Eve5F+w5ZhBZ3R02Zw5Ob6ZOuf5nUfpJWXG31Yr5CRe8Sjy3VQPC5XCt2DGysd+FcSXHPztUz6tyyHN9+ht8+dkBx4ZTF3j0I8J7AUee6y3oyX7/ZYxC2zsSdespYB075lY1W9B5cNoolJdXrXYfE0d7DnhUwZPSpPC7Ce8C5Ermq0fBOykWvFul273xvV9W2KetgyzbKKgaBL/HvpSi+ExuJkrN9Qia0ZM+gTrfXM/4RdhsdVNncgbH3Fx+JZndrCBd4eMevWd8VLcbaYnypi+ONzRsxD05/ed1VQoOaRDSub/s6tXnrRWVCUOzm2ClZtJRe/1hBUy+PvFYTXJ0SUzMBr5zcOlInr0xG+O4NnBe6U4gl183MSyYXHIAxllLfSYIc4PsGnFumxLMtI9gouno9kiAnZ8B8p2PRMtOCBzyPMlH+DznYhDwZJwCjtl3/jCMa6kWdIS9KmQH6b6raXiuc3WNEX4VlvxDiF62q/KdfjnZurSF/E07W7f4dA45f/jqDJw3Qnu9+7RBlFW/+sEfG2LbuB3V4++W93DHojr3zRItp19gqxTm0znUQBxwN2q2roCiYUEze/CscYpee9AoRRpWnkI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (23/04/04 09:37), Tetsuo Handa wrote: > syzbot is reporting circular locking dependency which involves > zonelist_update_seq seqlock [1], for this lock is checked by memory > allocation requests which do not need to be retried. > > We somehow need to prevent __alloc_pages_slowpath() from checking > this lock. Since Petr Mladek thinks that __build_all_zonelists() can > become a candidate for deferring printk() [2], let's make sure that > current CPU/thread won't reach __alloc_pages_slowpath() while this lock > is in use. > > Reported-by: syzbot > Link: https://syzkaller.appspot.com/bug?extid=223c7461c58c58a4cb10 [1] > Fixes: 3d36424b3b58 ("mm/page_alloc: fix race condition between build_all_zonelists and page allocation") > Link: https://lkml.kernel.org/r/ZCrs+1cDqPWTDFNM@alley [2] > Signed-off-by: Tetsuo Handa > Cc: Michal Hocko > Cc: Petr Mladek Yeah that looks like one of those printk_deferred() cases. FWIW Reviewed-by: Sergey Senozhatsky