From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75A3DC7618E for ; Fri, 21 Apr 2023 10:46:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D3B6B6B0071; Fri, 21 Apr 2023 06:46:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CC6616B0072; Fri, 21 Apr 2023 06:46:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B661A6B0074; Fri, 21 Apr 2023 06:46:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id A35656B0071 for ; Fri, 21 Apr 2023 06:46:30 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 6274A40679 for ; Fri, 21 Apr 2023 10:46:30 +0000 (UTC) X-FDA: 80705069340.08.D8F3F4D Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by imf01.hostedemail.com (Postfix) with ESMTP id 7CDC040010 for ; Fri, 21 Apr 2023 10:46:28 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=Jjamna4s; spf=pass (imf01.hostedemail.com: domain of boris.brezillon@collabora.com designates 46.235.227.172 as permitted sender) smtp.mailfrom=boris.brezillon@collabora.com; dmarc=pass (policy=quarantine) header.from=collabora.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682073988; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Bc4Der2ehNqaIJ2g+TKUYB2T4B7S+I0WJDz2krYoM9s=; b=bI5wKxBWLuHQuztwEASVb9MUgx9lD7Q/OPn6khgvLs0JAcoi18Y33LgG416xfvkZsPTkdE a294VeuBB0Ce3ym8Eof5PyGj8XwCfEN893Zkxki36S1+Y2nEsJ9XCgf/6ReK74dRVxTfIn h/SzEp5McuOCbqNHv4XdyRI9gYSd1kc= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=Jjamna4s; spf=pass (imf01.hostedemail.com: domain of boris.brezillon@collabora.com designates 46.235.227.172 as permitted sender) smtp.mailfrom=boris.brezillon@collabora.com; dmarc=pass (policy=quarantine) header.from=collabora.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682073988; a=rsa-sha256; cv=none; b=rQOi5VfKyuAdKTsDnPH7HXsba40TDRq0GYY8Wp30v+gN1ynQyTr2DN9vM0jmdlCfUSxGHf 6R0Um/w2gjI7/40uzQ6vPERCO3eq+OdyJDIszyNEkBSoxGuGcm5+XFfEkQXLfBptjUiYlP XV+eaKjknpDVFQ2R81yA6WxtnOMf6fY= Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bbrezillon) by madras.collabora.co.uk (Postfix) with ESMTPSA id 11EA96602040; Fri, 21 Apr 2023 11:46:26 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1682073986; bh=xy1oqjU5V/MfMlLIxJBwQthAmE3+07DxTdM+2r5CRK4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Jjamna4sOjLQkH1nkuIHUE36adS3B1KZwwMxTmygRn+u3/pxkEYo1F5PkmJVw4239 wJ2unj8E4sgzv5F/dTBIm4We4BM1YRFVftcf1/unkDQWK2Gd8rlwkOk9isIcl8ZU4K u3XVV6sZQ+x6LNMVcVXbvfWEV7n0cWBzE/lFdNDolnKXKo1R0RgZY1KEKNYJjymDZe 1pjNjYuBEHtQJtRZME2qyikHAFFiWNiovamiotKiNxWQ1hFWpN/6yOaGatSU0+IjMt oBZ1VO0ap3BM0VFBCdynQBNuj87otIdpOiix9tBW/8hGrk0GbKGltZP8Kp2AIPgw2M F57uTnKdV+DXQ== Date: Fri, 21 Apr 2023 12:46:22 +0200 From: Boris Brezillon To: Danilo Krummrich Cc: airlied@gmail.com, daniel@ffwll.ch, tzimmermann@suse.de, mripard@kernel.org, corbet@lwn.net, christian.koenig@amd.com, bskeggs@redhat.com, Liam.Howlett@oracle.com, matthew.brost@intel.com, alexdeucher@gmail.com, ogabbay@kernel.org, bagasdotme@gmail.com, willy@infradead.org, jason@jlekstrand.net, dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Dave Airlie , donald.robson@imgtec.com Subject: Re: [PATCH drm-next v3 04/15] drm: manager to keep track of GPUs VA mappings Message-ID: <20230421124622.6386cd60@collabora.com> In-Reply-To: <20230404012741.116502-5-dakr@redhat.com> References: <20230404012741.116502-1-dakr@redhat.com> <20230404012741.116502-5-dakr@redhat.com> Organization: Collabora X-Mailer: Claws Mail 4.1.1 (GTK 3.24.36; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 7CDC040010 X-Stat-Signature: oa7eahcoayhhzjzt85ayhwi8hkuwhcqn X-HE-Tag: 1682073988-742743 X-HE-Meta: U2FsdGVkX1+FPHsSLz6scCyN72JFqNit7Z1R7ZHbivHBflgOS8N0tv3cz+vQowOo732yCtwgOH67R4a5sew916ILk/5jreMVl2hyxKoAeYFCOU634fUC5dwYssxo3OuXRI9W1PY7n4EXUQ+yy7ScPK11yHgPD4yjr0hX2CVtxluRSsCpZSI/49OZr1aKPY+sr5ZL0JK8x5Vzd2g76acxEj4ddK0r9T61QuSfokFrMop7bCt1l3FKFznK+dDomVAayO+kJrEsu5vGUkxYrd/l3cy1eR+l5anzo5bujknFfevNQIRoe8KOb57nul6TxFwxt4xBbQV94meyldkWVVZp/bO5GLwUd4EfjybEQ/c/dMxh9A43qgsjEU+hShuwEVgUUpqsKk1172sI3V0KeSp88yMJ4yER+i+br53gOvYUMd1sE9QeYoaloX2Gc0w1JZS2pocuIJ2J8eW6n1qwitMIZ9vLmyYQLc5g365v1WfdPwUQ81SUeH2w1N1mv9aR96hM60NOP4l65KTj8+0dPGQu/Yq5kRmOEzZVCiIeR6Z1+B53GVq1ccRFNdpXbwEUMTTuN1TFutR0jdydL7CB6r05VGu1obxasnK6UbZa3OXBtW5aK4/xk78liA3hDBqgQx6jVVXVkC5eoO4z9k4Z1PhYFpJG73SoQOrGW+mxexNB/Hc27cgxNyjFzVQ6o37ViLUatgmzqX2Sr7+8CxMRufYKwS1GIa472s92k5hpDzFr0nVmzPnkfMLM+9cjkSKhcKJHEqCDFqM9c+lwzp6UEo7zNs/0WOI/Uj5ptmWOcXn4mMAlmnYVnkPikJ4zSt1GTAXdtMSxdQQ5+poWGfkj07/SCUUbTRVHbPvzI+XAZ6U3AGsvF+G/a9fTxPe79WRqAuigVUO5ljM0UonoRLqHetYVbTkmUA6BfwRLnJz1S4fcT7tVt0MCttL0hITPEQF9W2b3RG7YmcYYpf9kSdUY42c c62dcONR VFstIpqwb9rAD+SpNvCh3Z8ajhO/11AGQqUSKlfoKCyN/ki/97bpusGjquTUDaMEOFvJV1HiN3zyO5HfIe+QmTyr9KQY6mtYDpFjYuz0NB3UTw9a8pWp7177ZnNm5JmL24pO6OdrbBjNiDHbVc8PByLNFDD1CVHp1UtViuoMJuxdX2yBUaM4w1pNhemWAJ/hf3KBahfJ3pRigPc1GzhNX+/NP8YbnklDRzybImPMOxWZrFc8TEPNcbiR8lV5u33TicQNpY84xsYB2ZfOIU1MJJJibCvCoavsnyCS9 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 4 Apr 2023 03:27:30 +0200 Danilo Krummrich wrote: > +/** > + * drm_gpuva_prealloc_create - creates a preallocated node to store a > + * &drm_gpuva entry. > + * > + * Returns: the &drm_gpuva_prealloc object on success, NULL on failure > + */ > +struct drm_gpuva_prealloc * > +drm_gpuva_prealloc_create(void) > +{ > + struct drm_gpuva_prealloc *pa; > + > + pa = kzalloc(sizeof(*pa), GFP_KERNEL); > + if (!pa) > + return NULL; > + > + if (mas_preallocate(&pa->mas, GFP_KERNEL)) { mas_preallocate() needs a valid tree field to calculate the number of nodes to pre-allocate. I guess we're missing a MA_STATE_INIT() here, and we need to pass a gpuva_mgr object to this helper. > + kfree(pa); > + return NULL; > + } > + > + return pa; > +} > +EXPORT_SYMBOL(drm_gpuva_prealloc_create);