From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC714C77B75 for ; Fri, 21 Apr 2023 12:54:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 51B1C6B0071; Fri, 21 Apr 2023 08:54:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4CB5D6B0072; Fri, 21 Apr 2023 08:54:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3B9FD6B0074; Fri, 21 Apr 2023 08:54:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 2C9F26B0071 for ; Fri, 21 Apr 2023 08:54:59 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id F0C3540155 for ; Fri, 21 Apr 2023 12:54:58 +0000 (UTC) X-FDA: 80705393076.21.22F0303 Received: from outbound-smtp37.blacknight.com (outbound-smtp37.blacknight.com [46.22.139.220]) by imf20.hostedemail.com (Postfix) with ESMTP id B077B1C000F for ; Fri, 21 Apr 2023 12:54:56 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf20.hostedemail.com: domain of mgorman@techsingularity.net designates 46.22.139.220 as permitted sender) smtp.mailfrom=mgorman@techsingularity.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682081697; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=If/X/eDbRrxNL+qc+fIPwEuxcgUldPaVFAl+JFs/Ihc=; b=X4CsrrDOb9IlBdLcCHOOlydu1OuYdw6c+ZyeU/3PDZjxfwfoTWSYqajP6mgPweOYhVLYyQ sGT1aD5wtx6F7Nx+2o9Lb380yhYx4OyF0FTAIanoReAd49xE+RN5+wrknL/hTAUBi57G4b 5sxHR7HtgtPJVhn9lyMPeNnZAq9Ugss= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf20.hostedemail.com: domain of mgorman@techsingularity.net designates 46.22.139.220 as permitted sender) smtp.mailfrom=mgorman@techsingularity.net ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682081697; a=rsa-sha256; cv=none; b=ZPCtV/hdTI6MqBXaRe1k5QemHZ6N/6iO/gpi6GBZKzx3AGUXTmGQcKIFdGpGbKr1ev2hEE TmCBOYcTxJ8eFuY34k/CfBv4CRyDSk1zsFFIgm85P3xkixnPcjpLqGCjhxef4SvVDCnUQW qPy9NC7Pz+rsntmvPyyHSit8oPgoUPo= Received: from mail.blacknight.com (pemlinmail03.blacknight.ie [81.17.254.16]) by outbound-smtp37.blacknight.com (Postfix) with ESMTPS id 21FDB1FC6 for ; Fri, 21 Apr 2023 13:54:55 +0100 (IST) Received: (qmail 6123 invoked from network); 21 Apr 2023 12:54:55 -0000 Received: from unknown (HELO techsingularity.net) (mgorman@techsingularity.net@[84.203.21.103]) by 81.17.254.9 with ESMTPSA (AES256-SHA encrypted, authenticated); 21 Apr 2023 12:54:54 -0000 Date: Fri, 21 Apr 2023 13:54:53 +0100 From: Mel Gorman To: Johannes Weiner Cc: linux-mm@kvack.org, Kaiyang Zhao , Vlastimil Babka , David Rientjes , linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [RFC PATCH 06/26] mm: page_alloc: consolidate free page accounting Message-ID: <20230421125453.np6b5hirktkj6ji5@techsingularity.net> References: <20230418191313.268131-1-hannes@cmpxchg.org> <20230418191313.268131-7-hannes@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20230418191313.268131-7-hannes@cmpxchg.org> X-Rspamd-Queue-Id: B077B1C000F X-Stat-Signature: 4xuywek9y9n5gc88sp8cnbqjj5juyz9h X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1682081696-147199 X-HE-Meta: U2FsdGVkX1/DYltoBDCMet+bMTsgEyvizE6dkY/98YuhXV7PBtY67RHHvWShU5RL+qAQ75ZRkLr7VBMlMd/Mr+0KNIrwZwC3PF07yWQEYCXR7ZcYvodcBInZ/VEJACjOz1Ag1CvuLs1LdQXq0KjsgIrvon+ooY+avwSxfINR285UeAG2vyulfQNUnbcKhUxrk3XiCQMwjlIelCPPzX3H73H4y+4duE+wL5Xxi4N8E2csQpcR/9wSMq6r2W8m31WzOIYgTAc8ZgUsTfvmA5X8t5onBrZKsleiFF8L69sYhFmq/vTTyBpmV/ApXxhc9qqs3HTYqK5atKC1LJq8iITwU0gA44CrhCcW6Rb1GY+2eJe5ai42FHLfv9FxEtwTrgAFv08+Sr8AOuBohFD1g21hWp8JuRuKP1oukdSX5xQtcBsG689KWp/8Sa4B2Qa15ng7jMWgtlq+PIxCYdisOmGtJrWdSqVc1yB/riisv7hqGR0aRX/JuzHB4etxHIdW+z8jkDfanUCgZxenxuq2+kwtW3QqB50XG9FMsXTOzeCepkXmsb2m4f3VAp7kGz1mj4JxWZ8/q8MM3vCQlSpgFY5/+bJaVswNIDJuXv39N/y+VY07vPfQy4FYXQhKZm4yJA2VFLQpA341fq2JtFeTMKAyso4WUeiWtMAzk+5qjcn1PijjUQL3Uzh8sRkvUCTH/kupCaeKnxViF8FmnFhFK25L7kLECWnTmWIP1nohUZzKCkWJMmaiNDyOisHiaymPdeiDIvTrixKJTjDSbJWaqI3fXOMXxbBc5+RjbdZAuuWKtPgx2AeNCu9t2FEY0X87aG+ilZNZ7hc5let3kqKzAJ+ye3LNwvwqyB/NYoQKXXjNJEAZYj80YY+WeaAb6Qizt/1QU+wrsjZCPs2Po13bWc0QRMk+26kizlpaGWdRCU17qIy3EoXMzBjGq/h8RfI/B3AtVITDXTG9HeXwBnFvjEt divQ9Ofb Yi0Qz1zgCG4A7axEdbaeMj/3bGky0BoAnbRUowTqZsBrt+a/+b8yl5bPJFSXp/NtV1plgFczt7x3ujGBjK4Wmry3EK8RLODc/OMs0H5J2xDp8+yATY7KLZvw5S00LnLPrZvOLa0Cg7Gy6dzWaiApQKj1aA2Rbn+bFFdzCX6lqPxiAzqGlbHEHt2b83yYbidp6CsQKbO32oyD2RsfiVczjFTkZM/+gtcSMsQni/yM7wlWiBsFu6hlJBIMpnCTBTbMG3vHfHh8izDfDUqr+2fgLe1+gBA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Apr 18, 2023 at 03:12:53PM -0400, Johannes Weiner wrote: > Free page accounting currently happens a bit too high up the call > stack, where it has to deal with guard pages, compaction capturing, > block stealing and even page isolation. This is subtle and fragile, > and makes it difficult to hack on the code. > > Push the accounting down to where pages enter and leave the physical > freelists, where all these higher-level exceptions are of no concern. > > Signed-off-by: Johannes Weiner I didn't look too closely at this one as I'm scanning through to see how the overall series works and this is mostly a mechanical patch. However, it definitely breaks build > @@ -843,7 +843,7 @@ static int __init debug_guardpage_minorder_setup(char *buf) > early_param("debug_guardpage_minorder", debug_guardpage_minorder_setup); > > static inline bool set_page_guard(struct zone *zone, struct page *page, > - unsigned int order, int migratetype) > + unsigned int order > { > if (!debug_guardpage_enabled()) > return false; Here -- Mel Gorman SUSE Labs