From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 351D1C7618E for ; Tue, 25 Apr 2023 02:16:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9AA016B0071; Mon, 24 Apr 2023 22:16:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 959846B0074; Mon, 24 Apr 2023 22:16:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8486F6B0075; Mon, 24 Apr 2023 22:16:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 7137C6B0071 for ; Mon, 24 Apr 2023 22:16:02 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 328621C6941 for ; Tue, 25 Apr 2023 02:16:02 +0000 (UTC) X-FDA: 80718298164.09.3416707 Received: from mail-qt1-f181.google.com (mail-qt1-f181.google.com [209.85.160.181]) by imf25.hostedemail.com (Postfix) with ESMTP id 6E6DEA001B for ; Tue, 25 Apr 2023 02:16:00 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=cmpxchg-org.20221208.gappssmtp.com header.s=20221208 header.b=m2OuU8z6; spf=pass (imf25.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.160.181 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682388960; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3CUi8Pu2aq3PZJRR6Wmf7E6lNE8E6L2aFBDpceT4KFs=; b=JT4mbPwqO9M7k01kaLcY6a7+04B/YmboLIGLxJ6/Fd40nwyqY+vhQjbBdL/OkdwGPaeC0m Z5dyCSuHHhlQXS1NIWQftFL89IRBbm0BOSAQ0mlK7InzD1WHdzFo0anwcbRb6KSIxzQknt B/pXhvDi+WJ3Wc422DjHcM04or3P2YU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682388960; a=rsa-sha256; cv=none; b=EaLQLtG8RrEwKGcWQWEfqsVchune44fWuwddTjCobyA4pSfoglmHClB+YNp9zZnXaztXWt m7F40K0Wa09vEkGtF6Wqo+NnsdPXyy9OKSi01FpU9f5fXjg2l40joGA8DrqcCh9siQbATc ndEyTPlUpZi/6JVw2vm1xnjaVyEvdZk= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=cmpxchg-org.20221208.gappssmtp.com header.s=20221208 header.b=m2OuU8z6; spf=pass (imf25.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.160.181 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org Received: by mail-qt1-f181.google.com with SMTP id d75a77b69052e-3ef3ce7085bso22298621cf.2 for ; Mon, 24 Apr 2023 19:16:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20221208.gappssmtp.com; s=20221208; t=1682388959; x=1684980959; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=3CUi8Pu2aq3PZJRR6Wmf7E6lNE8E6L2aFBDpceT4KFs=; b=m2OuU8z6lXuImyl6itdLMAK9t4leD5YS4aq2+/YRI09MklwI98oBG9WDJoN/meMbNB eXdMPeb70Hyf0Kus4sor21h3pwJdOI4uU/xQbuydlx4t4C9pCoOidXyfSrODYtWhSz4x I3ZyMIZQezTs4wqX8+fHlJKKAMmciZ4FOW7A3GCT5e+N7pML/L56xxy/Qc6oM76Wh7zQ POYWwVViWSYTJig7BlcY8Gtji4T3hG3BeIPajyITtxA2ZKt0Neg+3cGXqlXGHnleM7gG USp3aD4UYLhUYIXvCX/cD+ys/zRWcsqM+r0HzK1Gkgb65TOzlcgKqSjWLoe/Lk5Gm8kM 27og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682388959; x=1684980959; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3CUi8Pu2aq3PZJRR6Wmf7E6lNE8E6L2aFBDpceT4KFs=; b=VENxcEMXhiSkF3vVyaIWD2y7Cgm5oGDR4TjmqgJNkDO9+u1q287uIcgwhaEoFro1FB ObJRC3kt4ch+CrYQh7yT+ozm24MT/KxuvkrukAtaf0U1zJ8tUCZjTRfNvCSk72IHMvfo XZWDPCoZzsc4Q5j+K34m6vT9SGoIWCOlrLMydyxOljofyZZ8lxC527ImMYLyDiZrWIkr nNH+N8K1CtAtAqI5Xedf8KVLngXIKlqqQVlXTL+6gdXnY1QQQefpHF7ImdQzkUomzeDK jOtr2HryoU5ZND+OS8aA0rlBKQ9bRKfY8SOwLgug3wc3COvynaHH0/NhWIduWLgQMwQz tNBA== X-Gm-Message-State: AAQBX9dAT1L3hLd/W3PgEy/3RVt0q8zor4FsB/COHMDS3TcoHnZINQYL SotIQpFTqbJmrwIdPAtQOYWNAGJWKImt6gLNMc8= X-Google-Smtp-Source: AKy350Y1l9vZ8aSitNTEyliRuPSOSXC2TggqdvnlTDYsZZz27IVvS/tI6xxrM7Cr/jakm2DIBOzbMQ== X-Received: by 2002:ac8:5c46:0:b0:3ef:58f5:9ff7 with SMTP id j6-20020ac85c46000000b003ef58f59ff7mr25700800qtj.53.1682388959560; Mon, 24 Apr 2023 19:15:59 -0700 (PDT) Received: from localhost ([2620:10d:c091:400::5:9fc5]) by smtp.gmail.com with ESMTPSA id v17-20020a05620a091100b0074e003c55f0sm3993712qkv.102.2023.04.24.19.15.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Apr 2023 19:15:59 -0700 (PDT) Date: Mon, 24 Apr 2023 22:15:58 -0400 From: Johannes Weiner To: Mel Gorman Cc: linux-mm@kvack.org, Kaiyang Zhao , Vlastimil Babka , David Rientjes , linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [RFC PATCH 14/26] mm: compaction: simplify should_compact_retry() Message-ID: <20230425021558.GB5666@cmpxchg.org> References: <20230418191313.268131-1-hannes@cmpxchg.org> <20230418191313.268131-15-hannes@cmpxchg.org> <20230421143654.g6ta3kd6ea7fsmp6@techsingularity.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230421143654.g6ta3kd6ea7fsmp6@techsingularity.net> X-Rspam-User: X-Rspamd-Queue-Id: 6E6DEA001B X-Rspamd-Server: rspam09 X-Stat-Signature: 4da5b7aa3wk7tmtwmfeaaexhfq14dsj3 X-HE-Tag: 1682388960-231297 X-HE-Meta: U2FsdGVkX19C5BmZWiz+3bUc2l1ogSNjfAPhY1/N6GCDKz9TsCmC7wcJrR7VeJbGR70iyNHTJqCF3VJpwk8le+iZ038Nyk0sUG4MvMKhfxhRZenALjW7xQh0+s4ln0E7V+S4m57QYl4jP5EfO03WUSNKlp/8foqqSgqpDUthW1Gz+O/UHwLdHWbNuiDxfIMwUPPBSWQ/BDixZAVBdKV20RwtpZ//G4F9K0G4RVug7LktsTHE1kf/PadZmm/GQpw8JWuYdDOs1+B+rDQplw8WLlX5cqulRLSMZR0LWEwAlpWzV034elnhhHBg1/qw5yHyObxm2etArialryjMjDRC5ZFOOY0s/DENy+jPkk6zTSlV3hX91lqDD8wv3gmmdZLyIs9cm0W+u5xLnxizcZdKQuIcRpsyYjDiZd2iHiC9R3Hslyikjg+OjrV/zK1Ln5uer5kyWTnHViy830NmHBUNrjD6+SmdKdlY/iO45MrrvxWPIlkHywEkzvT9R2wkdHPZeattxUbM8UrhuXwQGLDuljCHHs/ecnNW54s8hpOHqlSwUSnwpUXQEPOQMDr95omoXFdOlY8HyogRP/0ROBEqwBqF0UKkQRHWnHhJ3zPLQqqYzvDApnSbUY/k73cWrikL8B7e7tRAj8GTnLXJg3h8SAzXalS4zXxF6+2EybA5P2KMvyjijTTtq7q1fjU3DHJYhL9uiwjLfrXjeaVgYwMHlgpoLkCszCJPZvpMMcYseNgG98w8ahgT+5Kr0bGqxICk7hX6tcOIdUzBt5wSxh+SzD8qVxYU9twfednVrRUwK/uXRf2iaF3QhXnB7uUXbvwo2+ehHo8u9a7wq2XLOaKcOP8eAC7doMUF1yFMf4rEIpvPE1AAkHup1jGmLJEHVfKsDoyBguT337HyFfikRImyn06liBCRK63DJWuzZ+bB0kiTrCr/GnAtUEszmn5Gq/iP6ZHIDrx5wscuUTaaklN WQGThlqv PLSgw1WmZujruCQEjFbNG7k2IdKNUfqowf+iWX7/dttA5ZmVPorfUgGopXHiYlXicufq/hVdgLdJin+so3lQ8iRmz3F7MTj51QiLSiK28bJg0YAX22ZniUIqXdm2RYJYIBbkVU0JF3Q09P/UzsDuO/4gKy0uGW60tzx1v7QWYxdnxwrI2RoOkUCnt0BFytsdRcUpT7dN8fH2upmNCkKzl2t9lJK1psjRhPNbQ2TibB6Atqk6PH+Lew/vzaON3SSK1RNOHXrk8wYJd+oC+ZH6/D7Y3F8dUmeaYwyAQKAOIMXLKE1Vh7Fql7/AJzpDT2BD0OWz7ZPKL9uDn5M5rDG39My8LTjYi4MQlgkU5Un4M9HxvUd+GYEwaWBRnoVY/senmVpAeGt//yzkNBlZpGx3q5snNTw2iWDzfthA+dC11G3OpnKNANIX78wdWJgBlmBwXYZ2o6LZ9o0LCcCgHVk0mkhDwr/vF3uGPqC9JGjndx6e83aspjNOFn4AQzYqfvmSE3uklGxBWmxAgUXzOX8w78NVupw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Apr 21, 2023 at 03:36:54PM +0100, Mel Gorman wrote: > On Tue, Apr 18, 2023 at 03:13:01PM -0400, Johannes Weiner wrote: > > The different branches for retry are unnecessarily complicated. There > > is really only three outcomes: progress, skipped, failed. Also, the > > retry counter only applies to loops that made progress, move it there. > > > > Signed-off-by: Johannes Weiner > > --- > > mm/page_alloc.c | 60 +++++++++++++++++-------------------------------- > > 1 file changed, 20 insertions(+), 40 deletions(-) > > > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > > index c3b7dc479936..18fa2bbba44b 100644 > > --- a/mm/page_alloc.c > > +++ b/mm/page_alloc.c > > @@ -4608,7 +4608,6 @@ should_compact_retry(struct alloc_context *ac, int order, int alloc_flags, > > enum compact_priority *compact_priority, > > int *compaction_retries) > > { > > - int max_retries = MAX_COMPACT_RETRIES; > > int min_priority; > > bool ret = false; > > int retries = *compaction_retries; > > Think this breaks build because of trace_compact_retry and max_retries is > declared in a different scope on the next hunk. Right you are. Will fix. Thanks!