From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34655C6FD18 for ; Tue, 25 Apr 2023 12:32:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7FD8B6B0071; Tue, 25 Apr 2023 08:32:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 787366B0074; Tue, 25 Apr 2023 08:32:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 627486B007B; Tue, 25 Apr 2023 08:32:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 508946B0071 for ; Tue, 25 Apr 2023 08:32:46 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 18FA816011E for ; Tue, 25 Apr 2023 12:32:46 +0000 (UTC) X-FDA: 80719852332.12.FF5EE36 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf25.hostedemail.com (Postfix) with ESMTP id 25BAAA001F for ; Tue, 25 Apr 2023 12:32:43 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=l6SZcYPu; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=SnqD8o94; spf=pass (imf25.hostedemail.com: domain of jack@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682425964; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DWUaTY7zPvGDq1lV5PTAVmKwmRffgKuL2Z++9PCwg3c=; b=xAGQgsmEReybsf1EZE8BB1bi18uQPQnrgAgwi5TxHKllj2Uqev5wg4/kDsMS9+IcrehMLG 06S+acxqMoG/YwufuQ/rW4x2GcBaHIIUjaB6l+XCbjacyQuONoryPCF2TXCUChiZaf9Qm7 Rj80PcQSXpOMt74pdBTFEoxEMmpnZEw= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=l6SZcYPu; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=SnqD8o94; spf=pass (imf25.hostedemail.com: domain of jack@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682425964; a=rsa-sha256; cv=none; b=wAni7o1qo2DbiHao+CT1bMfSQzqbA8kR4UZ9xid1nR/aSbcGoMhqW4fzw27BB1lTu8tiZU k6XqPo1Y5IRJoS91gSQIOQSoEa8uc0+E6Z7XtxeoqRsDzoAzFpLFJboW27XUj3bT+nFAx6 OdTu80b6n/CSttvVrQ9cgqyhVXJrt9Y= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 806CE219CC; Tue, 25 Apr 2023 12:32:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1682425962; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DWUaTY7zPvGDq1lV5PTAVmKwmRffgKuL2Z++9PCwg3c=; b=l6SZcYPuHVYq6KDxG9bII8FjIqBv8sn5/osem8A9zypcIRAmEfV/4KlTmZHU/f44UpM7CN PlnCnX9CAMriBfwS+6iXUp/Qo3DVtvUkwxi8qxEtlnwCRl3JlW3qBqmDaNbDPjItgNEZSd PJnqbhRFuSKEl4eeYqrx7szOi+NofsU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1682425962; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DWUaTY7zPvGDq1lV5PTAVmKwmRffgKuL2Z++9PCwg3c=; b=SnqD8o94EjcTbND7Bxd0UCqrQVVYlIYIEW1Ss5sFJwjVgKcr9iaFr8WYerGTf/M9H+jXBS TXHFRrI0vMR6NcDQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 72E03138E3; Tue, 25 Apr 2023 12:32:42 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id h6QKHGrIR2RBcQAAMHmgww (envelope-from ); Tue, 25 Apr 2023 12:32:42 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id E1BE9A0729; Tue, 25 Apr 2023 14:32:41 +0200 (CEST) Date: Tue, 25 Apr 2023 14:32:41 +0200 From: Jan Kara To: cem@kernel.org Cc: hughd@google.com, jack@suse.cz, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, djwong@kernel.org Subject: Re: [PATCH V3 2/6] shmem: make shmem_get_inode() return ERR_PTR instead of NULL Message-ID: <20230425123241.4lrtqdtlhgri7o2p@quack3> References: <20230420080359.2551150-3-cem@kernel.org> <20230425115400.2913497-1-cem@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230425115400.2913497-1-cem@kernel.org> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 25BAAA001F X-Stat-Signature: dhpm8p5k9myuojrqpr67g9synp637rtg X-HE-Tag: 1682425963-346659 X-HE-Meta: U2FsdGVkX1/bLrYTLzOL8y7zS/2rOgPKWZRYwvYQ1ioi1uf8a3VacEMIFIaIXgLDIzd+cIbPdjlwaWlUI0ceCZ5/0ZDnuLjyiTUDcQhIwkCa0oiJCbf97CScGzZXjur/HVvrAx4h6PPN0S4MEUst5UCoSjPFdVrm2lsShrFNPX3/hSLUHkCHRLSFEjHgGknKfMsRXALpYK3QOhGBIFL1VB9D10W6d/4PdfujfVYfcbERHlebItgqy37CB0VWaIcrTJmON5bWdiPk7xW3x30NG/ntQEJi8xHun4HTZqfwAFpCo48cPmr+9FtfouUaVXw2ru3rbEGxcxN+Y583+Bf7X4gJ49PFMSQn3t1JXFum53a773jvXPkL2p89A1XS7kXXOyZ51x61CRdgK7BULUSOrUkZ/A5fTEUkor58RfVoQHs12gnrEo2gDrW1Ad/tJWWRqcSQ0rlu609u5mel36pr23v1NW7cebwn3zHhOJ+JpRz5CH+zDlR2z6Eggh9pYuA/8I6D8jA6GhGoPkAwuSIrNOtZjasYHF9f9siNSr6aVNxyhKrjQLLO/YIQ2wejATw4a2ENdoMetOKBdzAuylzoafr4LclIzdNsG95cXE6L8g3Pf2kwng1l1akZIRVVHgtKm0AhlKl02NMa8SljD/3Q6HJT4EH9axAC5zuWkdcv4sKOYyVSCjJWR3gAzTJ1eMe4lvyD4pzbP1H6a5lz+acI5fP0H49sFRRqNxfz4Hnjge5GBvpYdWNzhKKr780aDyNxSITIE1F/SFtUw/8lzKrlZ5ZMNeLq8CmKSRJKLtmfmBsN2dqKryTkghYD58eYAf5Cw1uDroGfW3xMcPK2VU4g1r6ThEJhcqezTcRTn0aLyNRbvOqXr/kejlin+TsLgVLpbuYL2hiwU3Xz8xcHMq6iMfb8kS27Tf6SpGoAS/LQsqM9Wy5QePkdwzDVxlC+7/0UO1v7W9rbEIcXJNuNHPc pwNhOG5T ctJb2gywJRPELI29u29qfjbnNOihkjU5/rR/f2ZDcwfSJyYu7D4TYMThFqHKc8YvEwYLjGGlxQ2WivHs4zevfyBTZjUtRU2K4x/gL1+hCPej23ifxteorR2ZQbCUCilYU3E8zZwwetY2EX0vwrASWAUtRCnNXjREVjQg2qKGFaNgW8vVBi4lezVZXXuOWe3Iw2Jd4LGk1r6BjIK9HFG/dyRXU2XWGhhYZf2CS+IWQTAEsnF5Jxrfe0DquvRTUs1Gvs9lwPK+JPkUDaF8s16Y37nlbRhIuAVWoviHr2I+t0vKonizPLNu8GqgsqbbziWRpusJk2nPv1gZ9+TM93hwpDNfcFXpC/hi0YejonchLEd+1EF2kDurj87n18Z64ChpvQv2R X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue 25-04-23 13:54:00, cem@kernel.org wrote: > From: Lukas Czerner > > Make shmem_get_inode() return ERR_PTR instead of NULL on error. This will be > useful later when we introduce quota support. > > There should be no functional change. > > Signed-off-by: Lukas Czerner > Signed-off-by: Carlos Maiolino Looks good to me. Feel free to add: Reviewed-by: Jan Kara Honza -- Jan Kara SUSE Labs, CR