From: Jan Kara <jack@suse.cz>
To: Carlos Maiolino <cem@kernel.org>
Cc: Jan Kara <jack@suse.cz>,
hughd@google.com, linux-mm@kvack.org,
linux-fsdevel@vger.kernel.org, djwong@kernel.org
Subject: Re: [PATCH V3 6/6] Add default quota limit mount options
Date: Tue, 25 Apr 2023 15:21:54 +0200 [thread overview]
Message-ID: <20230425132154.nxaxyyhwupelmma5@quack3> (raw)
In-Reply-To: <20230425125610.xjbkxlozfvio2ihh@andromeda>
On Tue 25-04-23 14:56:10, Carlos Maiolino wrote:
> On Tue, Apr 25, 2023 at 02:30:42PM +0200, Jan Kara wrote:
> > On Tue 25-04-23 13:57:25, cem@kernel.org wrote:
> > > From: Lukas Czerner <lczerner@redhat.com>
> > >
> > > Allow system administrator to set default global quota limits at tmpfs
> > > mount time.
> > >
> > > Signed-off-by: Lukas Czerner <lczerner@redhat.com>
> > > Signed-off-by: Carlos Maiolino <cmaiolino@redhat.com>
> > ...
> > > @@ -224,6 +233,29 @@ static int shmem_acquire_dquot(struct dquot *dquot)
> > > return ret;
> > > }
> > >
> > > +static bool shmem_is_empty_dquot(struct dquot *dquot)
> > > +{
> > > + struct shmem_sb_info *sbinfo = dquot->dq_sb->s_fs_info;
> > > + qsize_t bhardlimit;
> > > + qsize_t ihardlimit;
> > > +
> > > + if (dquot->dq_id.type == USRQUOTA) {
> > > + bhardlimit = sbinfo->qlimits.usrquota_bhardlimit;
> > > + ihardlimit = sbinfo->qlimits.usrquota_ihardlimit;
> > > + } else if (dquot->dq_id.type == GRPQUOTA) {
> > > + bhardlimit = sbinfo->qlimits.usrquota_bhardlimit;
> > > + ihardlimit = sbinfo->qlimits.usrquota_ihardlimit;
> >
> > There should be grpquota in the above two lines. Otherwise the patch looks
> > good to me.
>
> Uff, sorry, copy/paste mistake. Can I add your RwB once I fix it? Or do you want
> me to send a V4?
Yes, once fixed feel free to add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
prev parent reply other threads:[~2023-04-25 13:22 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-20 8:03 [PATCH V2 0/6] shmem: Add user and group quota support for tmpfs cem
2023-04-20 8:03 ` [PATCH V2 1/6] shmem: make shmem_inode_acct_block() return error cem
2023-04-20 13:17 ` Jan Kara
2023-04-20 8:03 ` [PATCH V2 2/6] shmem: make shmem_get_inode() return ERR_PTR instead of NULL cem
2023-04-20 13:25 ` Jan Kara
2023-04-20 13:40 ` Carlos Maiolino
2023-04-25 11:54 ` [PATCH V3 " cem
2023-04-25 12:32 ` Jan Kara
2023-04-20 8:03 ` [PATCH 3/6] quota: Check presence of quota operation structures instead of ->quota_read and ->quota_write callbacks cem
2023-04-20 8:03 ` [PATCH V2 4/6] shmem: prepare shmem quota infrastructure cem
2023-04-20 13:38 ` Jan Kara
2023-04-20 8:03 ` [PATCH V2 5/6] shmem: quota support cem
2023-04-20 14:02 ` Jan Kara
2023-04-20 8:03 ` [PATCH 6/6] Add default quota limit mount options cem
2023-04-20 14:39 ` Jan Kara
2023-04-21 10:20 ` Carlos Maiolino
2023-04-21 10:47 ` Jan Kara
2023-04-21 12:34 ` Carlos Maiolino
2023-04-25 11:57 ` [PATCH V3 " cem
2023-04-25 12:30 ` Jan Kara
2023-04-25 12:56 ` Carlos Maiolino
2023-04-25 13:21 ` Jan Kara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230425132154.nxaxyyhwupelmma5@quack3 \
--to=jack@suse.cz \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=hughd@google.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).