From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 197C4C7618E for ; Thu, 27 Apr 2023 00:55:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 912806B0071; Wed, 26 Apr 2023 20:55:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8C2F46B0072; Wed, 26 Apr 2023 20:55:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 78AE46B0074; Wed, 26 Apr 2023 20:55:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 671436B0071 for ; Wed, 26 Apr 2023 20:55:34 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 2E0791A0404 for ; Thu, 27 Apr 2023 00:55:34 +0000 (UTC) X-FDA: 80725352988.18.1F6C240 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) by imf12.hostedemail.com (Postfix) with ESMTP id 53F5B40002 for ; Thu, 27 Apr 2023 00:55:32 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=lyo5HpmP; spf=pass (imf12.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.210.171 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682556932; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yudVX7H4NIkiNzJ9h/7v+Ix6+CQ48FCh3vdWg2CCa+Y=; b=o84xygetW9nxh1w0oxby8V3a7KGKj8k1tNopvmij+MoYNtk8UaRuBOwoq6DrGbiIJBokVq v3VUTyb7uoophjHjI8FyDBBQZ4o+VawJEwLTDPA4n/u+VJ7fomUyTuCc98s+K5vWrsQSnx Xq3/uqIPAvwEAm07iYxoMbiHewJHK5Y= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=lyo5HpmP; spf=pass (imf12.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.210.171 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682556932; a=rsa-sha256; cv=none; b=JLksnExWGzK5sItb56CkaiZhIhRjgEO9ovFDh1r5UKlQ3QNydBE9Fk7d+iKpK3yexCT3ZX TJlOaXP04vuUnRxm12ee5mRdaHDclmI/a4X6HksWkXPtlfmibST4UNRi3t+j/82o+8anp6 fvkqhuyEQorHTPgy1x2Qkm44JgD6Deo= Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-63b52ad6311so9179130b3a.2 for ; Wed, 26 Apr 2023 17:55:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1682556931; x=1685148931; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=yudVX7H4NIkiNzJ9h/7v+Ix6+CQ48FCh3vdWg2CCa+Y=; b=lyo5HpmPPSKolKBMxnPM231JTOTMTYvltSMnwkbTvdMQxeRwrvOaTo//K+J0zWJYLK 4/53gNTzI3i5Cxkomb16kK3VD2XaUWL5wSilFWJwDKWwddRdABcgiKcy0yHgG9grtzT+ OmsXMqq0zQHNDZphrGnQvCMOGHRkMLS9q32Jc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682556931; x=1685148931; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=yudVX7H4NIkiNzJ9h/7v+Ix6+CQ48FCh3vdWg2CCa+Y=; b=DOHmfqEr2rGUWtDkxyhTDr0lumdVcxgZ+CjDW0e6rdrJKQtdEBDGYudnj7rLOVsKvs MtHi9p7uqhJCCSxCKcjs7uTCs50bqfwljWWOzIozp4HOsWjJddca7UiX4uLUaq4+/OIV KN2IgB7YusqWj04MksmDt4VLpJgwP1z4puZIqBRmZW+k3vISDPfDlKlLR+ngrC4biocK AtE90iCpu/jhlV6AyxT7LfwL+GMq9pjoNNHqZlj6eLz+O6mEWBGkl1sN77zEKSpNDxub pl4X2GNoR2JZya5Cw5idxaEJaYiQ5D40koQsnis7zwZ8ZNWL0tOTm3F6CsgCsWQeQkqa AGcQ== X-Gm-Message-State: AAQBX9cXZwUcuQwdmf2mEXNVN317a38mJbdFqbnXcB14YUzX++s8ITgL lCxyQ2PeqStLbnEn0HB+NWCMjw== X-Google-Smtp-Source: AKy350YskKlSRM7MYbei0qJ+kZPwyxuutnsUnqhTuV4kOICiCIk7mkOGwawDAp85yUEY+tM92eHw0w== X-Received: by 2002:a05:6a00:b87:b0:63d:2d99:2e91 with SMTP id g7-20020a056a000b8700b0063d2d992e91mr32488778pfj.28.1682556931215; Wed, 26 Apr 2023 17:55:31 -0700 (PDT) Received: from google.com (KD124209188001.ppp-bb.dion.ne.jp. [124.209.188.1]) by smtp.gmail.com with ESMTPSA id q14-20020aa7842e000000b00640dbbd7830sm5830995pfn.18.2023.04.26.17.55.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Apr 2023 17:55:30 -0700 (PDT) Date: Thu, 27 Apr 2023 09:55:25 +0900 From: Sergey Senozhatsky To: Michal Hocko Cc: Yosry Ahmed , Johannes Weiner , Roman Gushchin , Shakeel Butt , Andrew Morton , Muchun Song , Sergey Senozhatsky , Steven Rostedt , Petr Mladek , Chris Li , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] memcg: use seq_buf_do_printk() with mem_cgroup_print_oom_meminfo() Message-ID: <20230427005525.GF1496740@google.com> References: <20230426133919.1342942-1-yosryahmed@google.com> <20230426133919.1342942-2-yosryahmed@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 53F5B40002 X-Stat-Signature: g3pxcafgxwhesjaeuqmb4c3fudqpms7o X-Rspam-User: X-HE-Tag: 1682556932-469062 X-HE-Meta: U2FsdGVkX1/M1spn9iZODtZlqaSZz83R8gdezstcjIlWvOeK/ma7WllXqxSNfeDnNZkWnH1FmYbbnz4iIQgMIK/UKpBanGzNjXeVdbPkZ1xnZgHZD69XjLrQtymfCuAjv1UHhn3r9iJkpKBA4rKRqCR+yPwDWkgv8RhHJ8D6eP2tSGJDD6hHR5m/rYdJshbD907DzODUCApECTCjJMuso1+rJb9z879Rj/jJV+oFM5s63TybfjuKaK0Mflu1iDGFUepstHa2Tk4K7BS9dEZjm/vfl+eDOKfIUE/T0u3Xtm2yKP3TOz0iDlnsSAdFqCLCYWHVKCUeQmbamvd5+in7o9UZarRsvcSelv3eIUuHK1LC1vkukhIBKuOE6nWLk+gDmvIbg1+DyeFjO01uEqNp7V0hq1rq+1ZSYYu1fC+dEAsqt4pDCU0DtiZvzrzEJMhzBIMmid7FQHWShzNG7i97e5+LhWHAOYnfrRTPfO1GVgBSJFVG0OVKMiqAVt/EwGRom3qVme4dnw+9xA5lh00nE8pTQOA/PCpdmV5/eTDjVBM+v1AcIbVQLYiFtSMaPC0I2xmFloOFNzZ2Nffb7cmAT+CT0VwfZJSLDouvBjr2fteLGWLGBtZG8u9ylRmkcS97ioSa4j+SaurM8txhFVINyG2rv2e+QD0c/GIzmMtsiJrDJAqAPYmKWC753WQP2ENa2Tr22zeuwvkrOoXj0JO9o9PT5dRCe019CHst7kOI3E4Vo1tCbPbxDcHyec6QubwsVoHWgP2wTE2dPNAd1fA3bvkpiBk1FCfyCedDllku6B5V0vaWNKWSleWrCcWIcXN4mXUr1MYKGXQz3iM48IUjCIFrWkl/FwD/Ox1igie3UX8aKeYaOPOb9leynNxoDHx1152nKopEzR+t++RsS1XBBVZLvm2Cadk/ohbgK19iV21wAtWNkMjVvK4kUGf6B6o7VJDmxypVhp9sGMtWpVr Nx/HgAE9 v5ZgHuOYdZ8EsxBl6kkoOgB6akjn/fEKKEFoVy3qBEtQsv1DKI++w5xx/VDjY1/H8fRYjs+xF7TcDf+IaPeH33DoJm+PkPgGhovnnivy240z8ktO7GzQph8XhfaavSW99+BHG66ea4G4WLwENEtwnVr7Fn/TkpNNNCirQH8zku3MBk9p/+fQjyUtBF2WSa2JHOmgT+thi6aPDUn7L5brD8e7g8K2iPubmw3irQ1pFFWNVIsM9h/aeMNIRATrIBJuKcIeWhLKcba7p9lPCJ3b2QQgpVgT7r4UwC7sBg104YPLZ4F+LrMgr/qRFrAOXb46ZQhUF6rbOPKpaLyOu2U+GuSG5ZfMafP3Z3Hk+ygk6xS7WHd0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (23/04/26 17:24), Michal Hocko wrote: > No objection from me but is it possible that more printk calls (one per > line with this change correct?) would add a contention on the printk > path? It probably will have opposite effect: console->write of longer lines keep local IRQs disabled longer and keep console_waiter printk spinning (in console_trylock_spinning()) longer.