From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CC12C77B7F for ; Tue, 16 May 2023 09:53:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B3B9F280006; Tue, 16 May 2023 05:53:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AEB76280001; Tue, 16 May 2023 05:53:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9DAFD280006; Tue, 16 May 2023 05:53:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 8A548280001 for ; Tue, 16 May 2023 05:53:35 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 4AB4BC019D for ; Tue, 16 May 2023 09:53:35 +0000 (UTC) X-FDA: 80795655990.19.E1A94F2 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by imf30.hostedemail.com (Postfix) with ESMTP id 5733180010 for ; Tue, 16 May 2023 09:53:33 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=RclO7+et; spf=pass (imf30.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.174 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684230813; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tyBrBVnNr2SOCdaFWqHhcOXYMqWOw/MP+dWIFM1LTtg=; b=2gqxN441jhhd8/J73TDo8x9oCbZFEOJRiHVP8tyCLM9WRgGhVDJdhAzJ5pwq5RjxW/KOIg bwZgCfnyhCT9y25Mv/nevLC/tZaFKcSa2qR+78OPiOr+seLYPsbhWRsjrYBH0hnNtPdtwi cN02UEzpn08COy8npCz9omASo9OjIJs= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=RclO7+et; spf=pass (imf30.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.174 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684230813; a=rsa-sha256; cv=none; b=h/GfsvkbmDwPId4ywt8B6uGK+7Ghb6QKY40vXmJid4P3BLVg3/Vd8h9RbevfTFETBhfZ5L wim16pnU33uAo4EvgswN5YvHPHpZJMRXEX5ITU2cZBWksEPmI0f1b4vlvp5XCM2QimQjtN CQyaaSNL02aLnUl9Syaupu3aHrekh9w= Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-1ab267e3528so99572455ad.0 for ; Tue, 16 May 2023 02:53:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1684230812; x=1686822812; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=tyBrBVnNr2SOCdaFWqHhcOXYMqWOw/MP+dWIFM1LTtg=; b=RclO7+etUaKAQjyZ1S8NsH+uIH632x2W9GFsGzLA3xsG7SzNK1aZbCM4M4P98+udqJ 2EQErGfPB6nY+nSqePmqTMC4eRNLjVsyIrS4SHE6kgeKkDYVXhC+ptO8w4xC4VBwX8Aq UuIeIHDkDx5bynCZZEGpRa4bh/ORInxwhZOho= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684230812; x=1686822812; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=tyBrBVnNr2SOCdaFWqHhcOXYMqWOw/MP+dWIFM1LTtg=; b=DXeG4mW7XSZuPc0bSWsPM/M4cHWXqMYBRdXejSFJeZaIeNiR0oGA6EASLU4JLvJTzQ gvdEpJ/ScNnrwDcqrlRu+cVA8x5u66AbD2HOaCJ+C3VacQNd//TPG12KcJKzDAt6he0V he9Q0JgvSVzRjSWVERsRBr5tPlGCfO9vJSJx3sbmr3c3bRRkxmbBcAAGG0Dm804lkqe1 qd6Q6jyoBhNRxdU4Ujrc3NIL3czfNw93PhsO6mIg2NSTM5t3XieoFeKiqx2n+J41Ptj1 hNl2uAb7JTxJ1Mvqj25Xch4TV5BZuUo3ImqT5PDuyRNsYVVbwipwcCxN2BoK+keq5/fV 0Lsw== X-Gm-Message-State: AC+VfDxNgF7o6KOo/Uop5mFoZY685fO98Gcn0JE86iKlsmqqKj6Fphah sWy9K4Zg1uqlRNfrhYaZ5GoqbA== X-Google-Smtp-Source: ACHHUZ6LeeP0sZF5pT75U6Di1ecCjIy1JjV7dI1uuDuaneUFbuVZv/3N/htzsX9mSjCLivc2hr9bPw== X-Received: by 2002:a17:90a:8a8d:b0:24e:69e:71f with SMTP id x13-20020a17090a8a8d00b0024e069e071fmr35185215pjn.7.1684230812057; Tue, 16 May 2023 02:53:32 -0700 (PDT) Received: from google.com ([110.11.159.72]) by smtp.gmail.com with ESMTPSA id b30-20020a631b1e000000b0050bd4bb900csm13150378pgb.71.2023.05.16.02.53.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 May 2023 02:53:31 -0700 (PDT) Date: Tue, 16 May 2023 18:53:27 +0900 From: Sergey Senozhatsky To: Alexey Romanov Cc: minchan@kernel.org, senozhatsky@chromium.org, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel@sberdevices.ru Subject: Re: [PATCH v1 1/2] mm/zsmalloc: use ARRAY_SIZE in isolate_zspage() Message-ID: <20230516095327.GA15689@google.com> References: <20230516095029.49036-1-avromanov@sberdevices.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230516095029.49036-1-avromanov@sberdevices.ru> X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 5733180010 X-Stat-Signature: g74brnrj759rtxi1oix6oygn4di19yh6 X-HE-Tag: 1684230813-804934 X-HE-Meta: U2FsdGVkX1+dKB0CravOxNAd2/684tBZ4Qo/MuChfkVw7LGiVaexgao7c9lE21fWurHPH7t+LbvYZjiM897bMA5XFSZgTxU0e6P9/biJMoaCjvvLsxtJUB8tmegJKe5gnJ5AUjDh9TIMxc6shHTN4BhqO4KTzgvYcDkhLZxDG4vdJ47mzJXTGaUUhXORCfdtBDxS5wmTcbWUF433FaTk73WufaEC2TDU26dabH9eAG+PVap7BWFOX2txrJUCtuN2Oz93toTMx38OGHc0/719NxO+6U5H6qulhFuY9jFnwPsCEIsyffXZNkr5K2THY7cq5sFDlZW0c33unelhAEsbHUAVJQAE1zNMI6al4QjyedQ4cvQouWshpSMIPzIurIKSmR9pZ/x40ehljrm3lcpVAHocNUgSYsGNs+M7yZR3YR+YH8dGcLXn7tCQKZj5qPrtMgWoBNQR5yp5T7d1Xdt0jzbdQX9MA09zn5B/IZKXqzxQzYghPLrTdugMTg9+vqTZXjBt73RwA1fJV+8//lwFvL8x3u0f+dBAp3QThwcyxE2EX20UvMhELABoxlZaaF1ReNHO38h9GOK5d+WbZyCSepxAHkAkz7FeYoxB/6PTZGuH7Z8hkWgzpSK6f6oTMKY7WbbOGR6EtKOS+7M3UAAekXPIYa32wrCO8TZeD4yDZg/ddMb/IevA16m1KQhLWpV+EfwMbGX8nd1xJ4DdYqSRZnsz6h2BGGyAM7LhzF6YW80+2ISKc7TtWvmj6LXMWFSk95NG3rjOMjHSJSO4uBmOhYd2rnYea6bfCHY+e7+IhgPkZIZj//vWmtBGS2IRt1ZdB+totplCJW4dZxqQGxDx3nNyHFbLFcmwmyLWTw0rkvd5N4B9ZTIxNL9z7Tl+69iAi/f8PVWBDAfvzmkrFbcKChfCswEo6MO2FlPTl1K8EvpI+/Ubsk9kEZebH650Fo3uqzT9jJ+rvkHk3fZcraQ lHBtadnm tFpAYrNnPKBak/uDBdWz+5ZMsFsM6hJFvzjBcFyfe8ek8/mBmd7rhlf3Yl58VEM/PBw3gSkBGRKt90/FdbnNgNNXxf7Wt7nzmDyeHGjOUalH8+x/zzPMOtWogBrguvF9HvTwdCG7L9cZ9lttIFYfZ4kZcVXBialSH+/iKVCmKIrryobJgJSk7TbVTLb5iWMYCeegQX2UV8vi+Yi1prWPgQszwitH74Ngoz5ZIZBE/Hs3HoHqSYjmgAbcBsJ9KbTXcOwuSsw0r1gHDSOvsFzCaxKKCFC5ew0u194AmxusKVAioac21A5vM6PbmEvMFequeszUe3lanNaqbj0UqacIfKYnRSq1/03rLfpPTURFcTf1wQY4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (23/05/16 12:50), Alexey Romanov wrote: > mm/zsmalloc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c > index 702bc3fd687a..f23c2da55368 100644 > --- a/mm/zsmalloc.c > +++ b/mm/zsmalloc.c > @@ -1888,7 +1888,7 @@ static struct zspage *isolate_zspage(struct size_class *class, bool source) > fg[1] = ZS_ALMOST_EMPTY; > } > > - for (i = 0; i < 2; i++) { > + for (i = 0; i < ARRAY_SIZE(fg); i++) { > zspage = list_first_entry_or_null(&class->fullness_list[fg[i]], > struct zspage, list); > if (zspage) { This patch needs to be dropped. We don't have that function anymore.