public inbox for linux-mm@kvack.org
 help / color / mirror / Atom feed
From: Yuwei Guan <ssawgyw@gmail.com>
To: rppt@kernel.org, akpm@linux-foundation.org, tsahu@linux.ibm.com,
	anshuman.khandual@arm.com
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Yuwei Guan <ssawgyw@gmail.com>
Subject: [PATCH v3] memblock: Add flags and nid info in memblock debugfs
Date: Thu, 18 May 2023 17:14:31 +0800	[thread overview]
Message-ID: <20230518091431.299-1-ssawgyw@gmail.com> (raw)

Currently, the memblock debugfs can display the count of memblock_type and
the base and end of the reg. However, when memblock_mark_*() or
memblock_set_node() is executed on some range, the information in the
existing debugfs cannot make it clear why the address is not consecutive.

For example,
cat /sys/kernel/debug/memblock/memory
   0: 0x0000000080000000..0x00000000901fffff
   1: 0x0000000090200000..0x00000000905fffff
   2: 0x0000000090600000..0x0000000092ffffff
   3: 0x0000000093000000..0x00000000973fffff
   4: 0x0000000097400000..0x00000000b71fffff
   5: 0x00000000c0000000..0x00000000dfffffff
   6: 0x00000000e2500000..0x00000000f87fffff
   7: 0x00000000f8800000..0x00000000fa7fffff
   8: 0x00000000fa800000..0x00000000fd3effff
   9: 0x00000000fd3f0000..0x00000000fd3fefff
  10: 0x00000000fd3ff000..0x00000000fd7fffff
  11: 0x00000000fd800000..0x00000000fd901fff
  12: 0x00000000fd902000..0x00000000fd909fff
  13: 0x00000000fd90a000..0x00000000fd90bfff
  14: 0x00000000fd90c000..0x00000000ffffffff
  15: 0x0000000880000000..0x0000000affffffff

So we can add flags and nid to this debugfs.

For example,
cat /sys/kernel/debug/memblock/memory
   0: 0x0000000080000000..0x00000000901fffff     NONE    0
   1: 0x0000000090200000..0x00000000905fffff    NOMAP    0
   2: 0x0000000090600000..0x0000000092ffffff     NONE    0
   3: 0x0000000093000000..0x00000000973fffff    NOMAP    0
   4: 0x0000000097400000..0x00000000b71fffff     NONE    0
   5: 0x00000000c0000000..0x00000000dfffffff     NONE    0
   6: 0x00000000e2500000..0x00000000f87fffff     NONE    0
   7: 0x00000000f8800000..0x00000000fa7fffff    NOMAP    0
   8: 0x00000000fa800000..0x00000000fd3effff     NONE    0
   9: 0x00000000fd3f0000..0x00000000fd3fefff    NOMAP    0
  10: 0x00000000fd3ff000..0x00000000fd7fffff     NONE    0
  11: 0x00000000fd800000..0x00000000fd901fff    NOMAP    0
  12: 0x00000000fd902000..0x00000000fd909fff     NONE    0
  13: 0x00000000fd90a000..0x00000000fd90bfff    NOMAP    0
  14: 0x00000000fd90c000..0x00000000ffffffff     NONE    0
  15: 0x0000000880000000..0x0000000affffffff     NONE    0

Signed-off-by: Yuwei Guan <ssawgyw@gmail.com>
---
v3:
- show string value for each memblock flag
---
 mm/memblock.c | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/mm/memblock.c b/mm/memblock.c
index 511d4783dcf1..5fba53f98b2d 100644
--- a/mm/memblock.c
+++ b/mm/memblock.c
@@ -2143,13 +2143,23 @@ static int memblock_debug_show(struct seq_file *m, void *private)
 	struct memblock_region *reg;
 	int i;
 	phys_addr_t end;
+	static const char flagname[BITS_PER_LONG][8] = {
+		[0 ... (BITS_PER_LONG-1)] = "?",
+
+		[ilog2(MEMBLOCK_HOTPLUG)] = "HOTPLUG",
+		[ilog2(MEMBLOCK_MIRROR)] = "MIRROR",
+		[ilog2(MEMBLOCK_NOMAP)] = "NOMAP",
+		[ilog2(MEMBLOCK_DRIVER_MANAGED)] = "DRV_MNG",
+	};
 
 	for (i = 0; i < type->cnt; i++) {
 		reg = &type->regions[i];
 		end = reg->base + reg->size - 1;
 
 		seq_printf(m, "%4d: ", i);
-		seq_printf(m, "%pa..%pa\n", &reg->base, &end);
+		seq_printf(m, "%pa..%pa ", &reg->base, &end);
+		seq_printf(m, "%8s ", reg->flags ? flagname[ilog2(reg->flags)] : "NONE");
+		seq_printf(m, "%4d\n", memblock_get_region_node(reg));
 	}
 	return 0;
 }
-- 
2.34.1



             reply	other threads:[~2023-05-18  9:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-18  9:14 Yuwei Guan [this message]
2023-05-18 10:11 ` [PATCH v3] memblock: Add flags and nid info in memblock debugfs Anshuman Khandual
2023-05-18 14:05   ` Yuwei Guan
2023-05-19  7:34     ` Anshuman Khandual

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230518091431.299-1-ssawgyw@gmail.com \
    --to=ssawgyw@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=anshuman.khandual@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=rppt@kernel.org \
    --cc=tsahu@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox