From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAFA3C77B73 for ; Sun, 21 May 2023 19:20:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B9D106B0072; Sun, 21 May 2023 15:20:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B2698900004; Sun, 21 May 2023 15:20:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9ED69900003; Sun, 21 May 2023 15:20:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 891CF6B0072 for ; Sun, 21 May 2023 15:20:57 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 4B49040235 for ; Sun, 21 May 2023 19:20:57 +0000 (UTC) X-FDA: 80815229754.01.5ADFA35 Received: from outbound-smtp51.blacknight.com (outbound-smtp51.blacknight.com [46.22.136.235]) by imf12.hostedemail.com (Postfix) with ESMTP id 2659D40011 for ; Sun, 21 May 2023 19:20:54 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf12.hostedemail.com: domain of mgorman@techsingularity.net designates 46.22.136.235 as permitted sender) smtp.mailfrom=mgorman@techsingularity.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684696855; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KUmPkzyesMTFdfiNURu0+0dmf2lxSHeZkjrft1cD+Ro=; b=G2BCk7N95XPpmG99myKcDIiunUws8RomABAkKMcyh8YcMnAFkZi+wgR0Q4yRZMGUr8QRFI MYA2dQCdCLT9y9nklGAgfcca08KIQD3eoi1V2uHo4qKHPUDJ3wbSE1wbaMEj4TaXIcO1TY arDQz4DOPl6tz+gEM9TwFg9fcR0xdA8= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf12.hostedemail.com: domain of mgorman@techsingularity.net designates 46.22.136.235 as permitted sender) smtp.mailfrom=mgorman@techsingularity.net ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684696855; a=rsa-sha256; cv=none; b=dVva4UF+q1VNRGOHEqztok/e6tEOPwPCsr+7N7pa+q2q6LFjiULJnn9Tq0prEE3XGjaQLm 8OfsQRFExp/Aq69MaKOI4vkphF+J8/Qf5SC1ZSQf9CG2fnBCYnWZvA3xEu5TNSDzU1mSJP Enw40a95BAqImBt7Q2Sm5Qusurl5h8o= Received: from mail.blacknight.com (pemlinmail05.blacknight.ie [81.17.254.26]) by outbound-smtp51.blacknight.com (Postfix) with ESMTPS id 3D8DFFB23E for ; Sun, 21 May 2023 20:20:53 +0100 (IST) Received: (qmail 13105 invoked from network); 21 May 2023 19:20:52 -0000 Received: from unknown (HELO techsingularity.net) (mgorman@techsingularity.net@[93.89.247.161]) by 81.17.254.9 with ESMTPSA (AES256-SHA encrypted, authenticated); 21 May 2023 19:20:52 -0000 Date: Sun, 21 May 2023 20:20:46 +0100 From: Mel Gorman To: Raghavendra K T Cc: Vlastimil Babka , Andrew Morton , Jiri Slaby , Maxim Levitsky , Michal Hocko , Pedro Falcato , Paolo Bonzini , Chuyi Zhou , Linux-MM , LKML Subject: Re: [PATCH 0/4] Follow-up "Fix excessive CPU usage during compaction" Message-ID: <20230521192046.pduhkcv2u3j5dfbl@techsingularity.net> References: <6d62686f-964d-342c-e085-0eae2555cc54@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <6d62686f-964d-342c-e085-0eae2555cc54@amd.com> X-Rspamd-Queue-Id: 2659D40011 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: ez81163yddfwt8wbjdidrnw1o8ebu5yj X-HE-Tag: 1684696854-321940 X-HE-Meta: U2FsdGVkX1/iKuorpyMr6fYnUHQAT3tI23HdtG0H6vRSn0+Qi8PoIW74AI8W7eWrlxogWRkSXgj6nwdEODV5j50fNqpgmACaRoQWPfvLADFh1hXSxpStmLGAZvQRp9Mqzr5bHP1HJmhHHmk23QwvrZBQxe3HkyqHNtdbZk4XygDMtssRzKQb991an2i2OoDPP2ZmRFH4QM//JVrg9FtPR8I7U74IOKPeoh0RG13ll1CyorcXoDfrqnQ/Fdvrz3QiE6Xu1ILyMBNrOzHvXgRAUo1JsDNeFPQU510orZgAzzx5M0Ow4sbjAtlZBREOuEhvICz5aW2aYe1OrZf+oaILEk98kKmeBxgrKLWLNLdBJ6pOdJO7kdL8vJO/8A6yr3icqkERQeL/VGVV/yCMhwqoGG+4Trv1GP0O52pWk/GACz3DZGGW8hFxCVQrRhdZCMs/leXdd0+DO18I182sCXfLCW8FIwCgKOmGCDEbljxjxjhPV4z6LM9KD+g5oq/0N8j41Eqy3i4SuPqBl/WE3J0DTcec+qepr/RJbAL895RBUZcGcCjeA1WOhnn7k/bbO8HjLYp2khxQcUvLJP1RS9fxYKJYoLvRHhRQfXVJ66sjAFOIkhLb3ZaM+KsFw/e9iOtXv4xmWFuSQfUrO5zAIiAkOHN8Cv5iIukIxDkMebDyrsuW8uDzmPaKC2ibgZwxiDDOtNvLJAiQg16Pv3UpZUq1zsvFvvuef3SVLJwUhX2sZWpdPI2d/R3T1huxEsHJubadJZkC802mQYvj2Lz2+RA9CZSx9dkdURF5bEYWegYCrUl4M3/Geoh/4NbfyTfaVZLHtWJ2kwrYEvBtbsg6qgILXfhbtBlvl/XDYH5a1Nr9Pe5vpgWCn2fgqRLdTt8D5qkWZu1d2zjK0KLDahiHwRxRiEqqcapGaHZExlIZv5PuCaDryhOGwbEkmnNmq4dgS6cDSc6EcKxMs+/lSGSQZDO FcuY7V13 DdLPyS220/XlwR7fvAo3TDwS3jjfXiTh5JAXEuZsIZJ7rim2UsoSn12Exxbh2ob1yM7X/wHdGVWuZgexNHuGMp7WQcDQS7dQvkJf5HXxSjVwtA2FCmAcVgE64impZAmX/ZP5bwvhv4MyZy/d+Av09xXgbAeoz+avdX2hH6VZCDsSfmMf0anQe/CEI9Xamhn0DSfQPh7Ez4gcRM2ubIWHoauZKSSPuBqU5EnQnnGKnf88TOQsMbVyWUmz91VNlmpkg9py1POuy6KM2oSC10zcc9qzeHds7z/SBXeUKa4D4NG+Zax1CyDRgcjkGIg0p+jcNPWu8mGlQKjdqcW98LTx2uQgqmh/8mHYC6DvCDxn47fgWWV3z4LqSFSqQcUwfK+jJnPCMdI+UeovJvYP9K1E/SRJCWUjKCnc8mBLt8ZY6GD5Eneo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, May 19, 2023 at 12:13:11PM +0530, Raghavendra K T wrote: > On 5/15/2023 5:03 PM, Mel Gorman wrote: > > The series "Fix excessive CPU usage during compaction" [1] attempted to > > fix a bug [2] but Vlastimil noted that the fix was incomplete [3]. While > > the series was merged, fast_find_migrateblock was still disabled. This > > series should fix the corner cases and allow 95e7a450b819 ("Revert > > "mm/compaction: fix set skip in fast_find_migrateblock"") to be safely > > reverted. Details on how many pageblocks are rescanned are in the > > changelog of the last patch. > > > > [1] https://lore.kernel.org/r/20230125134434.18017-1-mgorman@techsingularity.net > > [2] https://bugzilla.suse.com/show_bug.cgi?id=1206848 > > [3] https://lore.kernel.org/r/a55cf026-a2f9-ef01-9a4c-398693e048ea@suse.cz > > > > mm/compaction.c | 24 ++++++++++-------------- > > 1 file changed, 10 insertions(+), 14 deletions(-) > > > > Hello Mel, > > Not sure how much this info would help, (also I saw it is in Andrew's > tree already) But was curious to evaluate the patchset from perf > perspective, and I have run mmtest usemem so here is the result (Only > for compact cases). > > > Thanks Raghavendra! -- Mel Gorman SUSE Labs