From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB077C77B73 for ; Tue, 30 May 2023 06:03:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DEF2E900002; Tue, 30 May 2023 02:03:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D77A96B0074; Tue, 30 May 2023 02:03:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C1733900002; Tue, 30 May 2023 02:03:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id ADEFA6B0072 for ; Tue, 30 May 2023 02:03:51 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 5932412010B for ; Tue, 30 May 2023 06:03:51 +0000 (UTC) X-FDA: 80845880262.26.E72CC85 Received: from smtpbgsg2.qq.com (smtpbgsg2.qq.com [54.254.200.128]) by imf04.hostedemail.com (Postfix) with ESMTP id 4C71040016 for ; Tue, 30 May 2023 06:03:47 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf04.hostedemail.com: domain of gouhao@uniontech.com designates 54.254.200.128 as permitted sender) smtp.mailfrom=gouhao@uniontech.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685426629; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=y0a3qrgW7xR5mo053x8YAAt5HhAI7uPhIOS31nE1PP4=; b=iZ0hN505kPbW4Gfg/4Ub3U6OQt/Rz+yz6RivnKh8OeyW+Utwwf72Gra95tw9+WIK6oZmfL CfBZS6iuGjOXCwNl6k69PsABu+6RsyJVjMar0h58ZyLtp67oSN084xX1eawy86Wqk3ycw+ KoUlqtFQCbZWlH0l6KoemIGUypxe/Bk= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf04.hostedemail.com: domain of gouhao@uniontech.com designates 54.254.200.128 as permitted sender) smtp.mailfrom=gouhao@uniontech.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685426629; a=rsa-sha256; cv=none; b=Sa/a2Wtld3mg4o/CNs99nw+tS66oaQLgZFbqd5vosrmo4MlyyTX+pvAoVOqqwDARd1yKl3 /YT2gsPilKv7gICehbUHNGVqmcdUrrztw6+GpTHP8XH/wmqqQYNinra6AqZ0jdBuX1uMc0 plLh0NVOMMYKhP+pQulZxG+hMrEQY1A= X-QQ-mid: bizesmtp65t1685426547tmy4xja6 Received: from localhost.localdomain ( [113.200.76.118]) by bizesmtp.qq.com (ESMTP) with id ; Tue, 30 May 2023 14:02:24 +0800 (CST) X-QQ-SSF: 01400000000000C0G000000A0000000 X-QQ-FEAT: znfcQSa1hKaNoAA+Wu37XwpK1cksC/6aTghWFSS0JvJasQfz+eIO2zJLQRT6i rEM1DjNn+cMKUMmMkYKxNVhiJ/YaqYwyOdwJn8trVVHL4FwWqRIC1gXasm0tl2QcgbOhP2j LvZhKTr8+O0f7WbJ7aEKXPBecA76aTyilAsJsTVqnedMXbBhFAnGHPVXjv6vLMsjW6YvPyi i1gtBueSiPnfPmNzUzOGPtA6xO9BEI1yiGrXZ0be9XSQujkY1RIoTVJFJr5g/q5q1gPvFUS ZEKOIIEP+REIXrHWhBXhZbB8seLB4k9ZUsPfQMlMU4/yyaVrRkuBNBwcOqvR1A5Vgs91htm UZo1RdQcwSh9F4y0PRV2IDwcHtWLTFF1d191XBv6COHtM1tov3TE4c2SwkUPUQ1WWsDxlmz X-QQ-GoodBg: 1 X-BIZMAIL-ID: 6104239791662094715 From: gouhao@uniontech.com To: johannes.thumshirn@wdc.com Cc: agruenba@redhat.com, axboe@kernel.dk, cluster-devel@redhat.com, damien.lemoal@opensource.wdc.com, damien.lemoal@wdc.com, dm-devel@redhat.com, hare@suse.de, hch@lst.de, jfs-discussion@lists.sourceforge.net, kch@nvidia.com, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-raid@vger.kernel.org, ming.lei@redhat.com, rpeterso@redhat.com, shaggy@kernel.org, snitzer@kernel.org, song@kernel.org, willy@infradead.org Subject: Re:[PATCH v5 04/20] fs: buffer: use __bio_add_page to add single page to bio Date: Tue, 30 May 2023 14:02:22 +0800 Message-Id: <20230530060222.14892-1-gouhao@uniontech.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20230502101934.24901-5-johannes.thumshirn@wdc.com> References: <20230502101934.24901-5-johannes.thumshirn@wdc.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:uniontech.com:qybglogicsvrgz:qybglogicsvrgz7a-0 X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 4C71040016 X-Stat-Signature: frk1irqj3r1bx5azm911jwwhrx9fyt3h X-Rspam-User: X-HE-Tag: 1685426627-781970 X-HE-Meta: U2FsdGVkX1+eGMMBR0KlAoncJjMaT/W+f4kBA6aNyO/zXowGu4xSjs+nGoJbxriJbOUiGlbQA168DNoBT7tKvYELRIC5svoC0d+URl/4OeB69lfpFGII357qhgu67MBdDCeW/wFw4SREvVPOTHmeXWTUwXf6m0oZ/0xzGWxoeUdmNT7rvp50TdvZOdsdSqXFNXbsvg3ld6zIMTL/Gs01EZluEISEj7EG8WNAQPssRY4/9zHTx5xbZAKQpo7Odl7PAIdI8Ih8yxg1IzNg7Z1XjkShpJyiXW79wZIaer6tXxAdbPXoJF3rzS+lvZr7sRw8DWwE8UQYCNtDTUpTYCO1kW73VTxrXj5yiR4dfCx0H4JqcChZDyIyVc6qpgn5AwIWrnfnLdD+5sf/mtsVCBKNbxsDBvKA8TmLxe8Lsht7S6wdIIzRFz5Oc6Yp+QQjw0FI+j+zyjAsBMsu1cuPX1KGpt7yyfL9jNi7hVaihGQbk3O6orCR5S+yQqGzvFMgcc4UY7UcLelVI2pP9BBb7CHvSQk65pTnyScJ3H6XHT5lbSbhJgecG2E/4obIZMFSyI6q6LxFMjRjDAeMhPPBvisR+T7wpWHAnMJXhArjV9xhT0bvRdGDf5cgoyeekiI/MiRwFl9jzNpZzLTzytTaFe0daniDSElf+SyggmRW4WmWUREIjgVRcK0G95DvbKxdIXaz5x4xjfdW7BwCQF/wZ69kykTmaQ9ouVVXbcfxQAqDual+VKzpeNDlAYMF7ex9F4WpkhHIBx+IpklhYwv2VbS7FeuJXi9eE+4Myvey6Hh8JFlFLlbzYWT8nM/T8eTbrz1ee8hRjAIKe/SyfuQPbq3fddOMP0EGiCPUp9mPNAJngC9HEX4/yDwvH/6lUXUDASs0sACsY0TUepjpd/u2+pCJ5aOrG3uIW0P3be469zgIh5YvK1Vr6DVhZMf9AZIIdZl/6f1ckvvWbAlS2gq7ZVS pJ6BW/Wd 0ET7CC7T4Xbafcorc+YV+fdreQNdCcUxjXCmjovud3MBwgnal+sO2q8V5AgcBP05PYAnN0fROLPgXa1f/ur0Q2DI6d1y2zQMw4u/xjwES114tXWKAXxIRxfcmGwzYpT180sY1ejRgsAE8nov+GkHeO/WHUBHj/jIu/nx5bDRcdxa1/t5gGHdJogYtEDjREvDxZnXxpfwwzLGPZjzurSRrxVvqwB+TkJK8K9+dRfM2+DcTU1COC31eID5COkCbkaU3+Vs8t9aXvVslIrdpYal4Lz7SrmRruQkN7a3lzURfQLfjIi8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > > The buffer_head submission code uses bio_add_page() to add a page to a > newly created bio. bio_add_page() can fail, but the return value is never > checked. > > Use __bio_add_page() as adding a single page to a newly created bio is > guaranteed to succeed. > > This brings us a step closer to marking bio_add_page() as __must_check. > > Reviewed-by: Damien Le Moal > Signed-off-by: Johannes Thumshirn > --- > fs/buffer.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/buffer.c b/fs/buffer.c > index a7fc561758b1..5abc26d8399d 100644 > --- a/fs/buffer.c > +++ b/fs/buffer.c > @@ -2760,7 +2760,7 @@ static void submit_bh_wbc(blk_opf_t opf, struct buffer_head *bh, > > bio->bi_iter.bi_sector = bh->b_blocknr * (bh->b_size >> 9); > > - bio_add_page(bio, bh->b_page, bh->b_size, bh_offset(bh)); > + __bio_add_page(bio, bh->b_page, bh->b_size, bh_offset(bh)); > BUG_ON(bio->bi_iter.bi_size != bh->b_size); Can `BUG_ON` be deleted now ? > > bio->bi_end_io = end_bio_bh_io_sync; > -- > 2.40.0 -- thanks, Gou Hao