From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 026F7EB64DB for ; Wed, 14 Jun 2023 13:51:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5B73D8E0002; Wed, 14 Jun 2023 09:51:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 567846B007E; Wed, 14 Jun 2023 09:51:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 408F78E0002; Wed, 14 Jun 2023 09:51:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 2FE9F6B007B for ; Wed, 14 Jun 2023 09:51:54 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id ACF8916065E for ; Wed, 14 Jun 2023 13:51:53 +0000 (UTC) X-FDA: 80901491706.07.DFDD6CC Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf11.hostedemail.com (Postfix) with ESMTP id CF6454000B for ; Wed, 14 Jun 2023 13:51:51 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=UEIirlFb; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf11.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686750711; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Pl8MPcX5hXhgUFwcCBkp50+h0vPdfwPV/anK0FYlzDo=; b=iQ4AcCLDBHgmK4rSIvZoeNXWphxJlLz7wK1Nagm9EBMPsW1RbVDI6u0encwKv6WSqVBE71 eO6a97wg90A1mlgstcLLMqJ9rcjN9tGY3CeGsiCTjfp7+DLV09Dl0hDaBI6kt+XQizMT5Y WxcbfygEZrH/ub0lwmlij5hlXGPwTHo= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=UEIirlFb; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf11.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686750711; a=rsa-sha256; cv=none; b=kyMWOk9OUI6kjDMRxolpkq6QdXMScBiis4xsiwXzQ+IRYyW9rjiePwA4amY5gUKPXoIkHs uwT/c5NGO6xe4v3CzdafA2wHyFe6FGS33l3/18EH2n3ec75npZcBx69f185bS5k4Y4cDeL dAmW7u4JgqINjvoopXNgvMpFTijAU48= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0D0F86371D; Wed, 14 Jun 2023 13:51:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7653EC433C0; Wed, 14 Jun 2023 13:51:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686750710; bh=MAYhMoo3f8WL6wMqKE5pm7ocfhsiks+frK6iH2blioo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UEIirlFbT/jXJvHUAqdydA59j1RgDZUUfgyOKgwNndXqGOEHUHhZfOzL8/NQgVHWq /q8XC8zbUoWUdbEY52nA6n3QMoY+5uT3nVSo46hX3ckloa8Tsk20nvsFk+nFyI69rq kqHKU2qNg4cLDxDKYqW/CF0jwV3eWOULQ1qERJP4E28CBFcj6QUn7snwpsx+9K+Qu2 POIbcaK1ERRHtrayBYsdhpVVMqCnIj3U/FswN9W3HiA4Vsg6KhJEbi7yWjCVgy7Bim qkQ5e6uOUhmZCAZAp2Mldqm52UMAWsfOcJWE7Vw1mqKjcEoYqpl1pq42H9ff1U9Ztz NxXUpOfWIJH1g== Date: Wed, 14 Jun 2023 16:51:12 +0300 From: Mike Rapoport To: "Vishal Moola (Oracle)" Cc: Andrew Morton , Matthew Wilcox , linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, Hugh Dickins Subject: Re: [PATCH v4 06/34] mm: Convert pmd_pgtable_page() to pmd_ptdesc() Message-ID: <20230614135112.GE52412@kernel.org> References: <20230612210423.18611-1-vishal.moola@gmail.com> <20230612210423.18611-7-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230612210423.18611-7-vishal.moola@gmail.com> X-Rspamd-Queue-Id: CF6454000B X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 9ayphtgkmjwekgzgf8x53e56hhy6io71 X-HE-Tag: 1686750711-922314 X-HE-Meta: U2FsdGVkX1/UbsSrHyqvQQx71XBXFvkIpP/Tjhf8VmkIBVGYtcdtR3YUmy3Y6McK/CqvhY3qAWhl1GiypdipY3mB3FgLoeu9I0LkwJ2byO1pFqpSxhzw2plduY17YQCni2daAwQHuDzttzc4iNcwODZ+gxtKEohJtRhkzuabbTWgnixR324st/mbBdlOOHDqfQ5iiioEiMYNNhHCBpKPMV0U6GyChn7mJoxBk4501bQG9nKRQjYbHMAZGs3uswFoK9lxLJ2GtJmz3ddBTmj+DsubW7d3fZoja65Dkipf4xNNl8wnO1voVLPVUjz7ElcF0W4bK0TB6gRyz61XuAe5MdlRzw4K6lCNu+m0ocx1wfxF8QiR2CWBj4uIcTqIhYAULJ6bAQlA9V8FrfwTzlavNiFZ/zJyPfaMAJuUrBynKz5Cukoajyp9QKwC3PSJwbplq2ir6mRe20IswVEiIMmTpeoaCgCs+WKfgY3GNJ2fCpyNQdvsyktMNgseetT4X5teimp+qJRgD+uPHkVav7v5QFbfTxSzGRqQk+tULS7NbR+yL+bVUgljNksNrTQDANiqXzeoj0Zv06tqGVu1Y1LcAUhfuT6Vz35pmm6Swcexr70ryt7C1k/WYYCKmS+EQHbWy6hEjHOlrlZJXHeJeLcvD4TFQzic+RmRyucwieKzK9gVUl1zEDRymXrbMeay6ezXs5egUTzTt+uk4PrNnYvZpGEMs9uLtHWgAI2f/q4ICt5PIp73vHlr7eJORtWgTWVnLJMLabt6tIi2SRiLNZr6jfdxl5Llj5xChFYKUt+s2ylaRUweYbE0iHsWsaRR0LjgBRX9xUfi/ETNk/hrJu0NYbofm02+a7iHACAffYHaU7jpu6SwFO4p2kXrW+/J88zntzNGGUthhFypZy/CCRR0Zx/p4hgqmQBmlwO5n62notx/KAe2aEaOTaOEdbJpidjOJmWed0xSZtREfXfAuZq iUfeHbHe 7M95UrDGV1v+TA8TRnuYg/1YPtsfTGw4MyuX8CctXfMz6EMFzppBsphuuPYs2wfxw1LF+czzQOdLXEDxNIdFiXKCnqmzPUcit56+KCcNaOtcEsF1RHbdjPNaWihac0Jc3X+EvsL75wbt/Bci81+SFHUC/snR/4nvbAZqaeD3x4HLTNTY2v5OiQZMO8eLKlO7rBElwLMQLUa6WNXmcncRezoReN9zy7afFJBo3mMna7xKD+esvqD5+P9UI0DDG3q40r/ytCzkrzYOCFCMmhEAiCJenJV2E7uAr1jBu0kK8cwMNyAVyDyQ4sfmU7FpUIeVj+qdfS7FbKNCoXkt/qya84d/opPg/kJFOWgEE2wPUHwb9khtn33Dz1K8u+7wsFjZtqHBSVY9vvVYB65MkckF7IyNSYNJeuzbOlzdZe9KH6EordVijj0LFkk7qH4cHHnSM2P8v0THq0PP+QB8tNVcqv7wgVWZD8sFTMEsh4qYZtjav4xk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 12, 2023 at 02:03:55PM -0700, Vishal Moola (Oracle) wrote: > Converts pmd_pgtable_page() to pmd_ptdesc() and all its callers. This > removes some direct accesses to struct page, working towards splitting > out struct ptdesc from struct page. > > Signed-off-by: Vishal Moola (Oracle) Acked-by: Mike Rapoport (IBM) > --- > include/linux/mm.h | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index f184f1eba85d..088b7664f897 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -2931,15 +2931,15 @@ static inline void pgtable_pte_page_dtor(struct page *page) > > #if USE_SPLIT_PMD_PTLOCKS > > -static inline struct page *pmd_pgtable_page(pmd_t *pmd) > +static inline struct ptdesc *pmd_ptdesc(pmd_t *pmd) > { > unsigned long mask = ~(PTRS_PER_PMD * sizeof(pmd_t) - 1); > - return virt_to_page((void *)((unsigned long) pmd & mask)); > + return virt_to_ptdesc((void *)((unsigned long) pmd & mask)); > } > > static inline spinlock_t *pmd_lockptr(struct mm_struct *mm, pmd_t *pmd) > { > - return ptlock_ptr(pmd_pgtable_page(pmd)); > + return ptlock_ptr(ptdesc_page(pmd_ptdesc(pmd))); > } > > static inline bool pmd_ptlock_init(struct page *page) > @@ -2958,7 +2958,7 @@ static inline void pmd_ptlock_free(struct page *page) > ptlock_free(page); > } > > -#define pmd_huge_pte(mm, pmd) (pmd_pgtable_page(pmd)->pmd_huge_pte) > +#define pmd_huge_pte(mm, pmd) (pmd_ptdesc(pmd)->pmd_huge_pte) > > #else > > -- > 2.40.1 > > -- Sincerely yours, Mike.