From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A958C001B3 for ; Wed, 14 Jun 2023 13:52:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CE4158E0003; Wed, 14 Jun 2023 09:52:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C931A6B0080; Wed, 14 Jun 2023 09:52:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B5AF78E0003; Wed, 14 Jun 2023 09:52:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id A239C6B007E for ; Wed, 14 Jun 2023 09:52:19 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 67A741A06AC for ; Wed, 14 Jun 2023 13:52:19 +0000 (UTC) X-FDA: 80901492798.01.CE18BF2 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf01.hostedemail.com (Postfix) with ESMTP id A012B4001C for ; Wed, 14 Jun 2023 13:52:17 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Pvu46WaE; spf=pass (imf01.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686750737; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3IIUTZzBuNMibaAeStxjGmVLWzR5com53bYP8jz+tLI=; b=q2UiuwAoAkUjQafiNiJ5d0UZ/hJi8g3g3Co6eMGG4sx9QVjnvzYjp2d4zdjueIraJg9kF1 On0yfQwLiBuMFStOrbZZLvZvPf1STD7HJiDEzSfZfGAwhE7hIJiPwzsTcz/xpV1kowEyoF v+Mro063YvvCY++Y4Idfxbi8Y8Gldb8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686750737; a=rsa-sha256; cv=none; b=WI8mdU3ZegykNQ8WS/cVU5+MTtKg0owuTLv8ttL36Zhqnz832OUa1pFkP9wjlOrgNS97TA 7UsoEm6hs4sWYv+oi3x7ydaARHiKMJPv7PygqzqN1Bb43qqhQcIrrKPyhg/d07jFfd5wTO gpytCUzRx7JdPWli1KwieZFRXCCJNlc= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Pvu46WaE; spf=pass (imf01.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B94836426A; Wed, 14 Jun 2023 13:52:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 57C7AC433CB; Wed, 14 Jun 2023 13:52:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686750736; bh=VwaE4ixu2oYgT8bWCqZd/sCxt5Vr7LA6FKY2uA7+iKA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Pvu46WaEl54YKxvYrg17S6Us5Z+6jc6ZyxloGDXNG3sVbWCAn8khJSWsZ739VwfPP KwSYnW5Cb22U/hoqAU+3FM5yWaAmL/GvAe5O+LdrEw3/pZtxxI5c7cLPpLdtEqXk8T Fbh9NCB++t1sBODF7SprarK+tEpzTtUTE1tfwFFFrABefWFeIYBfx1eKkeOd7kHivF njsBTw00M7iYLOdiQBjB3A+VyNpSzWxaS2T8NQnbhp/VhP28ksnHBcMgphMjijMkdr wBr5rhU0/C9m5DU9+5BLMiU/dcdSlTsxTG9cV+YRjI8bVXWZYj/RDtOKkEZB/GxHIp Of8H4nZJFOgvQ== Date: Wed, 14 Jun 2023 16:51:38 +0300 From: Mike Rapoport To: "Vishal Moola (Oracle)" Cc: Andrew Morton , Matthew Wilcox , linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, Hugh Dickins Subject: Re: [PATCH v4 07/34] mm: Convert ptlock_alloc() to use ptdescs Message-ID: <20230614135138.GF52412@kernel.org> References: <20230612210423.18611-1-vishal.moola@gmail.com> <20230612210423.18611-8-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230612210423.18611-8-vishal.moola@gmail.com> X-Rspamd-Queue-Id: A012B4001C X-Rspam-User: X-Stat-Signature: ma8z18b63cxxcqomdxnje5kqjtbs7zjc X-Rspamd-Server: rspam03 X-HE-Tag: 1686750737-173403 X-HE-Meta: U2FsdGVkX1/3wBdB0nsGJ+9a1qoTRWVglshY9MSP8rTwzqVTUsQpEBql3bTKsduXOnIDllAaNpSjX/6JHy9infcmd+NFHfG3yVHSWJlqQlfRsdvaBpUdaQ65DEu3GgWwTOTdv57cYY/hRx5E9QPwW4NPr0/32lnkeqquiwfmRXsqSJrJc74TL6orz4dHr4ReQbCs6Rztoy+1U0R/ej7c1tCt8x1F4QYm7GvoVkDZYG2WSbdbUoPPvxiwN0wTUxGsak+SOZL5PrNuQbzB8Ll3hzKl3bVKdhvlrXktrHP9vxi+Vq8VBO/wzQAdE9BIa9xYCkqdwoIAXLkXRpmeTUeAlEQeJnLT9MozloZ1/lA1Cb2hzd/KI1QM2ZcJeTR9sui3QE0uQ1Y7EUcBkuPeucYwBkLHGtxbQ4A7q2rTMaDESU+oUD0JoBqaJOkEheTRW34Pq9ouNr68ekITrX6QD3Rx4uEmVKZn0hLF5h3Q0EC0iGn24ZBTDYiCJ+yaPQyeu+8owU01BQnGu9JO/2MTPIauNky1Pm8zTofOfwKz30zkrzOenFmoTgW4VKuuNKUh1usGeVKrLDJiKNasRkjEc/+WABHArZLP3pqHCXlS8Mf/jb7OnZ3qaVvaRYGSVaphnvhk4JqGydr2s6f/YazfHgpOT8a+CzuPrdRUNNvG7dc6AWUD1lVIhgakAZQdhhl2CoP/1t9miBy9hsVPziDeH7MpsOt9KS7pstgvzj73GOaoQqVxnXNwQ57q9pnSSgb+FLC67ZkQot0Rrvu+GYuQQ1q2VxG4YC7bGFWDP92N051VWDnoG5Z053s1PrRrwR6AcbzYElmZ9AgXuCX9vMKjwSPuxLzUhfJDbeiF7Tm3brWE98mk+sjopuxGdtI1DAjQvb1L7WEEcGazAzTpOf/cSws47YnMQBfwHXqbIiuHehYeiSKUwSv+Hk7yxKOxkN6T15onknHzeGM4A9sPYxs6npk 1AWx4KwC s/F4GTM5JaoQBomRvcHCVb/zmEe2suV8Ftylt5S7nBJHgE6BoTBBm1AzpBe6O7f7jYOQJu07jYgg8kiu2T8KeDl7Ib2wZjAFKzl+rqRCGmAhsr0gaM6EljRjKIM97AHB+Xdv1Lt7zyqYQNCeSi6w1n/KaYAPTgVGiE084PPMZEhIQpkx2zJXVGE40zVJDP93Ggwe+LiRgB7h5v2IukABLTT1VnXS5FfQiQiZyrOZ4hvQ6yTcSZMbnqjW8iDhjitef/J/tIl4d9Ax6J0AzrXZbBizKRMQRRJZik2T8SqsUPCLF1gQjZhLznYuBRQQoJCCtfcdY42aObfB08d7hlM8aGjRHmDED6qiiD3CbDJM9fz63DBlS2AEGLw/txRT8MonXvEW8ua9b+9i4GMmwohZDT+xx7Ed+qj+x7CySPcMIEJOLe9bevAHww7pZOC5jLIUKdYIn+uLSkGvof1tYxKfsR7f7QEn5MJ8b65r4EhG+IqD6m6I= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 12, 2023 at 02:03:56PM -0700, Vishal Moola (Oracle) wrote: > This removes some direct accesses to struct page, working towards > splitting out struct ptdesc from struct page. > > Signed-off-by: Vishal Moola (Oracle) Acked-by: Mike Rapoport (IBM) > --- > include/linux/mm.h | 6 +++--- > mm/memory.c | 4 ++-- > 2 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index 088b7664f897..e6f1be2a405e 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -2825,7 +2825,7 @@ static inline void pagetable_clear(void *x) > #if USE_SPLIT_PTE_PTLOCKS > #if ALLOC_SPLIT_PTLOCKS > void __init ptlock_cache_init(void); > -extern bool ptlock_alloc(struct page *page); > +bool ptlock_alloc(struct ptdesc *ptdesc); > extern void ptlock_free(struct page *page); > > static inline spinlock_t *ptlock_ptr(struct page *page) > @@ -2837,7 +2837,7 @@ static inline void ptlock_cache_init(void) > { > } > > -static inline bool ptlock_alloc(struct page *page) > +static inline bool ptlock_alloc(struct ptdesc *ptdesc) > { > return true; > } > @@ -2867,7 +2867,7 @@ static inline bool ptlock_init(struct page *page) > * slab code uses page->slab_cache, which share storage with page->ptl. > */ > VM_BUG_ON_PAGE(*(unsigned long *)&page->ptl, page); > - if (!ptlock_alloc(page)) > + if (!ptlock_alloc(page_ptdesc(page))) > return false; > spin_lock_init(ptlock_ptr(page)); > return true; > diff --git a/mm/memory.c b/mm/memory.c > index 80ce9dda2779..ba9579117686 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -5934,14 +5934,14 @@ void __init ptlock_cache_init(void) > SLAB_PANIC, NULL); > } > > -bool ptlock_alloc(struct page *page) > +bool ptlock_alloc(struct ptdesc *ptdesc) > { > spinlock_t *ptl; > > ptl = kmem_cache_alloc(page_ptl_cachep, GFP_KERNEL); > if (!ptl) > return false; > - page->ptl = ptl; > + ptdesc->ptl = ptl; > return true; > } > > -- > 2.40.1 > > -- Sincerely yours, Mike.