From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C83D3EB64DB for ; Wed, 14 Jun 2023 15:20:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5976C6B0074; Wed, 14 Jun 2023 11:20:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 546EF6B0075; Wed, 14 Jun 2023 11:20:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 40F0C6B007B; Wed, 14 Jun 2023 11:20:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 344FD6B0074 for ; Wed, 14 Jun 2023 11:20:05 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 1213B1606BC for ; Wed, 14 Jun 2023 15:20:05 +0000 (UTC) X-FDA: 80901713970.04.4449E99 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf26.hostedemail.com (Postfix) with ESMTP id 931C314001F for ; Wed, 14 Jun 2023 15:20:01 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=gpQZOD1H; spf=pass (imf26.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686756001; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TNTFAt1EINxKFH+vFY4rY7jhEIBk5DcQ3kqMEdbvUY8=; b=ng+ZPN308TsP7B3KFVeaQpFdd7LGuwXpjbnyMej2gZGYflIm1ptEtd+xSm4gOJ/AVx+hgc fr7czDe1E39fjwLaSaQW2h3g4jI0LOlMUUPKWP9yskoSKc8elZRnjhfb/qp4o6RC9RpyJZ 2OtfHJCrWar//WE8MKDp9sHjztgP4MQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686756001; a=rsa-sha256; cv=none; b=FXCzr8Dri7KnXiFkSrhV0EXFY6ZeEgqMKQ657IQRfR4XGv65bAD6SWWfDdBlVsoNke1n05 1TPIRYaIPozQH/iUBfp5f0Ab4jyR/exGUUMjd+Kk9zVg5xUODne3EdjyE1iCixhS543+V4 T6rGbnFAH6vuMflVY1jyHLKhfZ8KVYI= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=gpQZOD1H; spf=pass (imf26.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BD89F61F65; Wed, 14 Jun 2023 15:20:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9DADCC433C8; Wed, 14 Jun 2023 15:19:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686756000; bh=pvs0YVME2yJhlMmiS60aNyWkmP4h1eZnbjNjnr8k7aE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gpQZOD1HFnMrM9fo4KdT8pfiKgkiDnXqITSqdsPxwtYIOIx2PBHkeiXHNgWscAcgu 7Ludmi0rX4hJke5WXXLAQEn2uCuzmmwp55/iPdSkzGfbm3/7b6D/ARVdqBcqHg2PuT IpiZPKRPo311M/7dwEqLNTB4eEbaoSqrCh9SmEM/Nh700FMYjNTJ646BJmkGOl+ViX wyn9wHmVrmWWVolNGJf0+VJI/kXJrLoD+WGEjfmqa8ga4rLQqqHlxKBhJuM4wDRcU2 FeUYfth8UqkvYnAB19GLBf6adak/YgfNGfdLVnkPWuFE7ylBYlwtenSYSzQgRBwuNz fifauRpCnWIdg== Date: Wed, 14 Jun 2023 18:19:21 +0300 From: Mike Rapoport To: "Vishal Moola (Oracle)" Cc: Andrew Morton , Matthew Wilcox , linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, Hugh Dickins , Yoshinori Sato , Geert Uytterhoeven , John Paul Adrian Glaubitz Subject: Re: [PATCH v4 30/34] sh: Convert pte_free_tlb() to use ptdescs Message-ID: <20230614151921.GC52412@kernel.org> References: <20230612210423.18611-1-vishal.moola@gmail.com> <20230612210423.18611-31-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230612210423.18611-31-vishal.moola@gmail.com> X-Rspamd-Queue-Id: 931C314001F X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: ppy45jtpets4mowtkbxzdrwxbm797zz8 X-HE-Tag: 1686756001-935466 X-HE-Meta: U2FsdGVkX1/OlCZtz+lvuC3prb+CGVMh2vYQe717ODrEpZgulAIzrTQCcsl2G9fbNdqkgZ4/uuB0hEKnMtZFWMnJyth6m3d7soK8NTt/E53OjSbBxjLYdwwE6bqZ41jvZc0BK6TPUrdFN7aIGd35MNri0naedsVVwuajjhVZvcaEMWPYN3Y5mJp5EmP66tdTvG+U4IJCghcLszXkDejA7EbI3hKndTQtEIOa6MwZhOTqa+xicmRdpr5p5nGR9lkYnpoymTrHDqLsDrGGxA45j+06Bns50nndReTV76aypOUPcapy/hzPBro9nV+5vIbIPSYCa+iQPG+PNhGzAVMLNhO1BBJU4I2NH1OWp/LfEZWhTYQAxahVcGl2w2z7JjedDkC4eTP41euDIs2S7/2PcQPZWzvwEbdeJUK9nzbdWdTsOPp2Mj/dDde/cUE6Xtx7K9na+Fq2kNrOYyNWvnLjad/Aes2dT6NKBgQcf0abGJ0vxmE9iqrJ31qx+Z/8cc/9M+dKtw+qXax3FbnK9UKh/JzfNSsQRaGRpc4Fhly5TNTCxtW2IZlg4lTzcwjlngVPCkDlHNK9qRSApz8tfiXOXJuCrDGy7j/tSdpvNWtWfHOWJVH4rWkxcXz8Dnof/eiF0KgXKETjd7DyaHfHCK2bsjhhkvcEEKHVWs21PpYfFiwa9uHotSOYDLZ4P6JAjUHTwudUr0V4ro9kUk2ITNmdtRPk3axPo7P6glD8P3sme+swDY42ervC4w189OhopXO/1nLtG/UxpfM2wqp20oeoMVTuTO6eQvcgNYckvKXt6pcA81vHcudqroMUJjstm734dsP+MbKCGJgEToRxZ7SiyOJ9lSE1kDcmjz6BTYdSG9Z/eDLHxN+BspH+3mWX/mKMUKbRztwitxEXEj8/5Eq4t8Fu66RB+Gf4+oduteUsynwQvAOEBfNiGxT3dd0yL9iopxkE2n0BE/T0JMobTWG M5H3xt7i 6A1KzQrOiiR3CJrhbAyN3C0jYd8dSPFFEh9SUl9zIo+jL+ePpX3+zSl8mqGMVdfZAa/kifiN+i/Y7tP5lU46sE+V2DCMmwNKu+SsF6+6pWo00+FD8ME9DiftkUr2bw69s9XKv0GaLzy9hgkDieZWW7mDEMiFdpeLwkUsY3dk2WjC/qzLUJcy9jl5PIU1Q0HqBTTS78tsG9Axfc+R82fdGY7WLF1rmeGvpYd0i4wSk0Zhf/N6g/7R8JnrseTkNwEfkVZb2Kt3zj0valKo30NLJoGEKKOC5ifq6E6JNhKofQg2vOrHc8hsCFvri4DRIn4tdoZgRkEML444704iJfFpZmZn1zI4H7Fnfl5y9WTk5dZtcSYTneBy6Ey0XzP2JHkFyaTBDh9bnQdLMNOs5QDrLBxqwqq4kqycXbAXHRGn82v1NcpTgqH43LxbXdf4WHRsOf00NdKGT7F56M5AeOPhjLnZ4T4mwgh+2+iELEzHbOP5cZN3yWIw7PNmAXw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 12, 2023 at 02:04:19PM -0700, Vishal Moola (Oracle) wrote: > Part of the conversions to replace pgtable constructor/destructors with > ptdesc equivalents. Also cleans up some spacing issues. > > Signed-off-by: Vishal Moola (Oracle) > Reviewed-by: Geert Uytterhoeven > Acked-by: John Paul Adrian Glaubitz Acked-by: Mike Rapoport (IBM) > --- > arch/sh/include/asm/pgalloc.h | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/arch/sh/include/asm/pgalloc.h b/arch/sh/include/asm/pgalloc.h > index a9e98233c4d4..5d8577ab1591 100644 > --- a/arch/sh/include/asm/pgalloc.h > +++ b/arch/sh/include/asm/pgalloc.h > @@ -2,6 +2,7 @@ > #ifndef __ASM_SH_PGALLOC_H > #define __ASM_SH_PGALLOC_H > > +#include > #include > > #define __HAVE_ARCH_PMD_ALLOC_ONE > @@ -31,10 +32,10 @@ static inline void pmd_populate(struct mm_struct *mm, pmd_t *pmd, > set_pmd(pmd, __pmd((unsigned long)page_address(pte))); > } > > -#define __pte_free_tlb(tlb,pte,addr) \ > -do { \ > - pgtable_pte_page_dtor(pte); \ > - tlb_remove_page((tlb), (pte)); \ > +#define __pte_free_tlb(tlb, pte, addr) \ > +do { \ > + pagetable_pte_dtor(page_ptdesc(pte)); \ > + tlb_remove_page_ptdesc((tlb), (page_ptdesc(pte))); \ > } while (0) > > #endif /* __ASM_SH_PGALLOC_H */ > -- > 2.40.1 > > -- Sincerely yours, Mike.