From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 440CCEB64D9 for ; Wed, 14 Jun 2023 15:22:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C9A826B0074; Wed, 14 Jun 2023 11:22:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C4AEC6B0075; Wed, 14 Jun 2023 11:22:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B3A5F8E0001; Wed, 14 Jun 2023 11:22:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id A488C6B0074 for ; Wed, 14 Jun 2023 11:22:06 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 74607AFDF8 for ; Wed, 14 Jun 2023 15:22:06 +0000 (UTC) X-FDA: 80901719052.26.A45C73D Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf14.hostedemail.com (Postfix) with ESMTP id 99BCA100011 for ; Wed, 14 Jun 2023 15:22:04 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="haxUs5/r"; spf=pass (imf14.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686756124; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qSEflu2FzUqsBRRnRTcAqlXFoMdLAY3I3fjRwZpP4nE=; b=kpe1Dy7EHRqNLqzlZA8NLIM8ZqZkHXoWs1vdSF4RVmES5xiX6h3qqCo9sNSz/+WzQ8M654 Xz2w5Ux3E7Sc7No6U98wiQAAg7IGXTZJL0nIzvGVMdPfoCKqup2OFZwFGqw2PVgB1echz+ YfWKMI76lGqcnb3DV6IHVLTMTOZ/CxM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686756124; a=rsa-sha256; cv=none; b=XkNegqaVX2+UtlrtNd+fxyaVtvcokxMsky5Lscg1zt8BKb8+UMamrEPNk0R5p2An87PvZo XGS3zJhCabBmKEEzRnylbLvMEsErz/8Jv/TKnYu34XZsF1GAtT66TYQ3L7uN6fAFoOd9d9 ioThNrnAYBzuDfle8G0qfEQwc5LhRxE= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="haxUs5/r"; spf=pass (imf14.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D3FB163FB4; Wed, 14 Jun 2023 15:22:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CB0F1C433C0; Wed, 14 Jun 2023 15:21:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686756123; bh=JJW2yi8jE1xj4PNXmFMp5BSxmEmVsW21Z/BKD3ijRqA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=haxUs5/rQ77/llId2yHHxl+zVtdTrLbyvMnIz3tsRFOuBfKBsufDFPpl6sJMFJSpX XdXGa/cXbRpEhaCxlcG6vxqZV4ZzAZgnbLFIXOUhwM8Ua9bXir/zJSNTjBAjZ03+JP UcP/tVhaYEkS/wXO6HoiCL3DGRWNQpiMx2frieXMXFBs/EuOP4yKcsZnjumnh7yMwt mljclEUSRo9j+Uj9+qbtKqWdq7GxEjZQSCnkNZEtTei1kMdLBLTj7XgI45NhwTOXr3 4sBfJLEgvF707hwHqU6mKKWZix4M1FcPGJaAO0WdwWeDGAbdHkQfY6WNHFdb0Gm/o2 ZyO+xqT///0Fg== Date: Wed, 14 Jun 2023 18:21:25 +0300 From: Mike Rapoport To: "Vishal Moola (Oracle)" Cc: Andrew Morton , Matthew Wilcox , linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, Hugh Dickins , Richard Weinberger Subject: Re: [PATCH v4 33/34] um: Convert {pmd, pte}_free_tlb() to use ptdescs Message-ID: <20230614152125.GF52412@kernel.org> References: <20230612210423.18611-1-vishal.moola@gmail.com> <20230612210423.18611-34-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230612210423.18611-34-vishal.moola@gmail.com> X-Rspamd-Queue-Id: 99BCA100011 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: wkarttdr8jes9xon5qcsa1f8jdr155yt X-HE-Tag: 1686756124-249556 X-HE-Meta: U2FsdGVkX198R5j9AyGmg/CmEOiEiaZyIGptbOIoOjZTUt/RnGB2YZNTrwqg3kQqb2dKQ2RJe3or2flMA5xN2aDSrlcNGwKTtFYq+O75uB3f87VzzKn0UF+J4lK/AQzImx3Yp+R1eAJGwsksOcgMh1y9iFOz25I3veKPj05g4SBpnwuyV7fOKQpR60wWKjjEFrBs4YMBOYtMKSr+mVrP0ozq2qgQh4aJ4YHkonzZgemhPyySiBEq9GSV9F/i0KfKTVScWQquRQ48NE2DZrdC1iMljf5sUTw3Gw7em7Wb3R/L6AjnhA4QLQBOwQ9z4LVZBWMQ51iAKqYoi4ECdCegA/431BLQNyHcN1ENfJfCZx+EPgjpQl1W4mmjMoUuyQ07peEd87z7Rpbyfjk6WEsGH+q0s/qKfcf3WxtDNHegfBzTGg6mDnEIgWhU/u0JvOH+nie8i0WdFORXtnreMmf1ae8NMmo04i/VzF45LSN7L1uzN7iZasR0IyvWY40IrC375ftwgNfc4BUfMDJgttu+XKg5BRut2SuhyG3dtSDAplNjwFnu49x3UIIY1muC7PeWPVM1DcPxXyUTZ/JBkDBIwgTAlJbvD8hbWrT1qZLYdVX0+yC2ORL8w33Bd7QcS1vfwDRh62tCrcRDBQkEBmjJFd7TiHqDpoFTO44vPbBn6MYAsOX03qi2bgrtZbXJnqw2hxr19FwXK0EoiByyyMiLJ3jqNme/UunCkaiiueLcbQrR+Fb0B72F5423VNCO/xoqsJeG1LFWux1QWGPgihYnKe4qnppz2sRdnJphVAJfJLywgp+ZBTCEmA6rolHYR8mykN9kzDSEcP3VT8aVkDbDvlW58RnpdqjTm/n0r2gaiO9Pu6808DY72AQKCbZJapN+jtGSCwpbQjq5oGpu+rgREZs1ia6ytMB8vjV+v7Er3ZRkbkHtFLiGFvxqIqbSbgTP/SwpM/92T9PTlwHLEWk PmUh+fDT f3pBtwFsaW2dAMaV6z6bgEyAT9T+39YUDp6KREjyQ3l2/SYRWxjyrp7Sme5dFhteFiSBEnorRgizv7B3GbSldQs85EHD7DZrUZoq+c7oy22B9uSi4Avv7k7RXsz6qB7qrl1iR4wWll8+YDPzdYHK+202lKciwtew0D4hwgzWL3rhceFwSDtCIYPWTWgsyiAb+V/N6HWANncuU3elD6ga/cpj0abPy5JMM7Xv7+2m8fKhIdPjrrOPPh3qPPQMEdEC9pDycrn9nV+/o5OKSG0QOUs2C5CyJi/Y1p1BNTw7b/HSObvPHNeCuseUyykvd/c3awvLqr1uYdPpz4/cy41SJzg8pVYDDOQWqdLjLhFsPQn6EsjZzzHMkYihGS4ew3xma4IPjmwlLt4MGT6wx0CjbivCIGB/uoOjCDTwgUm07bVfOcA+ths+0QB4Uq13lAJqo87QhED6EUKh7R6I8n+9kgKQm1B6CQikBEF+ONr27FZbZY9Q= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 12, 2023 at 02:04:22PM -0700, Vishal Moola (Oracle) wrote: > Part of the conversions to replace pgtable constructor/destructors with > ptdesc equivalents. Also cleans up some spacing issues. > > Signed-off-by: Vishal Moola (Oracle) Acked-by: Mike Rapoport (IBM) > --- > arch/um/include/asm/pgalloc.h | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/arch/um/include/asm/pgalloc.h b/arch/um/include/asm/pgalloc.h > index 8ec7cd46dd96..de5e31c64793 100644 > --- a/arch/um/include/asm/pgalloc.h > +++ b/arch/um/include/asm/pgalloc.h > @@ -25,19 +25,19 @@ > */ > extern pgd_t *pgd_alloc(struct mm_struct *); > > -#define __pte_free_tlb(tlb,pte, address) \ > -do { \ > - pgtable_pte_page_dtor(pte); \ > - tlb_remove_page((tlb),(pte)); \ > +#define __pte_free_tlb(tlb, pte, address) \ > +do { \ > + pagetable_pte_dtor(page_ptdesc(pte)); \ > + tlb_remove_page_ptdesc((tlb), (page_ptdesc(pte))); \ > } while (0) > > #ifdef CONFIG_3_LEVEL_PGTABLES > > -#define __pmd_free_tlb(tlb, pmd, address) \ > -do { \ > - pgtable_pmd_page_dtor(virt_to_page(pmd)); \ > - tlb_remove_page((tlb),virt_to_page(pmd)); \ > -} while (0) \ > +#define __pmd_free_tlb(tlb, pmd, address) \ > +do { \ > + pagetable_pmd_dtor(virt_to_ptdesc(pmd)); \ > + tlb_remove_page_ptdesc((tlb), virt_to_ptdesc(pmd)); \ > +} while (0) > > #endif > > -- > 2.40.1 > > -- Sincerely yours, Mike.