From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B1ACEB64D9 for ; Thu, 15 Jun 2023 15:32:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EE6F38E0001; Thu, 15 Jun 2023 11:32:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E70246B0074; Thu, 15 Jun 2023 11:32:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CEA218E0001; Thu, 15 Jun 2023 11:32:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id BD2406B0072 for ; Thu, 15 Jun 2023 11:32:29 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 5EBEEB0272 for ; Thu, 15 Jun 2023 15:32:29 +0000 (UTC) X-FDA: 80905374018.04.C566A4E Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf17.hostedemail.com (Postfix) with ESMTP id 057C640024 for ; Thu, 15 Jun 2023 15:32:24 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Fl5x6BF3; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf17.hostedemail.com: domain of kuba@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kuba@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686843145; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=V9VU/d0odgy1gps/W+K3lro7yRAzqBPsay+P7LjLf04=; b=5eizVF8jUwNYdVbgz01jli/LDQSb2f5371zwcNMPVQPulUW+fwm3KjIm3cjKWp41aHIqN4 1ZLrrI+If5AYP7sX1U/evUSPEqV82zsJU9fnxpmSsqJcoNKzq2g975iIw31siTctJVwJIC u5SkEW2jnYcaj55TVnW1wAYVgWgOVdc= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Fl5x6BF3; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf17.hostedemail.com: domain of kuba@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kuba@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686843145; a=rsa-sha256; cv=none; b=YHHdCQHxmUWRxw2OpBCnZ4pIA0keINFDx/PLYnRkBL4DZtWnROulEJZRVqJFhMYyT+Z0zp 3jGXh9yhh00vSZmxBPbATQoEKxAwStNPGHFQpVuH7HMNXaEEUfO3NIQuRQs5fQJJB3FDri C9i/nVf0YyPHEyd09gxaRw2wnzT399w= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9845062598; Thu, 15 Jun 2023 15:32:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B749CC433C8; Thu, 15 Jun 2023 15:32:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686843143; bh=5SnATU7YmUxOsuenF/gejJC249yKQjYfPce/JOhUOWQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Fl5x6BF3ZWVLCdsRfnZDPwMf+Rqho+sOljaHwKieGLvj/epsiBM6p/IwzLENpvAP6 +J3ONH53Jn1cRaJ7a/cjZL99stBxCHywLr5TiCLvTed0Z5rtw0BB11shUBooaXIxJ/ FJ/3b1nFjHPTACkJNJKJvHZjEmrxkoKTS314VBMBfs0LuXkXzz6OtQEHbwUNOAa5Ns vjdBPVh4VFH1h26YfpQmrZs3LJC060qJIZSTwX5MXtrD04voyOGp0uRh7kt3BPoozc coU1L10Lt352hfJnTkVo2vFMSlwYNXRTEYT+9uFAMmPwrk5GxYWxP4dXlvNV2x3MXk i3nBv6jWZQJQA== Date: Thu, 15 Jun 2023 08:32:21 -0700 From: Jakub Kicinski To: Edward Cree Cc: kernel test robot , oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Simon Horman , Pieter Jansen van Vuuren , "linux-net-drivers@amd.com" Subject: Re: [linux-next:master 8214/10326] drivers/net/ethernet/sfc/tc_encap_actions.c:277: undefined reference to `ip_send_check' Message-ID: <20230615083221.4ab529c2@kernel.org> In-Reply-To: References: <202306151656.yttECVTP-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 057C640024 X-Stat-Signature: a69p7dhwkdqcb4usebacrky8dexgin7c X-Rspam-User: X-HE-Tag: 1686843144-874364 X-HE-Meta: U2FsdGVkX188uiAC1gAZlztu/MREPoOqSpyGfJPrXjMDKAOojS4GVnms1r+0BvB9uXjoaPhoC/GqOn9T5JFqheNPoYjtH4PnEZI4JBaPNGIZvJwJEmL533Pumyd5BIekmq2iyN8CURXXbWsWV6Fn5Izkd8MOuCW0YJMFO/ojt7fQV6QWBYO1gOQ1BgHnzmCp8SpZA8aCq7wPOVNn1akzBpez3jXdQ+0cZa6Q46hIV3McbCYQhsHo+rNzXoAAMVVJRawTPTiplnLvoW7obF1sMoJPWBXfxGVoyR1FBfI8WlcActrSeZMlAhd3iSlvkgaZU7ctL773ikBm61HCmISScRjMTUDvYmmJUA9g4r2rNy3Jq9g0fnnHMBT8CQkWAbi0gWuPBN2w9d062wYqjf8EE9GJq78vJYcrkbCreFR1+5q3JigsO+qYYSCPiJTG6r/s6J5pu89BmW4n7Tro9bAltwH5K8t1PC8zdjtXOpGOfMdke67F/uqFFeqH3PZw8FYPPJkdS9tgsz4K1e2hNq4PMZqtHfuhWq+ko2a69X91jrJC5Lr92Q85aRsm1yTeA4Pu13xqCqeTJZEDiZu+jyeU0G5YCX345Sj9e/9v249zZ8jMhWaleoxss4l7sY2bbWsaUZNYbhaupNUo4UEKLIAkqfn0w3iZZHZ7AV77nGTIvKMR8ziXPNG1woc1etv4rJtrYqbCearRVOuHYJr4ss1MjZXUiyQqk1FrekTX9tm2M/4NMEhVLkXAmoYUKfr3DzeD43PPWKHB5dHKrPnH82H9xxNoOzh3t99AI/22iwSEadoJanOZVi6yv/5ponZs3nxFnUZ0zqVbDHevXEtUB2aTvb4+9IGQCzFpEt6vrd/4s+wbSoB6jPdMiAzBeKk4zynxs1uw6+hzIZi9pRZ7RjWXkUe1SnNMGRZ5dlYzcjDo9uQ2gn4A67QTYjLubyvOwo293cXS/9P5QIcHiTuh7Ys tpDqw34w RFCCMGXJ4BK8609FPeZxiIBQULye7Z6v+Z+aDx6FXXKD/MGhNJGJyXni+cQID0c9FyyXpsCT+QM86t9vYkqdJAWCiz9a3P+j9YwM4OYmKki+cImWGr0euGUTomToensevRdwI1BFh2jQC/TNF5ZaGf6sFD485CdF8umdTFPqOu9kN7bj7zP5BZSKSUA+V6BxuKLBj/W+P0AYP4l4HsEkNj6jX6F5EAGykxpmGZGYi79TzjfK009ubss45VEGykMG6ZtqzJVWGU2fGMnVuIwLAAJsswDxkPdJW3sfJUgTbjPRB3hqsxFtCgmPGlyjCATG0SYuK6q6yVmBUo6ZnHKAUz/7VagNKz3BIB50RI/CqMvuZ+h192l4bTJxsWnne/FDPHVAlBA+AQAra+kTxRFPBzz7jvkjnxOD9PdD1FcIaHIzrttP7IYWrp+hiBZgi4YMmW1/Q X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 15 Jun 2023 15:44:14 +0100 Edward Cree wrote: > From which these errors follow, since these symbols are in net/ipv4/*.o. > Not sure whether to put ifdefs in tc_encap_actions.c, or just make > CONFIG_SFC[_SRIOV?] depend on (or select?) CONFIG_INET. Because is > there really a use case for putting an sfc NIC in a box without IP? dependency on INET SGTM, FWIW.