From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC748EB64DB for ; Tue, 20 Jun 2023 12:26:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 42C3E8D0006; Tue, 20 Jun 2023 08:26:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3DC9B8D0001; Tue, 20 Jun 2023 08:26:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2A43B8D0006; Tue, 20 Jun 2023 08:26:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 19C628D0001 for ; Tue, 20 Jun 2023 08:26:29 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id B0A8C160D92 for ; Tue, 20 Jun 2023 12:26:28 +0000 (UTC) X-FDA: 80923049256.20.6F95AFD Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) by imf28.hostedemail.com (Postfix) with ESMTP id 79FE3C0005 for ; Tue, 20 Jun 2023 12:26:25 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=aGYV++j4; spf=pass (imf28.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.215.172 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687263985; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YImuaKwJli8w5Jc0qucc/OXXgqXxVo9Fj37hraT/kE8=; b=RECElNFa6buUjqPUcZfkvP1nSdqoU1ilbg3PKXQIhVSVtAm0hkn9CylIn2Sz+MInU9o/IT Ja/KQhleZcq9K8w8XE+upbz9mAwHxssfDMjPlxkl+io3NXdp2pQ+G5VYRbJIp2QpLtJIsc /fWOmvAZzYDwNWyA7FJH4EoL6pxTv4M= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=aGYV++j4; spf=pass (imf28.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.215.172 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687263985; a=rsa-sha256; cv=none; b=g2a5Xgiw1nJX1Cy0zGHBwAO6lvhrSvJkDgjAL0E4FEza/ddADSUeRvu0go/BTh3QEBw+vu 7C/59GNvyFCG55OSRBxlmth7Vo9uqZ2oVQw23oxB4TuWOAWK/vwoofQ4LgDP7r39cNbIO5 71PYe3s0kRm+hDXu70jhqhdpRKP7QH4= Received: by mail-pg1-f172.google.com with SMTP id 41be03b00d2f7-517bdc9e81dso1832573a12.1 for ; Tue, 20 Jun 2023 05:26:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1687263984; x=1689855984; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=YImuaKwJli8w5Jc0qucc/OXXgqXxVo9Fj37hraT/kE8=; b=aGYV++j4K4g1HLxiYOqB2PxK3oaMFwMs5PXWRsIriPKjhKCWKqvzwFbjqgLT3ex4uI 5hUVaPKZDmZdXqlPSP+G6OjnR/k/U7p2f7vcUUfaOtUmVheHczvsorDd6iNxF0eUylUk HLhuken06rXTO91ZZI1nOHNUxvTlhrf1QF0wk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687263984; x=1689855984; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=YImuaKwJli8w5Jc0qucc/OXXgqXxVo9Fj37hraT/kE8=; b=EwWNZGzZYLl3K4nGHCyi0PRoKxeqraI30PR4w11eoFJHRWrFIUJaOsPv+QE2VQGahe omTEnjH+XzN/a93GuMXlQVTcxgr5UDbtbTyZu6T9PANlHLYD0XuuqkzrPIUjoN6pUqKu HQynEKcTejNg/tjqH8d62N47FKJZEyjSrfhwbDQ3w87g40hHAIoJ1lA7AmATtU2uzJFN b7/jFIyjHw/kKayXHEYkr40ksMT7Iuw0Vtsdej6d8E7yySk+LAKgdZEzW3Xv+DXKMDAR Mf6zx5mRCWzRUrWdAsZw//brCDcKZSpZXwzY/KvgGQhuDRxxVBimnFTV+SJWZDUyAd73 PDHw== X-Gm-Message-State: AC+VfDygjIDGxsqQ5xjIA9Pn76wdBwkzaBhWAoYIxSgcpaqvcp4o/f1Z lDZvLHIl92rmHgZFKBsNePAaOg== X-Google-Smtp-Source: ACHHUZ7lOqspC2zZWLV5QrHY1urntQC6A6009Xn32WE7AxTMD2fVpZBZ+51jzrVil7mixgl2V2fpEQ== X-Received: by 2002:a17:902:7409:b0:1b5:e38:7bbe with SMTP id g9-20020a170902740900b001b50e387bbemr8955766pll.1.1687263984114; Tue, 20 Jun 2023 05:26:24 -0700 (PDT) Received: from google.com (KD124209188001.ppp-bb.dion.ne.jp. [124.209.188.1]) by smtp.gmail.com with ESMTPSA id a7-20020a170902ecc700b00198d7b52eefsm1506809plh.257.2023.06.20.05.26.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Jun 2023 05:26:23 -0700 (PDT) Date: Tue, 20 Jun 2023 21:26:19 +0900 From: Sergey Senozhatsky To: "Liam R. Howlett" Cc: Andrew Morton , maple-tree@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Peng Zhang Subject: Re: [PATCH v2 04/16] mm: Change do_vmi_align_munmap() side tree index Message-ID: <20230620122619.GA2934656@google.com> References: <20230612203953.2093911-1-Liam.Howlett@oracle.com> <20230612203953.2093911-5-Liam.Howlett@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230612203953.2093911-5-Liam.Howlett@oracle.com> X-Rspamd-Queue-Id: 79FE3C0005 X-Rspam-User: X-Stat-Signature: 1z7y3rouxi4m4bykqd1bcxeaznt553oq X-Rspamd-Server: rspam01 X-HE-Tag: 1687263985-901076 X-HE-Meta: U2FsdGVkX1/uaME8Mw98FGRRixrhqsfdreOyzcmd5+DDe6pcLhKbUqd/0FzSMcBStrQ90tA99EDWYyd8ZqKIspvRw0f9LjG4QLex7kin2m1I1fXsJF3nFLp+rHNWjUHJ1TuOZeK5L0NoeBPcs061dLlxBoyhWAgqq+B8h6BHamddW6ZeSU567Fa0asvEcJwijPKL/miBahBPWuxzSFsWlo2Nrfgg8k0hAlISNo1i5gucgYZrWLU2i5BjDfpe2YD3L05q5zpvFoBXPOVawni56Mwq/YnTc0dyiPg12LJHSFMtOFk8+AVZhFjgMBZgFiFVdBoH1GRlgtchHNAYuOSIFPYWvtxi8o85xte7bmEsMox69sY6yF1hJF4fhEpdr+q4cuO6sSJ5OYVuaM4Fk2jt8duvDb45wWDSDuEgaYOpyljvrVzxxOw7h93RmxRzpV9yLNC0rYnYBEtHtyrhXneSVpmVMZU+SV2aJ87us4zZz/ut1XGO0oZEupIrX7d1elRqEHXq/EFVPg6OWdsqlYQ+oOsJSeXuvxlBWgboS5o9WwqLbv5Hlb9BUvWczxthYHLlETgEx3z/f12pytoy3iUbROTFXwZbaporPm0WByR/4Gjyw1M7Q/8DeQosR1czMj0gHPoJ2RptpV0uOnpgYPlAN0wCta7Hv+TTYqOrH0Sa/TmL0+XCG/OSw9aYsIZqb4DQxCtCKGwh4mGpnKX6bmOLSsg6P7tcyHPiluHQTJwwP5nkGC/9U++/+511CFBlfLER5gMv1D7MoozirLamWteDbD1wcBsvKnkHqy5lRgSK25rUMy8STg+TnIWOX3k+oFXQT+efIL2kBR+oG6eq7lMQX3C37+SPtdhL2v/CALvO8QbOa9Mkrv30voAJZsGnagC2wOsNVypRI3GwaCuXR8JJB+jfzHOTFBbM44C7wonDRX2Asi479yWp2jfK0+eR/umC807g/O6w9yB1Q1rjsVl BLkdRjQ4 PcJNSZYqg8hIq4Slq7b1gICs0XeJ2szColcDWgxiknODQW4rhmheMTtHeLQaw2ndRZeakiS/JcLiMZxwaHfpA0wLTx0BbISdrKibtfGtVagvukAekYalG6qG+B0Ee0Oyts0XhwvzSL/HOGF+yp1Vtd5qa8jmDjiehEcgcjpb5v4gmEui1BorjH7mGUPf9dir8Dsfp/ChlXsvpU1UN8cyKPqIOWKR6hQj/dn2Qk2HRAWTTHldvDSmg+vAYlaXzGKJBwRIeZSJfn6fxj9SlPUgXqd/3itTHlQx+7daxf7dy1NkxezKRwGr8SbIwnrC/2x+WQY+U4f2aWzhtqZ2pLVb7nKFmuhSKYKcP6PlvpGjrt+CTSbE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hello Liam, On (23/06/12 16:39), Liam R. Howlett wrote: [..] > @@ -2450,17 +2452,17 @@ do_vmi_align_munmap(struct vma_iterator *vmi, struct vm_area_struct *vma, > #if defined(CONFIG_DEBUG_VM_MAPLE_TREE) > /* Make sure no VMAs are about to be lost. */ > { > - MA_STATE(test, &mt_detach, start, end - 1); > + MA_STATE(test, &mt_detach, 0, 0); > struct vm_area_struct *vma_mas, *vma_test; > int test_count = 0; > > vma_iter_set(vmi, start); > rcu_read_lock(); > - vma_test = mas_find(&test, end - 1); > + vma_test = mas_find(&test, count - 1); > for_each_vma_range(*vmi, vma_mas, end) { > BUG_ON(vma_mas != vma_test); > test_count++; > - vma_test = mas_next(&test, end - 1); > + vma_test = mas_next(&test, count - 1); > } > rcu_read_unlock(); > BUG_ON(count != test_count); Something isn't quite working, I'm hitting BUG_ON(vma_mas != vma_test) [ 8.156437] ------------[ cut here ]------------ [ 8.160473] kernel BUG at mm/mmap.c:2439! [ 8.163894] invalid opcode: 0000 [#1] PREEMPT SMP PTI RIP: 0010:do_vmi_align_munmap+0x489/0x8a0 [ 8.207867] Call Trace: [ 8.208463] [ 8.209018] ? die+0x32/0x80 [ 8.209709] ? do_trap+0xd2/0x100 [ 8.210520] ? do_vmi_align_munmap+0x489/0x8a0 [ 8.211576] ? do_vmi_align_munmap+0x489/0x8a0 [ 8.212639] ? do_error_trap+0x94/0x110 [ 8.213549] ? do_vmi_align_munmap+0x489/0x8a0 [ 8.214581] ? exc_invalid_op+0x49/0x60 [ 8.215494] ? do_vmi_align_munmap+0x489/0x8a0 [ 8.216576] ? asm_exc_invalid_op+0x16/0x20 [ 8.217562] ? do_vmi_align_munmap+0x489/0x8a0 [ 8.218626] do_vmi_munmap+0xc7/0x120 [ 8.219494] __vm_munmap+0xaa/0x1c0 [ 8.220370] __x64_sys_munmap+0x17/0x20 [ 8.221275] do_syscall_64+0x34/0x80 [ 8.222165] entry_SYSCALL_64_after_hwframe+0x63/0xcd [ 8.223359] RIP: 0033:0x7fdb0e2fca97 [ 8.224224] Code: ff ff ff ff c3 66 0f 1f 44 00 00 f7 d8 89 05 20 28 01 00 48 c7 c0 ff ff ff ff c3 0f 1f 84 00 00 00 00 00 b8 0b 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8d 0d f9 27 01 00 f7 d8 89 01 48 83 [ 8.228432] RSP: 002b:00007ffd15458348 EFLAGS: 00000202 ORIG_RAX: 000000000000000b [ 8.230175] RAX: ffffffffffffffda RBX: 0000562081a347b0 RCX: 00007fdb0e2fca97 [ 8.231833] RDX: 0000000000000002 RSI: 0000000000004010 RDI: 00007fdb0e2d5000 [ 8.233513] RBP: 00007ffd154584d0 R08: 0000000000000000 R09: 0000562081a3fd30 [ 8.235178] R10: 0000562081a3fd18 R11: 0000000000000202 R12: 00007ffd15458388 [ 8.236861] R13: 00007ffd15458438 R14: 00007ffd15458370 R15: 0000562081a347b0