From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B68EEB64D8 for ; Tue, 20 Jun 2023 15:04:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9E53D8D0002; Tue, 20 Jun 2023 11:04:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 96D878D0001; Tue, 20 Jun 2023 11:04:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7E9EB8D0002; Tue, 20 Jun 2023 11:04:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 68AC68D0001 for ; Tue, 20 Jun 2023 11:04:28 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 3E1FC120945 for ; Tue, 20 Jun 2023 15:04:28 +0000 (UTC) X-FDA: 80923447416.01.F7DEDAA Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf16.hostedemail.com (Postfix) with ESMTP id 46696180075 for ; Tue, 20 Jun 2023 15:03:00 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=VePKwYP7; spf=pass (imf16.hostedemail.com: domain of ypodemsk@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=ypodemsk@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687273381; a=rsa-sha256; cv=none; b=lpKlyXm/xDuWpPzsKBlWDc27o0VJWzxiXH+E/rwE98qMZkV0+T+TQCp3uQS/w6waydQz13 87OT/WfUAsnma/HK0j8e3dtku/vRrtBy8cC/FP/ldNBL1RIkMysiDYuDEyJ0JzuzUrbEUS zwSmg5Bkm1TOFL+5Vc9VN9jz3wOdl1Q= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=VePKwYP7; spf=pass (imf16.hostedemail.com: domain of ypodemsk@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=ypodemsk@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687273381; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IMVWP9uUwreYp41lBQlzx9rQqv8YUX+d+4RkZ35R+cQ=; b=KAqOJE7++pFjUlen/VYRY18qPAUdheYstnle/wsSkIyzozAA6idznpNImG6FqNZlN2g1xC DgvafNFrpKPqXqYl1ZHOqhiHZFwQ9ATRJvylt90JdxkF3QZ0SaHRICK3rf/jeldyzM/1yl B6IOwLjegPuGWz3GscmF1wgCmhxKqWY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687273224; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IMVWP9uUwreYp41lBQlzx9rQqv8YUX+d+4RkZ35R+cQ=; b=VePKwYP7dGkESEKduTV09XQKz0Uw9ZTtquxcCoT813iqBrq/Y9sksEAbXbw8zVH3A/ANi5 9lreFwViwKjEHDTxTX3J2JallGqwwVTsKyoLViZ5UOH4aL9UlsKtoH9HO9AHYfJKgixZz2 PlqUPVv//iLwO0wY7iVhWpkh8jdrysU= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-582-PGZ8P0JHPzaSP3c_R985HA-1; Tue, 20 Jun 2023 10:54:43 -0400 X-MC-Unique: PGZ8P0JHPzaSP3c_R985HA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id AFAFA18E0072; Tue, 20 Jun 2023 14:46:51 +0000 (UTC) Received: from ypodemsk.tlv.csb (unknown [10.39.195.147]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E04889E9C; Tue, 20 Jun 2023 14:46:42 +0000 (UTC) From: Yair Podemsky To: mtosatti@redhat.com, ppandit@redhat.com, david@redhat.com, linux@armlinux.org.uk, mpe@ellerman.id.au, npiggin@gmail.com, christophe.leroy@csgroup.eu, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, borntraeger@linux.ibm.com, svens@linux.ibm.com, davem@davemloft.net, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, keescook@chromium.org, paulmck@kernel.org, frederic@kernel.org, will@kernel.org, peterz@infradead.org, ardb@kernel.org, samitolvanen@google.com, juerg.haefliger@canonical.com, arnd@arndb.de, rmk+kernel@armlinux.org.uk, geert+renesas@glider.be, linus.walleij@linaro.org, akpm@linux-foundation.org, sebastian.reichel@collabora.com, rppt@kernel.org, aneesh.kumar@linux.ibm.com, x86@kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: ypodemsk@redhat.com Subject: [PATCH v2 2/2] mm/mmu_gather: send tlb_remove_table_smp_sync IPI only to MM CPUs Date: Tue, 20 Jun 2023 17:46:18 +0300 Message-Id: <20230620144618.125703-3-ypodemsk@redhat.com> In-Reply-To: <20230620144618.125703-1-ypodemsk@redhat.com> References: <20230620144618.125703-1-ypodemsk@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 46696180075 X-Stat-Signature: c5iits9sfbfgsqrg6nnykfggw4mnzxzy X-Rspam-User: X-HE-Tag: 1687273380-472570 X-HE-Meta: U2FsdGVkX1+q/rNdkl+d5LfSzXo97EWSX6HP12vc42W9oYYDnhyGk7Rg/WG31jPOMuiLKPrukHfwlhi7YcBg8Mty/MmJap5msO9MxsydqMBVYdeN1OQIn8p42dA/UNlSPQb0OEDfGXob2MvMTED8QzhLNebMrFwNYsUQNBNBRuicizADvwv2W1S5YozRWeACUkSRIM9jPpTPJ4WPlRy2ANNdZ2Mi990jBWSkKHo92cCCAaZkg5tzxUUoTOP0Xfmo7uqSY1hxK4PVrgmyiNFt9I1OzzN6QIU2ZPPdv6kOcnocCW9O2Yn0MsVW5TqJqHzgkobD3M/FKu73COHkM/zaH0/2QNVGDAGJtAV08s6Rqz9uSCvCJa7wJVKK2ey0DseDJv1br0PLoRrGScivU7zHyKbBAS5Gp4+dpu7DBh1FqPSeCfi9sDPmd9pbKOefN+JTQxsdL4kPiN8y0hFadsB2GoNEXLpSuehOZubOMdgV+pXG5gbnJQSbUmKZF8aT07VzgP5DDA1J2zjkcGuFX2jQptZq837ieXCIeJxxOZXpj7tOEys2saaPGrHEM+0IFaGuueEgVPNtJAC5nUrEz6NCt0x3vFKa5kjPWL/md/vpYaPSU0S4KOKsSdBMjnLVb9TuLsagCXWRv6h3xfgHsiwJXeSxQHfOl1JaIFGcXD1bn/nS/aRS2kawdo/bspt2QGLxa9O2rKLqnLOs1xyYVz5G9Dg65RXdBTjRi+dod121MQYtoi1Jo6CjK9VP556Ur1ROlLGQ7s5+RwxYWzreI97j88MIotq2hFF797PhLr9y8KOfrLjT1IazNSIn0jHQSMk/7XLUiyG5QMa95LTabzWzsProj8+RCES7Qv6WNgmu/1Tltch5k9m3gZ4hR+9ZFDnRihCTW9heo1J8zbazHLTtbTidObnQ0v+yXPQNBmEXnOw4aCc0WsMvrW59+xJgT9mgL104Ep0mVOf1szY6C2R 9wNysYw7 Xn5at99FnScv5xSFz9a991OlX1qd9JWjP8ec+BlIgwYuf95NPZDZbdkzGH5JgwSkj/YSJsqwEVzH86D1rB7CZoFRKlrHX17ieGfJStkprOoYgJ/ztoh7KV8gHuWWJczsLQ9z3x8G6SCL7NOabDi9wson4lKnXWzsPmWu4gscsdrESowgIZP/zR9Ue6dYnulpROBXYhKds+OJMrrS0eAg38XmVCTyb7+9cnNUBaxU4I69XiGBWZBmGmfogPcojjnZjct3rsKZjzcPIwnBRXwy+LVVQ8Pu2TVvLhticfybJCXGn6WjpeCM+IOc6Xw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Currently the tlb_remove_table_smp_sync IPI is sent to all CPUs indiscriminately, this causes unnecessary work and delays notable in real-time use-cases and isolated cpus. This patch will limit this IPI on systems with ARCH_HAS_CPUMASK_BITS, Where the IPI will only be sent to cpus referencing the affected mm. Signed-off-by: Yair Podemsky Suggested-by: David Hildenbrand --- include/asm-generic/tlb.h | 4 ++-- mm/khugepaged.c | 4 ++-- mm/mmu_gather.c | 17 ++++++++++++----- 3 files changed, 16 insertions(+), 9 deletions(-) diff --git a/include/asm-generic/tlb.h b/include/asm-generic/tlb.h index b46617207c93..0b6ba17cc8d3 100644 --- a/include/asm-generic/tlb.h +++ b/include/asm-generic/tlb.h @@ -222,7 +222,7 @@ extern void tlb_remove_table(struct mmu_gather *tlb, void *table); #define tlb_needs_table_invalidate() (true) #endif -void tlb_remove_table_sync_one(void); +void tlb_remove_table_sync_one(struct mm_struct *mm); #else @@ -230,7 +230,7 @@ void tlb_remove_table_sync_one(void); #error tlb_needs_table_invalidate() requires MMU_GATHER_RCU_TABLE_FREE #endif -static inline void tlb_remove_table_sync_one(void) { } +static inline void tlb_remove_table_sync_one(struct mm_struct *mm) { } #endif /* CONFIG_MMU_GATHER_RCU_TABLE_FREE */ diff --git a/mm/khugepaged.c b/mm/khugepaged.c index 6b9d39d65b73..3e5cb079d268 100644 --- a/mm/khugepaged.c +++ b/mm/khugepaged.c @@ -1166,7 +1166,7 @@ static int collapse_huge_page(struct mm_struct *mm, unsigned long address, _pmd = pmdp_collapse_flush(vma, address, pmd); spin_unlock(pmd_ptl); mmu_notifier_invalidate_range_end(&range); - tlb_remove_table_sync_one(); + tlb_remove_table_sync_one(mm); spin_lock(pte_ptl); result = __collapse_huge_page_isolate(vma, address, pte, cc, @@ -1525,7 +1525,7 @@ static void collapse_and_free_pmd(struct mm_struct *mm, struct vm_area_struct *v addr + HPAGE_PMD_SIZE); mmu_notifier_invalidate_range_start(&range); pmd = pmdp_collapse_flush(vma, addr, pmdp); - tlb_remove_table_sync_one(); + tlb_remove_table_sync_one(mm); mmu_notifier_invalidate_range_end(&range); mm_dec_nr_ptes(mm); page_table_check_pte_clear_range(mm, addr, pmd); diff --git a/mm/mmu_gather.c b/mm/mmu_gather.c index ea9683e12936..692d8175a88e 100644 --- a/mm/mmu_gather.c +++ b/mm/mmu_gather.c @@ -191,7 +191,13 @@ static void tlb_remove_table_smp_sync(void *arg) /* Simply deliver the interrupt */ } -void tlb_remove_table_sync_one(void) +#ifdef CONFIG_ARCH_HAS_CPUMASK_BITS +#define REMOVE_TABLE_IPI_MASK mm_cpumask(mm) +#else +#define REMOVE_TABLE_IPI_MASK cpu_online_mask +#endif /* CONFIG_ARCH_HAS_CPUMASK_BITS */ + +void tlb_remove_table_sync_one(struct mm_struct *mm) { /* * This isn't an RCU grace period and hence the page-tables cannot be @@ -200,7 +206,8 @@ void tlb_remove_table_sync_one(void) * It is however sufficient for software page-table walkers that rely on * IRQ disabling. */ - smp_call_function(tlb_remove_table_smp_sync, NULL, 1); + on_each_cpu_mask(REMOVE_TABLE_IPI_MASK, tlb_remove_table_smp_sync, + NULL, true); } static void tlb_remove_table_rcu(struct rcu_head *head) @@ -237,9 +244,9 @@ static inline void tlb_table_invalidate(struct mmu_gather *tlb) } } -static void tlb_remove_table_one(void *table) +static void tlb_remove_table_one(struct mm_struct *mm, void *table) { - tlb_remove_table_sync_one(); + tlb_remove_table_sync_one(mm); __tlb_remove_table(table); } @@ -262,7 +269,7 @@ void tlb_remove_table(struct mmu_gather *tlb, void *table) *batch = (struct mmu_table_batch *)__get_free_page(GFP_NOWAIT | __GFP_NOWARN); if (*batch == NULL) { tlb_table_invalidate(tlb); - tlb_remove_table_one(table); + tlb_remove_table_one(tlb->mm, table); return; } (*batch)->nr = 0; --- v2: replaced no REMOVE_TABLE_IPI_MASK REMOVE_TABLE_IPI_MASK to cpu_online_mask -- 2.39.3