linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Mike Kravetz <mike.kravetz@oracle.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Sidhartha Kumar <sidhartha.kumar@oracle.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	linux-fsdevel@vger.kernel.org,
	Matthew Wilcox <willy@infradead.org>,
	Ackerley Tng <ackerleytng@google.com>,
	Muchun Song <songmuchun@bytedance.com>,
	Vishal Annapurve <vannapurve@google.com>,
	Erdem Aktas <erdemaktas@google.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH 2/2] hugetlb: revert use of page_cache_next_miss()
Date: Wed, 21 Jun 2023 15:46:57 -0700	[thread overview]
Message-ID: <20230621224657.GB4155@monkey> (raw)
In-Reply-To: <20230621153957.725e3a4e1f38dc7dd76cc1aa@linux-foundation.org>

On 06/21/23 15:39, Andrew Morton wrote:
> On Wed, 21 Jun 2023 15:19:58 -0700 Sidhartha Kumar <sidhartha.kumar@oracle.com> wrote:
> 
> > > IMPORTANT NOTE FOR STABLE BACKPORTS:
> > > This patch will apply cleanly to v6.3.  However, due to the change of
> > > filemap_get_folio() return values, it will not function correctly.  This
> > > patch must be modified for stable backports.
> > 
> > This patch I sent previously can be used for the 6.3 backport:
> > 
> > https://lore.kernel.org/lkml/b5bd2b39-7e1e-148f-7462-9565773f6d41@oracle.com/T/#me37b56ca89368dc8dda2a33d39f681337788d13c
> 
> Are we suggesting that this be backported?  If so, I'll add the cc:stable.
> 
> Because -stable maintainers have been asked not to backport MM patches to
> which we didn't add the cc:stable.

Yes, we need to get a fix into 6.3 as well.

The 'issue' with a backport is noted in the IMPORTANT NOTE above.

My concern is that adding cc:stable will have it automatically picked up
and this would make things worse than they are in 6.3.

My 'plan' was to not add the cc:stable, but manually create a patch for
6.3 once this goes upstream.  Honestly, I am not sure what is the best
way to deal with this.  I could also try to catch the email about the
automatic backport and say 'no, use this new patch instead'.
-- 
Mike Kravetz


  reply	other threads:[~2023-06-21 22:47 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-21 21:24 [PATCH 1/2] Revert "page cache: fix page_cache_next/prev_miss off by one" Mike Kravetz
2023-06-21 21:24 ` [PATCH 2/2] hugetlb: revert use of page_cache_next_miss() Mike Kravetz
2023-06-21 22:19   ` Sidhartha Kumar
2023-06-21 22:39     ` Andrew Morton
2023-06-21 22:46       ` Mike Kravetz [this message]
2023-06-21 22:52         ` Andrew Morton
2023-06-21 23:02           ` Mike Kravetz
2023-06-21 22:15 ` [PATCH 1/2] Revert "page cache: fix page_cache_next/prev_miss off by one" Sidhartha Kumar
2023-06-21 22:18 ` Andrew Morton
2023-06-21 23:01   ` Mike Kravetz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230621224657.GB4155@monkey \
    --to=mike.kravetz@oracle.com \
    --cc=ackerleytng@google.com \
    --cc=akpm@linux-foundation.org \
    --cc=erdemaktas@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=sidhartha.kumar@oracle.com \
    --cc=songmuchun@bytedance.com \
    --cc=vannapurve@google.com \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).