From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF16CEB64D8 for ; Thu, 22 Jun 2023 07:33:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3999F8D0003; Thu, 22 Jun 2023 03:33:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 322818D0001; Thu, 22 Jun 2023 03:33:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 19B678D0003; Thu, 22 Jun 2023 03:33:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 02FF78D0001 for ; Thu, 22 Jun 2023 03:33:02 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id C431F1C8D9B for ; Thu, 22 Jun 2023 07:33:01 +0000 (UTC) X-FDA: 80929567362.14.2B631BF Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf10.hostedemail.com (Postfix) with ESMTP id C5471C0015 for ; Thu, 22 Jun 2023 07:32:59 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Y+S6cWYX; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=pGfxU2eZ; spf=pass (imf10.hostedemail.com: domain of pvorel@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=pvorel@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687419180; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pgboY+1eKS7Q4R+wwxJQMziAyhb5MWJJWPixvdsi6vw=; b=v02KidUnc3XejT6zUbr9lJHnFAEBJwQA0jPi9xTyM4fOMHSqf2C7ZFihbbuEM8AFdUcldc MLiWJj5ugxuVAA7/FVsVVyC1EPCd7TuHdKy2ORizODr/lV9D+AvN3whv5jaediI/VHpLd9 /7MQzdXfZvv82McznyysClsAunNzSM8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687419180; a=rsa-sha256; cv=none; b=Y3BC8DQ3XBnlP+L8OVN2g7LklhhCRkpzs5FVXstFl3YBjD+A8H8gL0aJ+xbUgAzPKeLIPV nXKukjyYuuugIv7qcVAXNzQKga8ngpZzWyP5bFjUPUfGYkCHJKsOMcq9/KfiorZh/j70oM 3oM/8K2p6tMPE8h9vXeWc7z77P666pY= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Y+S6cWYX; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=pGfxU2eZ; spf=pass (imf10.hostedemail.com: domain of pvorel@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=pvorel@suse.cz; dmarc=none Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 4C3AD228F4; Thu, 22 Jun 2023 07:32:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1687419178; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pgboY+1eKS7Q4R+wwxJQMziAyhb5MWJJWPixvdsi6vw=; b=Y+S6cWYXoDMZLa4zgn8fXqN1yVVU4Rc5J3cecl/T4XwUXtc1WEyiOLrpWwehhnLEhKvvNr iJsuZ8lnFtBadV/8KQmFkAtExzARtZdpPgvPY6eZL4741HxpQVG8IqMTneY8xBI7WQL445 eFMxsBMBA/qtt1A9qZEW2rm/+Gd1/PQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1687419178; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pgboY+1eKS7Q4R+wwxJQMziAyhb5MWJJWPixvdsi6vw=; b=pGfxU2eZPdVCvBbg1C/Ohx53ZNQOEgSeTw6YwkthFbsntvmEFx+uZ+uTJQaNElFLRfLkT+ nZCDJ83OLBp+BAAw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E213D13905; Thu, 22 Jun 2023 07:32:57 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 4irjNSn5k2TSZwAAMHmgww (envelope-from ); Thu, 22 Jun 2023 07:32:57 +0000 Date: Thu, 22 Jun 2023 09:32:56 +0200 From: Petr Vorel To: Niklas Cassel Cc: Cyril Hrubis , Damien Le Moal , kernel test robot , "lkp@intel.com" , "Martin K. Petersen" , "linux-kernel@vger.kernel.org" , "linux-block@vger.kernel.org" , Linux Memory Management List , Hannes Reinecke , "oe-lkp@lists.linux.dev" , Christoph Hellwig , "ltp@lists.linux.it" Subject: Re: [LTP] [linux-next:master] [scsi] eca2040972: ltp.ioprio_set03.fail Message-ID: <20230622073256.GA482307@pevik> Reply-To: Petr Vorel References: <202306192248.1ece4c29-oliver.sang@intel.com> <61f22c1d-6b04-d193-57c9-8cad1c555e4b@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: dsfq3hmy3b9mjrsoeid98wrpc788gwrg X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: C5471C0015 X-Rspam-User: X-HE-Tag: 1687419179-533183 X-HE-Meta: U2FsdGVkX1+hpNufB04gkrAyHBwUvpKd7s23vkrFqBL1naR369soDSKmjBWl+X2aBT7My/CpJtI4/l5UCs8OhNThpbaoLcFJEnsIa/YD3NNtNMsSXVVoTzVDr8z3d13e4qhnshJ+dFZD/1OTJ4xC5agZ+n4RW16DIhea+w5lQrlfx+kprk6As5yYczj+ixhOylWWX0pHDdThkgpB0q6xyM1Smd9EqupoGy67S8R6V+BFA7J18ArNzSBq53n1eBsFXfAfG+YtLJvHcBPMAAfV+ER46cGxv/+x3z+SQ1+7DBCguFthPOmdy+149I6Pu3r5heUf/inFqlaxOqXRnFtBfyjaRGyI1CDufdVGXeA+xbwzYQhxjvzAjcB16FgCjRqBqSewkBLqgvszGXcOkNrUD4f5ntirEnSBBOJjQBgZFx+m7e2RCJB3w2w0cFLaP39zn6Nl79AALj6bJOsq0o6SZsJDCN2UPnH0tIEwDeN3MTi3HrdZeLD0wRLcTlzsnexqJlPMVyxI7naL4Gnw72MBlcsxllk6Nf7EWLxOrBWc6vQIhb3XsZueusPom6VhTc4GCR1oGmYNbn0RTq4J1Ss6QzOAs0/+RYMKTSeBwQsp0XRdoEZXpG2PSw8ziVYvLYS9wspNZuQmxSal5PE89cPBHpwwEzfNSwdprdnUhvL5pn2coVJul5L3g/FYsXacpX2posA0qN1BpxtfpTD1luQ7RMi4Y8jqs9/CMAiU7yFFTdzbsT/Dz9hcyyVqj4hrXkQc6nBwADMSzR3H9ZCWbVe7E/PMvQ8eA6o/qinN6SNi6K+spFQaOnOIQ+CgKJHBaMeesttpfJS+Z/XGDmAQxjAwG4EKWh+bEOzcCiepfE91IEAN1cexbXV8gzsORbdg8NFTxZAo8jI/KSuvLXeuw9+UCv3Yb9njFr2XuTcALQE3cOMw56ZN+79KtiJtj+fxt6S9Kn+phtWq+c/ZLH1V6xg fbxQMLM1 Y/t3chwAC36glrYDJo8apW9vcgN7B08ATk+nvBO6onACyDAres3Wokd4j7XYLv/mtFiS0svG+BQgrtNVcWuK8aCbuanB9QuXjm6OG/Y1eZLk71GNyaFRW1VTYnTTANPfeLgOIx+5tZoHpT+hOGJyfvd2aYa521qYti/VqgIjndWgV0BoZk8b/y7PspHLAcPpz8fV+ow/IUo1ZMRttbgOeRe1I5dUCmm9YivONUZMO1k10HYTyeFfsQZ9uzkFmKKj+4SeJ0Ufvx0OmlAINehJsfJojh94m1r6OgfTdfrILr7AjfvXvb4K1umUjmgUI6Z194/3OM9Am0omHXKIQsjIMV9ehXIw3XwqBxuJY0G4DAnelguXpKP2zWkX0+Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > On Wed, Jun 21, 2023 at 02:47:43PM +0200, Cyril Hrubis wrote: > > Hi! > > > > kernel test robot noticed "ltp.ioprio_set03.fail" on: > > > LTP maintainers, > > > Patches have been submitted to fix this issue. Were these patches applied ? > > Looks like they are in, at least these two: > > ioprio: use ioprio.h kernel header if it exists > > ioprio: Use IOPRIO_PRIO_NUM to check prio range > > And there does not seem to be anything ioprio related haning in the LTP > > patchwork. Hi Niklas, > Hello Cyril, Petr, Damien, > I just ran LTP master + linux-next and the test case passes for me. > Although, note that even if you are using LTP master, > the way that the LTP header: > testcases/kernel/syscalls/ioprio/ioprio.h > is written, you will need to run > make headers_install > with linux-next kernel source, > before running > make autotools && ./configure > in LTP. > Otherwise LTP will use the kernel uapi headers from your distro, > which does not perform the new checks for the IOPRIO_PRIO_VALUE() > macro. (It requires linux uapi headers from linux-next.) Yes, it should do otherwise more tests would be often broken. > Does the linux kernel test robot not run > make headers_install > before running > make autotools && ./configure > in LTP? I guess that's the question for Damien (I and Cyril have nothing to do with kernel test robot). I wonder myself. > One option, although I'm not sure if we want this, > is to change > testcases/kernel/syscalls/ioprio/ioprio.h > to do something like: > #ifndef IOPRIO_BAD_VALUE > # define IOPRIO_BAD_VALUE(val, max) ((val) < 0 || (val) >= (max)) > #endif > such that LTP does not need to be compiled against the kernel uapi > headers that match the running kernel. > But... shouldn't the installed uapi headers match the running kernel? Yes, whatever kernel version (stable, enterprise, mainline, linux-next, ...) is being tested, the tester should make sure LTP is compiled against correct headers. Kind regards, Petr > Kind regards, > Niklas