From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82550EB64D7 for ; Fri, 23 Jun 2023 17:01:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C13C38D0002; Fri, 23 Jun 2023 13:01:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BC3D28D0001; Fri, 23 Jun 2023 13:01:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AB2A08D0002; Fri, 23 Jun 2023 13:01:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 9DAE88D0001 for ; Fri, 23 Jun 2023 13:01:06 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 59846120D01 for ; Fri, 23 Jun 2023 17:01:06 +0000 (UTC) X-FDA: 80934627732.01.480D317 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf20.hostedemail.com (Postfix) with ESMTP id 9F4AF1C0059 for ; Fri, 23 Jun 2023 17:00:42 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="h6/0i8b5"; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf20.hostedemail.com: domain of kuba@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kuba@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687539643; a=rsa-sha256; cv=none; b=VeCfKkgPt7W0Dh80+StVTW8D/CHQ09pYky7AWdbtFyhaTZ8b7uJCNQTXmErvZ6xAnjOwPt bKkA11id9fIICiy7lLn/KbajdhwxwQ3jV/s3ec1AS1xOL2kOeLCqcuA5Kb/KkjmMyGihw5 w8fuQ5d7hZyQXFkd4wJI/H2PlposzBg= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="h6/0i8b5"; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf20.hostedemail.com: domain of kuba@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kuba@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687539643; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=G2qLQyjUFVov2Fialjb1IWp/ZnxpFivLVLu+F4O0SPY=; b=xlk3nUY7XNg7xEJxP7Iu6MUelIpqvNDUyf231/CI1/Zmw4dojY8YoDckLB103PXZYTHCcq n2VTb7iibD93SALIuzlCWqjZiTOM3vtiuMJSDYau1f+kHe9Qffyo7pH/0DI3TAM2yjkU1D bcI+27+QgpFQ1IFnB55/IMQpr78Xbig= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 268B661AC9; Fri, 23 Jun 2023 17:00:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 033ECC433C9; Fri, 23 Jun 2023 17:00:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1687539641; bh=8NvdvMOZhkf3ZWHCAYhr6IS/S3CpGzOG5wCKstBXM/A=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=h6/0i8b5U6xV3rDgMIBxRMocLpmNGFZY618h9D1Yg3zKzltu1gljLOo2TTiI43Cvp N8emwr4aIVkqWlvGoDzPntH7XpThaon1gAVIyfSyQYW+hQnAzM2vBCTiuF+u/vBo7R /wZFoJixy4+SS9Ns7Whew+fmlegNGLtSprWupskJDm9BDDW71ijdzXhCUJ/cOh0BuN pAxFt8CgIOBjSdeUegTBRdu6N2sA/iF4ahxUmwJ6BR8s7SQAAgTXBWJxYx2Lr/4j7D 8qpPHfWStK1yOUwrtYFucxtWK+BNf3L4N4UydRvXKXSFbiQoQg8TOnI8t637yOZcAu Wwf40LbpxIDDg== Date: Fri, 23 Jun 2023 10:00:40 -0700 From: Jakub Kicinski To: David Howells Cc: netdev@vger.kernel.org, Alexander Duyck , "David S. Miller" , Eric Dumazet , Paolo Abeni , Willem de Bruijn , David Ahern , Matthew Wilcox , Jens Axboe , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Ilya Dryomov , Xiubo Li , Jeff Layton , ceph-devel@vger.kernel.org Subject: Re: [PATCH net-next v4 03/15] ceph: Use sendmsg(MSG_SPLICE_PAGES) rather than sendpage Message-ID: <20230623100040.4ebbeeb2@kernel.org> In-Reply-To: <20230623114425.2150536-4-dhowells@redhat.com> References: <20230623114425.2150536-1-dhowells@redhat.com> <20230623114425.2150536-4-dhowells@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 9F4AF1C0059 X-Stat-Signature: toichszm6i9oshbcxsb8exyrxbukw1ih X-HE-Tag: 1687539642-745420 X-HE-Meta: U2FsdGVkX1+shSjnn1BqbP3A+nS3XW1ASwzKD7h8DY51G0T4nQ31VEMPJo2z5pcbrGpIEzN6yXgi4xtJHcGleLR+rUxL65/oUxqXZxq2CPNijLY0a3dYeZjfI7mqj1n7EK46kWZneGV0nnEc24/5beSsHgbzdk8ScqWX+QvoARN9hyCcQFEnrYWOM1o2ln7HlGvBHMxMpsWvgUtAr/5qBL5Pu7S7xmys7jX0EUTdKdJN26g6YP7S08l4H68bCga/WQUubGq5a3IHJWdGmapKBznUQFHtaC9R4PsxhgVA2D1PIAOgUiPKuNnaPQ/hKuiIJebfTelFJtkAazMvf2fUjWFLakYgEP/bRRA/lkdOB+odyqEI7IO9lC4oOSpaT0DYeEwTEdyxknExee4/hR1WafVQE7dRb46GdDxClbfXOk/1VRHloICDCxym5tavN2frKSOvqsK90Y4QDJ7YAzujeeoevO88rHjThWcwEzPDCn0it19cPM/01s7aM6gWNPRin2bWgwLdXYWnjDb1RyGyb1FtJp7NqNU1enCV6WR9fBNdj6b6CbcIYODR1zpkjwugqt4I/gppens/HcxlYymK/RflYqkvmD8unAoE2cgyBTWns6zLSphgO+ddHJqQ+OdbB3junQVW1d+bJiiKBoQpphmYeO9h/hAOvlKUy6HJvGZ2CPlcMiNuFtKD6cyItWEy06d9mvxlXpkpD1hL5B76huyxh7MEoPPJ8lvRQ3qT8sJUK5O8F3HQSmgGAT7bi8CD/sXfIHWeGD0gIQRt/Ed2wPmv0a6vJF+LSR21cb3AkjqwHRaLQCy3VFkpFsLRePLqgzXm3Sn1EzBcOLQ+PnzLm94ZTMMoAiJlpKwDgXjJB6tLK+5aoxczMXYxfGqxq1/jIVSvaWerm6hfemZHBVKr/305POgIDIc9MVQmdb1qaPqQkJBqGMVmzoUm04Fm520MHwrjGQl/Df/v41wVyqQ KQQPpBKd J938ipyoSI5dMDqUJK8m38NNjRA6lrIKi0djZrSrFd10IG9U+INv6h7P/8Kh+mSHLASN/WcLnbNuJBuQ8i5hyhO2sIoyKbCOqOnP6CnY8bpxXayAaEgS6rhq88R9VBzpcbFl6Axq2h0UJpnmsok5h+JrgCvCkKMvfbIAPCKpezzq5Co+5fq9cd6XZCj67nMDIOe/zlI27HwCUIO33KAY+dofeW7ja7GgdfA/ZndgOtALSqFr2gXF7FMmcYePrhy/BPPNWUQaq/iC4kNeOe5mr4+PA8c3ab4Xo06wQ/e//EcckbUJ9y4uHqnBWf5IT7QB0rYfxq4KLKDvC12CrW8mjWA2mZiUjRQJArlXsgmA3ymDA6VQTMOrG1ang69sOm8PSCngh/+6KzZXB2cWelM5jjh+Run36ztifcjkq X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 23 Jun 2023 12:44:13 +0100 David Howells wrote: > @@ -494,9 +466,12 @@ static int write_partial_message_data(struct ceph_connection *con) > > page = ceph_msg_data_next(cursor, &page_offset, &length); > if (length == cursor->total_resid) > - more = MSG_MORE; > - ret = ceph_tcp_sendpage(con->sock, page, page_offset, length, > - more); > + msghdr.msg_flags |= MSG_MORE; Should the condition also be flipped here, like you did below? (can be a follow up if so) > @@ -534,9 +512,11 @@ static int write_partial_skip(struct ceph_connection *con) > size_t size = min(con->v1.out_skip, (int)PAGE_SIZE); > > if (size == con->v1.out_skip) > - more = MSG_MORE; > - ret = ceph_tcp_sendpage(con->sock, ceph_zero_page, 0, size, > - more); > + msghdr.msg_flags &= ~MSG_MORE; > + bvec_set_page(&bvec, ZERO_PAGE(0), size, 0); > + iov_iter_bvec(&msghdr.msg_iter, ITER_SOURCE, &bvec, 1, size);