From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 467B3EB64DC for ; Sun, 25 Jun 2023 09:34:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B1DDB6B0071; Sun, 25 Jun 2023 05:34:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ACE816B0072; Sun, 25 Jun 2023 05:34:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 96F9F6B0074; Sun, 25 Jun 2023 05:34:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 88D1D6B0071 for ; Sun, 25 Jun 2023 05:34:07 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 5D7A7407B3 for ; Sun, 25 Jun 2023 09:34:07 +0000 (UTC) X-FDA: 80940758934.30.DD1E5EC Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by imf06.hostedemail.com (Postfix) with ESMTP id 1AF6F18000E for ; Sun, 25 Jun 2023 09:34:04 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=kroah.com header.s=fm2 header.b=N3y6oVXI; dkim=pass header.d=messagingengine.com header.s=fm2 header.b="Mra/gTVV"; spf=pass (imf06.hostedemail.com: domain of greg@kroah.com designates 66.111.4.25 as permitted sender) smtp.mailfrom=greg@kroah.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687685645; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RjM4GlJucU1Ls0/IxjRJeTQsDlFI04X+oR2L/HWLcOU=; b=VoGfN6jZN4yyF3HHIm+YteLtkmoOjeGHkUj10x/1kj9L/aP2ev1PJQ4ozHPWaWmszoQovp x8trztpxpYBtrU/Hk8gY80Nzute4sexwFhvj8lkLiv9LIME6nk5a006/heqaYEDGQGl+AP JY93wkzl337ZRSoKLh6Fyuwer88dGCI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687685645; a=rsa-sha256; cv=none; b=c60UuE59Ra7dXBoHG/oYE6ZXQpzJLkfD53Nxd2jKRpVbL3H4xLX/A59LUC5Tx3SGSJqQQE csxrtkPvxhSIIVrVLm6DrMf2LMWXmuPrCFIQs03FKwhqP1kUvT+Kx6wZCZ3ioaRFWvHcas bfU4zRsw7iLqpbWfOug6KGvKnvnl3ts= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=kroah.com header.s=fm2 header.b=N3y6oVXI; dkim=pass header.d=messagingengine.com header.s=fm2 header.b="Mra/gTVV"; spf=pass (imf06.hostedemail.com: domain of greg@kroah.com designates 66.111.4.25 as permitted sender) smtp.mailfrom=greg@kroah.com; dmarc=none Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 529F05C0071; Sun, 25 Jun 2023 05:34:04 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sun, 25 Jun 2023 05:34:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1687685644; x=1687772044; bh=RjM4GlJucU1Ls0/IxjRJeTQsDlFI04X+oR2 L/HWLcOU=; b=N3y6oVXIfLxMNjXEj2CdDjv6SnrrazLKLzVOXwB/Zxc0FUHhpH5 9N22s/YV0SQNvbSUls1emOSWggGoX8221j9dqUrP3AWiNlk9a0MX3uFaJfLnjrBK 84OHttyK7NrtLvajk1AkWo/S9hH0tHHmNQnUAnDv53CDxnKDlI+Dm10SfAvzlJXo DNo1jG893OrYDTLzEinjV0+FFcDkbFsQjuD7j0Wap5YImVLTEkhTdsZuohGhECPm HvNVsIyVZob54JB7DWCEI/DeU45RhAy1OJDmoA31Y0l+JcAwQTTYuKDidmS0zoHo oT7wJzZORndrWKHVa/R4BJy/Bi5c/izg3Lw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1687685644; x=1687772044; bh=RjM4GlJucU1Ls0/IxjRJeTQsDlFI04X+oR2 L/HWLcOU=; b=Mra/gTVVzBBlh2KZH+VStSusrtvPlFL8EvWIJkcdSC5CM1lnwoC bj0p4+Ex1LXkZxXC+i5B1Mz32zuZmWBh2+4Vvas+7Wa3E3ea7XU44sANJP4iXSBd yMFfpcITNUe7/bdi1bpnhUxhmiczSIuZEcM4u/lDvfRFcsx2cn2w7zX+UtTipUBe C0AEJW3KMvWNuZ1OyDBGlmQlV02GZp5RlL+IETX3o8XTKkzRpaZbP24/irzAUYBB gcvesxp9ZAJnI5840uh4Suetv8aFchXCmfKTBQ4iGw94zahHJHFbzEPumzsdfV/o a3H4DKJslWajKwPQiOmiTL0zz+eH64v/vjA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrgeehtddgudeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggugfgjsehtkeertddttdejnecuhfhrohhmpefirhgv ghcumffjuceoghhrvghgsehkrhhorghhrdgtohhmqeenucggtffrrghtthgvrhhnpefgke ffieefieevkeelteejvdetvddtledugfdvhfetjeejieduledtfefffedvieenucevlhhu shhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehgrhgvgheskhhroh grhhdrtghomh X-ME-Proxy: Feedback-ID: i787e41f1:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 25 Jun 2023 05:34:03 -0400 (EDT) Date: Sun, 25 Jun 2023 11:34:00 +0200 From: Greg KH To: =?utf-8?B?5p2O5Z+56ZSLKHdpbmsp?= Cc: David Hildenbrand , "akpm@linux-foundation.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "surenb@google.com" , "gregkh@google.com" , "zhangshiming@opp.com" , =?utf-8?B?6YOt5YGl?= Subject: Re: =?utf-8?B?5Zue5aSN?= =?utf-8?Q?=3A?= [PATCH] mm: vmscan: export func:shrink_slab Message-ID: <2023062554-gecko-cyclist-0c78@gregkh> References: <20230616092112.387-1-lipeifeng@oppo.com> <33eabee3-f6f4-ee0c-d74b-98815a9567c4@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Stat-Signature: oapjecj8owatn9b15sitmyggyhcugqwp X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 1AF6F18000E X-Rspam-User: X-HE-Tag: 1687685644-466664 X-HE-Meta: U2FsdGVkX1+EZh5YVJEr+SHxABmJE3qKKWD7uYqVmEbEcdKbH8VR8vntc6PLVsPRqpOHN4z1TIJZxin9JX3hwiKlb78XtHRsiothn9vsBbT9tMxXHBOpAfVby6zEZTLc38ZBW6HdILJokk8ra+t69K8bm5sc63W4Emt8j5DilEAWKOVheF23fJyBg+BQQjtWpWssEgIBrSZV5R7/G4LvOz81DyUhBPejCcw3fOWCdMQPizGNrBDbcAeDsC75OL2V/VW/xWmdxfqr90dZWJ/iBL+4tBHR7kY2y6qUJIpFBKYayFZyRdpozdoW7WUWdhZ7SFkdtSWQ1GCIThG8Lczb/DHA4izThuZZv7kuwly/LwHjRXr9c0GcPOF8FmnoZZ3CoXjSpQH3K+uan5BRi1/4s2LCQQeRVax9qLplxdqGMRh34ULNJtk+qcxYEEWvAPjmhtJ3C/k4ahsyj9f4cD5v/vQ0VFgRhEATOpp3QXILuYcUySk50Ckh42hSVRIL87EQz31TWnyS1rX0iJZRm9I0aJg0iPYE11Z+0sh0GpmwzbcduzDFslBPXaLYKDR6SR2EeRQbgZopV7NcZfUpdoy5givhOgfuwBNn+HlX5kEyGcIQneo/G3YmtT4OElQcmfPVkTkKsa2u4Ze8FhlAmSdyvcd4UdBT2ifty4ifXTXEXvvCKEtF22k/iGuSvexE2dvZsx4T00Ez51LKsQc4N+bzHldig0uz3byiM28RioNwnIKjVs8o5LN7S0XXO3BQo0ssWxvhJ6D/QWULbqmc+qNlIF3h2XV3ccnE9TmjMGdiCQ2righkVhkJc72M0/W79+1Y1vgSxlL9krC27FPLkRgZSj5kpbLWoIg/Q5aCV1rLQl24IWmLzu46GiHCvcKO/C0gmlUKBtIaQZLIZBLhuwDJOLRMVcR4NXFWuQ8DI47KEWh6XvKmeobZ/CNf18J0rhSBTBkB7wwO7vFwcj+Obad zs8QYv5S dXF8JBoM3MoIChbJpkzj/DT6myjkQgxCGuxd+6T6T+wUXU/S6b54UWhuOsSbWtsefWCdM0OZKjZRDJd1SazSYnaXXqUyt3X5OaYFUlWEE585QKZ9eG1cLmyQVIZb/CuJlxtAWEo2Pq0Xes9ONp2G/R3mSn6lss+W5tsfn/gQS4xWbZpOURhRh+Fjy2gmNoGH6Wjlh8cxtOzUraR3AYQEvAklf67KcW6LiJYtN3mDn90IKY3zjUYQG8Nw0iKHD9zPhbYwEiMydI12CJls1+pr7sAYQ1QtyLyU9QGA+7AwPsxjQbnSllYEKYC09BX6d5ehmPKNAavAjdXDMKvpRBkkOaNQtCpvISv2ewo+eRFO/hJZwJfc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 20, 2023 at 03:05:27AM +0000, 李培锋(wink) wrote: > On 16.06.23 11:21, lipeifeng@oppo.com wrote: > >> From: lipeifeng > >> > >> Some of shrinkers during shrink_slab would enter synchronous-wait due > >> to lock or other reasons, which would causes kswapd or direct_reclaim > >> to be blocked. > >> > >> This patch export shrink_slab so that it can be called in drivers > >> which can shrink memory independently. > >> > >> Signed-off-by: lipeifeng > >> --- > >> mm/vmscan.c | 3 ++- > >> 1 file changed, 2 insertions(+), 1 deletion(-) > >> > >> diff --git a/mm/vmscan.c b/mm/vmscan.c index > >> 6d0cd2840cf0..2e54fa52e7ec 100644 > >> --- a/mm/vmscan.c > >> +++ b/mm/vmscan.c > >> @@ -1043,7 +1043,7 @@ static unsigned long shrink_slab_memcg(gfp_t gfp_mask, int nid, > >> * > >> * Returns the number of reclaimed slab objects. > >> */ > >> -static unsigned long shrink_slab(gfp_t gfp_mask, int nid, > >> +unsigned long shrink_slab(gfp_t gfp_mask, int nid, > >> struct mem_cgroup *memcg, > >> int priority) > >> { > >> @@ -1087,6 +1087,7 @@ static unsigned long shrink_slab(gfp_t gfp_mask, int nid, > >> cond_resched(); > >> return freed; > >> } > >> +EXPORT_SYMBOL_GPL(shrink_slab); > >> > >> static unsigned long drop_slab_node(int nid) > >> { > > > >It feels like something we don't want arbitrary drivers to call. > > > >Unrelated to that, this better be sent along with actual driver usage. > > Hi Sir： > > Virtually, we have implemented async shrink_slabd isolated from kswapd and direct_reclaim. > The goal above it is to avoid the sync-wait in kswapd or direct_reclaim due to some shrinkers. > > But the async shrink_slabd was only applied to mobile products so that I didn't make sure any > risk in other products. For the above reasons, I wanna merge the patch to export shrink_slab > and the patch of drivers would be considered to be pushed if I check all the risks. > > Some informal code files of driver are attached for your reference. You have to submit this as a real series, we can not accept exports for no in-kernel users (nor would you want us to, as that ends up being an unmaintainable mess.) So please resubmit this as a proper patch series, with the user of this function, and then it can be properly evaluated. As-is, this can not be accepted at all. thanks, greg k-h