From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D613EB64DC for ; Mon, 26 Jun 2023 17:35:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 62F518D0007; Mon, 26 Jun 2023 13:35:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 58F758D0006; Mon, 26 Jun 2023 13:35:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 430008D0007; Mon, 26 Jun 2023 13:35:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 1E2028D0006 for ; Mon, 26 Jun 2023 13:35:34 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id D7C9FC0807 for ; Mon, 26 Jun 2023 17:35:33 +0000 (UTC) X-FDA: 80945600946.19.C2A0466 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf05.hostedemail.com (Postfix) with ESMTP id 0BBAE100017 for ; Mon, 26 Jun 2023 17:35:31 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=UixsKVyP; spf=none (imf05.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687800932; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=E+4oLVAPfstR5U6aMi6Troa+YNi9gddz/xau+Gpg+rc=; b=7EGvbbOlqf6ATkbFp1efyOld6GOLkEUe/MxR90ZLKjeI53GT9xk3SctFnMw98SXtyDoaQL nSrR02vhSXqUqnyqHnfQ97Qu8m/oxDgxI+1YPlzSNt7mqymsyDf+gnL7XHF/HmWza8iw28 bJUdeIlSbEiv4Vy7IeYJnhWhn+EUdO8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687800932; a=rsa-sha256; cv=none; b=ubFrAJqcmRPrwfBMWM2aQrSxx0FDYk1aGyZVa3We/78U+L6vyrmqtyF6kRvVjLoHoOkuJD zRVgSuHZ+cqjauB0mPsSmP2AUUlz9/+nKCYYQSOVBcMGT5oI7FG9wpjBmR7r9s51icl/wk tsE1HkY7+aEc7nkMGR7ycJ9pWeiYsf8= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=UixsKVyP; spf=none (imf05.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=E+4oLVAPfstR5U6aMi6Troa+YNi9gddz/xau+Gpg+rc=; b=UixsKVyP80nb0Gf7F4Lg+jN462 veiCIiZ5m1gznewobjOw1LIlCVl+NQ9bzKtGc1cy/FIFA2ZFOyC31yskGu3ZRnQRQ486TqTOhj/gr MYy4BGRtCU3MWPXCVKFnpYRI0SO+7rxcxT4MHuv18Sude5qsPpa5V0wVCVDJPMg+CxWSEWOj5iYYW AJDD8UCC+LOhQrktHVtCdUQ+V85q2O0pIp+RIDy4myAwlxwJ/KnWBqgsQgybdKyrahLZIt/KPAliX Z7BL5LWIbRipCNRi/kU84/66Ojv2G0K94IDEtnbMk2QxnYFxyp6hwCZ51e4XG35VOJT7z4XE1c+22 +qrDsMow==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qDq7X-001vV7-Jz; Mon, 26 Jun 2023 17:35:23 +0000 From: "Matthew Wilcox (Oracle)" To: linux-mm@kvack.org Cc: "Matthew Wilcox (Oracle)" , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Jan Kara , David Howells Subject: [PATCH 05/12] pagevec: Add ability to iterate a queue Date: Mon, 26 Jun 2023 18:35:14 +0100 Message-Id: <20230626173521.459345-6-willy@infradead.org> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20230626173521.459345-1-willy@infradead.org> References: <20230626173521.459345-1-willy@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Stat-Signature: pr76cpzognna866cdhxrr79yzyq9xrmy X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 0BBAE100017 X-Rspam-User: X-HE-Tag: 1687800931-256974 X-HE-Meta: U2FsdGVkX18DiDWR3n6mEHbXgXO9E1/gilp+OOddxKsro3toUz0kDjPUE99zu9Bp8E7vuzM4P/v+uGFqMNZcqSEZadP5MJTCvV0XtiLKkd/Sa+zTwYBPWW7R62gyRf/zV8vYEswdKiPHTG+OdI5j13sMs6evHxcjoFgSa0NOCI7B3Oh0iPUCUa5o36/gb+4IP8dG6sdfPRiPbE6c982ziAIJuKsTBB95wX66HbJ6JsCG5nzXrkX5xKGYbjPSzjd7Y3HNcyAQ5KNPZCaIy7TmIOUyDnxjk7H6/upPxiqaAvM8vvoM3r6WFmIhG5+bUy0PyLP/aQE1AJ6Htv1nXfdXy23EWVKQrBrZ53Zkw+offe0cVcFrr9mzVtM4cu8xk/DBnSMaE0bf6pddMbd3lsVGK++R6jjzQKqRWBd6Di30cYohoe4Y07aLU3CWwWCf3xAzKE93+w8Uh+yXK5HcxKrCcRJQHgcvsNV4EuH0m6oxPyl5e4msIF3reX4A7wg+bb4PiWW2xzX4mlxU60RdPYXaC9SgqqXeueO1j4Q5U1fktAFFyfNVnCKqCsqfsn3xvgG+EPR2WT+fdFIwk7MkoJLFML+CyW6XOX2CX6mjKJnx++G6yBeWQIqThDVuzLBR5JsLI3Mat7APlBwPS1AgwJbjZg1Ffi9gWVLXvW17DL5bnmjzS6LcCcEw6zBEmfHJS/0wFFGqrhBE7QZ2GngamoTd+f5nHmj87c3q8qWwtL53vRQLXjprXDCxfOF1eqWNfm7mHydQHnYpYOW0wwlEg4cFl6bATks+BHccPC8nygRiUwLO+T1VsF4k/6+5yQaO7utBYFpFZbCbwzLQIEIqr2/oIKtQOpQNz4AZkqSEAg06I1gJcaTpABqO2G7qxBpdULEGmqHeVOo64OoiCwjuRii2M1UHgwNG9SV1sWCdv5Soa426zfmRzkjAsaa11gaGPdZOyKDrgdsApJVYFezL47D GfA+UZxS n+S+cI4cPr2LfvJIPI7oYVy0Kjrm8lEeOIRiZYXj0e+NWj3rsPSw1TvkqD40ileFfyrk/+C2faN4jTARtemSat9NrtCqkLeoEmiLf+PA4CHnoRWVTdyHCc66FqIpk+fvD2zHtbzP1Z6Tl8KZIBwc/CSa5s/9gDgwg4aPrIbQcbBpHhgCmUlwPryxCYw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Add a loop counter inside the folio_batch to let us iterate from 0-nr instead of decrementing nr and treating the batch as a stack. It would generate some very weird and suboptimal I/O patterns for page writeback to iterate over the batch as a stack. Signed-off-by: Matthew Wilcox (Oracle) --- include/linux/pagevec.h | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/include/linux/pagevec.h b/include/linux/pagevec.h index 87cc678adc85..fcc06c300a72 100644 --- a/include/linux/pagevec.h +++ b/include/linux/pagevec.h @@ -27,6 +27,7 @@ struct folio; */ struct folio_batch { unsigned char nr; + unsigned char i; bool percpu_pvec_drained; struct folio *folios[PAGEVEC_SIZE]; }; @@ -40,12 +41,14 @@ struct folio_batch { static inline void folio_batch_init(struct folio_batch *fbatch) { fbatch->nr = 0; + fbatch->i = 0; fbatch->percpu_pvec_drained = false; } static inline void folio_batch_reinit(struct folio_batch *fbatch) { fbatch->nr = 0; + fbatch->i = 0; } static inline unsigned int folio_batch_count(struct folio_batch *fbatch) @@ -75,6 +78,21 @@ static inline unsigned folio_batch_add(struct folio_batch *fbatch, return folio_batch_space(fbatch); } +/** + * folio_batch_next - Return the next folio to process. + * @fbatch: The folio batch being processed. + * + * Use this function to implement a queue of folios. + * + * Return: The next folio in the queue, or NULL if the queue is empty. + */ +static inline struct folio *folio_batch_next(struct folio_batch *fbatch) +{ + if (fbatch->i == fbatch->nr) + return NULL; + return fbatch->folios[fbatch->i++]; +} + void __folio_batch_release(struct folio_batch *pvec); static inline void folio_batch_release(struct folio_batch *fbatch) -- 2.39.2