From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E059EB64DD for ; Thu, 29 Jun 2023 23:43:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CE2CC8D0002; Thu, 29 Jun 2023 19:43:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C93448D0001; Thu, 29 Jun 2023 19:43:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B5AD68D0002; Thu, 29 Jun 2023 19:43:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A36F18D0001 for ; Thu, 29 Jun 2023 19:43:26 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 9474B1A09EC for ; Thu, 29 Jun 2023 23:43:23 +0000 (UTC) X-FDA: 80957414286.01.FED77D0 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf03.hostedemail.com (Postfix) with ESMTP id EA2C220019 for ; Thu, 29 Jun 2023 23:43:21 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="FAwxhF/s"; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf03.hostedemail.com: domain of kuba@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kuba@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688082202; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8DbnrhrxbHk10usug3uWD49kSFa46KFkJtYysT+9Mvs=; b=eMu8iP3tBzAvDbdDJodueKKNyStM4VqaPDo7G5nxBxjOTuLYYjvv9v+Vq7mqELVFxYt8MZ oddmFLM56aGe9NDUCrLdgWWSIfXTLJd+Y06liDTE38BXUklEyc8bEk5J28OwKZPiLQoIc6 yFe2ZpAAmZuqJpFMdshJQ2b2xD4JWNo= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="FAwxhF/s"; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf03.hostedemail.com: domain of kuba@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kuba@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688082202; a=rsa-sha256; cv=none; b=8KI19I9PD7N/4f8f36O9kWZujU4NlB6UzSEqJIqPJjvpOXWeoNPHJ5CJtKHhTxXIlxu5Mq VTP2pJ0gBnMPddle57KX08DqQqkxSsHdRmU7DqSBVeYnLZMVk+/dzidnR51SZq15ghCc49 Jq7+kU830fUT1hwd5kSl+/8RlzImxe8= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B6816615A0; Thu, 29 Jun 2023 23:43:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 76DA5C433C9; Thu, 29 Jun 2023 23:43:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1688082200; bh=KIYW1lUTJeQEkbIElm6us4axZkg9EmgFSwq92AAsf6A=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=FAwxhF/sxTGaYZAjCNqCnXzM7+1IK6BDzDB725t8iS0GHPDcS1bhTM8BwwZl6JeVx 61w93PxTHNhifhYhOawcWoYmxCqnzubKSubp9DLbQgU5P8G5Z/IdzpHEVRCTKsikYr I7EkcgcYNjVcKq2Id/oC2GgeGbmBqOPfYQqZC7PtYzGfRG+4O34EytEQW0oF0aqKAQ 803uYRUYut+Nfy4yz0+l6nAZLT68yUufkg5pNe0mCuD15bJ0+Q2Vj1FQ3H5TtaMdTm SmurcO0ub7iNkhFWFvhRR4LvPCC0uoam7AqUJfZjdPBphlYAfCZynAHlsqyoRcpell xnaG0uRIZVnag== Date: Thu, 29 Jun 2023 16:43:18 -0700 From: Jakub Kicinski To: David Howells Cc: Aurelien Aptel , netdev@vger.kernel.org, Alexander Duyck , "David S. Miller" , Eric Dumazet , Paolo Abeni , Willem de Bruijn , David Ahern , Matthew Wilcox , Jens Axboe , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Sagi Grimberg , Willem de Bruijn , Keith Busch , Jens Axboe , Christoph Hellwig , Chaitanya Kulkarni , linux-nvme@lists.infradead.org, llvm@lists.linux.dev Subject: Re: [PATCH net-next v3 10/18] nvme/host: Use sendmsg(MSG_SPLICE_PAGES) rather then sendpage Message-ID: <20230629164318.44f45caf@kernel.org> In-Reply-To: <58466.1688074499@warthog.procyon.org.uk> References: <253mt0il43o.fsf@mtr-vdi-124.i-did-not-set--mail-host-address--so-tickle-me> <20230620145338.1300897-1-dhowells@redhat.com> <20230620145338.1300897-11-dhowells@redhat.com> <58466.1688074499@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: EA2C220019 X-Stat-Signature: yhhy34m8iifos1m3hrjpgoe56qcnih53 X-Rspam-User: X-HE-Tag: 1688082201-400472 X-HE-Meta: U2FsdGVkX19muucGR5xD6nCwxb21CBk7z0XU8u+L3eLQ69UbF6ILMDizpf4w68A5qdrhJfUJ+TsmtjcDRuxS4Aip0ayqIFKRo6hY44OmGw+5r+r7CFm+bjjF330UkDBBz7eFCDVGyGDfmDlogA6/PflKSUB6fdCzGQDkq+O7LGFzUljTszzfxfRj6Quhd6IeArhn6BhfAOMXUNJ+hid3Nlu1onX1NwoxeFrT+0tXw/JMgj3HIobgqzfab6G2lRPfCAMLd/g4Pn4mpfZiB0Dc0mCwngAhBwCBz1Dyc+ECr+I/2M3sku2bZEtNdU04XK+yyIiLBKqIIAucBxGLqleyJvZVYE7GF0NxQj70vqRHC4gs6dh4ii1RaGtyxPKHw4zs30wASB61ZCTVySPb7lhiYmDYMg/MYM/xIXq/fu4wWJilyH9FP0fPwWkVsL2/AwDlY503PXxn5s06196GXKO5t1fn2bAEdhldRgXaHfqCMkTXChjixnv3PSe2Zd36YcxDfgHl6OkvaydfQU6/pvHah0yyPVb4c/VUcW5DtTgbm1RnXb8N4dvt+sf2BUEuhpGCpraXiQStkkU+4BTjJa0KmnnYFAKFdtchVPP8s7WcFyHsQIaRkr8MKBm+UPsj53XvyThufTKMP7iwn6w4+6hEfb9+fO0B3YHcWiyUZ6/LgQ2PZqS+PrY4NEg7Pf1a2oC8BCR469jAJHcWYUd6IJtQBnJ21qaQAhKWf+IXaqbdE8NBuz4sjrOwzdQoSMDnhIpH//zhcNaankWHSAr+DKNXExZ4/MpsSx4zLG3W3nOAA3wZNuZ+LaLjHHFkqHeNpYA/Ug/3D73Sm+ENCoqOK7GWpbgRbZhVRA+4zzQTe6aUyQvZSDNrRjk9Ry88S9mR+I3l2TB1P4Wtj58NVI9rDaT+lNQK5yIl0HagZb5CB9oFCV6NQkI+FA+0OcGJNV093DP2t+/Nfj0SdBIz7I8Ggdl +8mJYUnc cv5EYI0yHY1TDz8YYhJueE8rRjac9P3LjfHNgwGudjmRec3kvFUBg7c+ZxGXsoIUdC+ABqo9hbTOXoe9iLsyVGp/hLx4mEwI9BxqFhmC29dOhD9Gw+JKpq4fl8SA4yI6rRClyRXi3amy5to/VwZkI3SlVfO+hRAXkcoTn4JpL+7UZB3HuuoPIFyfkxbRAAHfysDSoSKNKIx+CAgg3rc+2FdqghoJbyrBt9+1HjDNt1OBggPL+iSTXqmZSXhEqQ3D042o5sfzOFV7eUdJxKE28Jrj0zvwdxt/C6pgFqtaGUqwPWgg/86xVEtU5mT3H3Bh04LcxuZUsm3nBqpIA7fckKQRWrGIqr4UCSTGSKJtCxQ+tiy58cN13adreFazUHL2U54Mjb3eTKepvY6llIOVcSN3Oeo+GbY9oTbgh X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 29 Jun 2023 22:34:59 +0100 David Howells wrote: > if (!sendpage_ok(page)) > - msg.msg_flags &=3D ~MSG_SPLICE_PAGES, > + msg.msg_flags &=3D ~MSG_SPLICE_PAGES; =F0=9F=98=B5=EF=B8=8F Let me CC llvm@ in case someone's there is willing to make=20 the compiler warn about this.