* [PATCH] mm/mm_init.c: mark check_for_memory() as __init
@ 2023-07-10 9:37 Haifeng Xu
2023-07-11 18:19 ` Mike Rapoport
2023-07-13 11:21 ` Anshuman Khandual
0 siblings, 2 replies; 3+ messages in thread
From: Haifeng Xu @ 2023-07-10 9:37 UTC (permalink / raw)
To: rppt; +Cc: akpm, linux-mm, linux-kernel, Haifeng Xu
The only caller of check_for_memory() is free_area_init(), which
is annotated with __init, so it should be safe to also mark the
former as __init.
Signed-off-by: Haifeng Xu <haifeng.xu@shopee.com>
---
mm/mm_init.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/mm_init.c b/mm/mm_init.c
index a1963c3322af..a313d1828a6c 100644
--- a/mm/mm_init.c
+++ b/mm/mm_init.c
@@ -1737,7 +1737,7 @@ static void __init free_area_init_node(int nid)
}
/* Any regular or high memory on that node ? */
-static void check_for_memory(pg_data_t *pgdat)
+static void __init check_for_memory(pg_data_t *pgdat)
{
enum zone_type zone_type;
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] mm/mm_init.c: mark check_for_memory() as __init
2023-07-10 9:37 [PATCH] mm/mm_init.c: mark check_for_memory() as __init Haifeng Xu
@ 2023-07-11 18:19 ` Mike Rapoport
2023-07-13 11:21 ` Anshuman Khandual
1 sibling, 0 replies; 3+ messages in thread
From: Mike Rapoport @ 2023-07-11 18:19 UTC (permalink / raw)
To: Haifeng Xu; +Cc: akpm, linux-mm, linux-kernel
On Mon, Jul 10, 2023 at 09:37:50AM +0000, Haifeng Xu wrote:
> The only caller of check_for_memory() is free_area_init(), which
> is annotated with __init, so it should be safe to also mark the
> former as __init.
>
> Signed-off-by: Haifeng Xu <haifeng.xu@shopee.com>
Reviewed-by: Mike Rapoport (IBM) <rppt@kernel.org>
> ---
> mm/mm_init.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/mm_init.c b/mm/mm_init.c
> index a1963c3322af..a313d1828a6c 100644
> --- a/mm/mm_init.c
> +++ b/mm/mm_init.c
> @@ -1737,7 +1737,7 @@ static void __init free_area_init_node(int nid)
> }
>
> /* Any regular or high memory on that node ? */
> -static void check_for_memory(pg_data_t *pgdat)
> +static void __init check_for_memory(pg_data_t *pgdat)
> {
> enum zone_type zone_type;
>
> --
> 2.25.1
>
--
Sincerely yours,
Mike.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mm/mm_init.c: mark check_for_memory() as __init
2023-07-10 9:37 [PATCH] mm/mm_init.c: mark check_for_memory() as __init Haifeng Xu
2023-07-11 18:19 ` Mike Rapoport
@ 2023-07-13 11:21 ` Anshuman Khandual
1 sibling, 0 replies; 3+ messages in thread
From: Anshuman Khandual @ 2023-07-13 11:21 UTC (permalink / raw)
To: Haifeng Xu, rppt; +Cc: akpm, linux-mm, linux-kernel
On 7/10/23 15:07, Haifeng Xu wrote:
> The only caller of check_for_memory() is free_area_init(), which
> is annotated with __init, so it should be safe to also mark the
> former as __init.
>
> Signed-off-by: Haifeng Xu <haifeng.xu@shopee.com>
Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>
> ---
> mm/mm_init.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/mm_init.c b/mm/mm_init.c
> index a1963c3322af..a313d1828a6c 100644
> --- a/mm/mm_init.c
> +++ b/mm/mm_init.c
> @@ -1737,7 +1737,7 @@ static void __init free_area_init_node(int nid)
> }
>
> /* Any regular or high memory on that node ? */
> -static void check_for_memory(pg_data_t *pgdat)
> +static void __init check_for_memory(pg_data_t *pgdat)
> {
> enum zone_type zone_type;
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-07-13 11:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-10 9:37 [PATCH] mm/mm_init.c: mark check_for_memory() as __init Haifeng Xu
2023-07-11 18:19 ` Mike Rapoport
2023-07-13 11:21 ` Anshuman Khandual
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).