From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50B9EEB64D9 for ; Wed, 12 Jul 2023 03:45:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A8E236B0071; Tue, 11 Jul 2023 23:45:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A16876B0072; Tue, 11 Jul 2023 23:45:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8B7916B0075; Tue, 11 Jul 2023 23:45:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 78C5A6B0071 for ; Tue, 11 Jul 2023 23:45:42 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 44F9D40490 for ; Wed, 12 Jul 2023 03:45:42 +0000 (UTC) X-FDA: 81001570524.26.694A46F Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf30.hostedemail.com (Postfix) with ESMTP id 8013D80004 for ; Wed, 12 Jul 2023 03:45:40 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=GD62fC1a; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf30.hostedemail.com: domain of kuba@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kuba@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689133540; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uKdTG34u5sxrIlLERlJ62Pl/zXR/bSIyafqvy2bsPOQ=; b=LhwU61YXkdUH+7M4x/eLijMMCt8ybuYcoK1AWv/+QHRVwHdWd/mOxOwLlbV4oqwHq6JLaE jWYkOwa95iAzXrnkkrHMtFGUPCtDr2mnICVJqNO6W8/COfo+EY4V+l2PKH5b59CaUuHORX 1Utw6eTvkD9M3QX1ZotRLupzaUlEdEA= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=GD62fC1a; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf30.hostedemail.com: domain of kuba@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kuba@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689133540; a=rsa-sha256; cv=none; b=cK9yxu2HlLVca/MWqhnO6q2PkL43VDTOLX/5K5dl3Za2leeCwzovjMUM4S6dMTs+taSZrx cC0pErLVXSxMY6oaFqVGBqHK047TvdVzBLekTuUKvBVrFcy4qGpXgzhgJ2lYdmpcWakFaG AbB0mP/KW7ZT24XIuSZ4J8Sd4xza55o= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A7F3060DCF; Wed, 12 Jul 2023 03:45:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 36885C433C8; Wed, 12 Jul 2023 03:45:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689133539; bh=kV1aAg4a4cV9uuw2PocMUWykoJKk/tyIh0MW/t13PJs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=GD62fC1aPLT4Chb4Q2u79JyVL01BCjTdBo6PhaMSEQghTJVJ2XMfb8K4IA+5zMHhm Jw5/r04qhJG3aBR8GiU4bqed0fsjfTvIcbfb6yTVO/VaN9jYHTc9bLnaqE6xisBuL2 DFlYzM4h3GDQcPSUU8/iQpd3F3709bWbKmrIjdADvjUlCi170bJr8v5f93PdOLp2wg nARXUSE+et76TRzo+W1gxu3XwSJZf7jgKK72NG0sQ02KHSbo3GZ+nPTpLCh6eWNMR1 38TqTfOPM7T4rqJJpU4+HxdOul3kyGc7D8rFNUpml/fi7eSw5LpV8FvkUIEcjwXB8S 4b6xx+Y7a3Kvw== Date: Tue, 11 Jul 2023 20:45:37 -0700 From: Jakub Kicinski To: Abel Wu Cc: "David S. Miller" , Eric Dumazet , Paolo Abeni , Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Andrew Morton , David Ahern , Yosry Ahmed , "Matthew Wilcox (Oracle)" , Yu Zhao , Kefeng Wang , Yafang Shao , Kuniyuki Iwashima , Martin KaFai Lau , Alexander Mikhalitsyn , Breno Leitao , David Howells , Jason Xing , Xin Long , Michal Hocko , Alexei Starovoitov , linux-kernel@vger.kernel.org (open list), netdev@vger.kernel.org (open list:NETWORKING [GENERAL]), cgroups@vger.kernel.org (open list:CONTROL GROUP - MEMORY RESOURCE CONTROLLER (MEMCG)), linux-mm@kvack.org (open list:CONTROL GROUP - MEMORY RESOURCE CONTROLLER (MEMCG)) Subject: Re: [PATCH RESEND net-next 1/2] net-memcg: Scopify the indicators of sockmem pressure Message-ID: <20230711204537.04cb1124@kernel.org> In-Reply-To: <20230711124157.97169-1-wuyun.abel@bytedance.com> References: <20230711124157.97169-1-wuyun.abel@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 8013D80004 X-Stat-Signature: jiazg46wxkcm4ckobr41zq7zbw8o4mmk X-HE-Tag: 1689133540-953998 X-HE-Meta: U2FsdGVkX1+StSdaJjT8d7ZdyM4osN9GtB+HrWvb3S9ZA7QtnRqkPJPegPrH+vcaJeOvHbgh+buX+I5NCJHTIyXTifIQ1yPMKCmZ3KY9HEomyTtH0fQkBwErOcHK0r6cRQ8Jkv3ekysw4XM0Yh8B3SNzkGMp6ph0ckFxxRAh+FvY00kfcjPwqqhth9gsUbwFDl3Pku5VxvVGi5GxXJRPRZVphi90ihDlOa8oro8GdY9Z/tv0CAAF7T7w30OsEYfBFBlZlujYDJ+ZWNT3YRsW1yRJlGIHAsQUaw5Vqa1/EYP/1zeKDjphMB5Get4Z9/5Wv3gaWLKz8awx2FqgFyjOaOH2n276/pZjJ5V/bnJCOrD6XIel938znb2iZ425EMNhwpmpXqohbpviKLavgwI+gnURNUuSEMuYp4soLqSpj4CjxdZVmqppys44d1xj6tdDwJNOkGXa7V2RlGLz8bwncoTOy5TDoPo+Aon5P1qYlfznsIviDP6FuxrO2QeHkEdPlBxriz/n873dlgLOfc81/Y31COWesOy7Pr1I/ChLgUkaIV9rKLpUkZANbPgXpaJ9IwRjhY6zqK/plZL15rA5JOLbzNW5xxpHll9q2ZiVJrdoXFQoKrRIv29SZWFPwZd2nmecT99MFUeXhYGuheUmK4t738/Z1rNJ+xK3si+09FtFromew74ISWGNZTHLJkzBDAYDUxbau0mmGexJrwqSJ6TqauSzSc5eNDqfooWPSnMsiau2SYz5uBcXcqPhWdgEMjHyYNehSJJdjlcnRkzyhohrsrUYA2bIlJSFsOC/Ql2qLi4OXvSWD6pp0xU+YGDKTUKgyoVrhhtGPp6pC+lmC/7X0uxfLX5EQly37WajXAJJY8ZmZefAuMRbULTK8TfnnS3DSeArvaOT+ZYD8phlCxA328XSfxqo8lRY2QGB05kQ+wI1OyLEDW9VX7h8HEK0xI4MBweIHbaPv3oIuAg 2Jls9fZG js1Ppiin0VjfP1IG9NcxYd8i0LMgy46RrWkrzJ5md8OoC7kuaI6iKXahvkQfCUCGdh10i8gtg1LeFA19UK9sxA8H19Cc4fo41haWQwii40m30D7yQOOIyLXbDk8Kz9VG6aI6ZRlsHepq6pPgtMGluSxBKn4da2GYTuJUXBij14nh1Ie7e3tMx5RkZW7tbylZAAWhfnrHkThCc6xycEvaci8nqYoNX3r3NC/I0dSYe04R6tnZcCCQnqE/ZOazoKUAsG0xfZSfo8H+G6HCKPc1SCZkvVrMHtMXuq21sP37bRFIAR/Gd/F+2zuLoMFw8Q50F+ACV9PEaW2cq4T8WlQgD6O1ke3lVlCRWbjOvIRkiJEcHMNZXBf15oYU1jUOhDYBclI6i9Yl0kJEclQl5RayAdNfLT0uaNyXCnswYrUfgh/Z9yK0Om+Wh9kOuGrtZYz/eucfINTRcLacHXCKcSApIGu4RQuOylih1hbyvyagri7T893FqTgBTXc4uh+AehV6tmX/K+Ug80IlZI4gwgkVb3h4AXN176+ZecqDLc70Fu9/0h/mWOJJGtMpf88O5UOKsZ+MZOcqPxJlJaYP88sFq8eQPXQOs94B947rL1MWyRtBgagVQjlic0e+6N0QSH+aturTBLt2MapGY+0k8llL4kIWExg1YEXks3ec0sgfrnS0jLCf2i/oMIs4J2g1DnAh+LA0RXglVq3/5J1woW5Y1VEsKxzJMP0kuw5JqG0wcE6OG9SmJe4kYHwOxEKl7Ofa7uz4srTM8QfGLtcQIm9SbEGdXLImZYXKExX511wgsfB0LPVfDAmz76JHYEnTNti4ADYfjvpG876q6Yt+bUhFw6x5BA+ay69LF8OGPetX4oWwebOD6a/d4jyBo6pwR/71QTjCDHI3ycN4PwG7s1jdxym1IFwQJGnyGm6ERilZc8l9SByLDtVUW1pNiZJZRmzp0ahRRcI6xqChKmLX5973plJNLeKhL P9rCrYQn veAg9tgwOQKd0xNVcQretBlm0CCsvd0rhjfB3ayYcv6f+Rra8CGQ+WwjkAqsRDbG1zWEvnjutqIQg2DlxlZFACXB1KR1+5yzrJLo+cWiHW5/XaypeyQxZKtF7iFtNKoK0c8UwyiGECdnj/sijMPtCDZzYLzwHL8pHVXl+r4FLTn89JpYr45wULtFMP9QjnKtPhVG++0w7McYwt6AmJ5GoSRW97TMTuXlDr36vtnhRiRNcVsceSaWGHwMRY5wroNoUXXGFFuQZPaHootHDi3w6TEhQuQxbGKHwqoA6W4Nh2HIu11iQi7+j7neBXYykIwg X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 11 Jul 2023 20:41:43 +0800 Abel Wu wrote: > Now there are two indicators of socket memory pressure sit inside > struct mem_cgroup, socket_pressure and tcpmem_pressure. > > When in legacy mode aka. cgroupv1, the socket memory is charged > into a separate counter memcg->tcpmem rather than ->memory, so > the reclaim pressure of the memcg has nothing to do with socket's > pressure at all. While for default mode, the ->tcpmem is simply > not used. > > So {socket,tcpmem}_pressure are only used in default/legacy mode > respectively. This patch fixes the pieces of code that make mixed > use of both. Eric Dumazet is currently AFK, can we wait for him to return (in about a week) before merging?