From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70F6DC0015E for ; Thu, 13 Jul 2023 15:05:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DB490900036; Thu, 13 Jul 2023 11:05:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D64EE6B00A4; Thu, 13 Jul 2023 11:05:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C2CD7900036; Thu, 13 Jul 2023 11:05:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id B2B1D6B00A2 for ; Thu, 13 Jul 2023 11:05:39 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 62847C025B for ; Thu, 13 Jul 2023 15:05:39 +0000 (UTC) X-FDA: 81006912798.17.AF42E87 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf07.hostedemail.com (Postfix) with ESMTP id E91F640127 for ; Thu, 13 Jul 2023 15:03:17 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NG3UF1Oh; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf07.hostedemail.com: domain of mst@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=mst@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689260598; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cFIn1CK6FnjNQCiz1JGiV9ILeppGAa06PwBz7dUeBjo=; b=OcFPLty/cSjzmdP4izx25gQka0+uF0+s7PlRr1u0Zx0Oh+aygutrMPfcy1RtONdeZ9dsI4 /j4RjF1IZWUE6WwC5Y85nLVbt0aTYP7gScv5ak4BbuB0wFakBeDh7v50E4a0PgwKdy+/wQ yakZm+ipIpIRp02YW4WSu873jb8W+9w= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NG3UF1Oh; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf07.hostedemail.com: domain of mst@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=mst@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689260598; a=rsa-sha256; cv=none; b=j03xnpWay68dF/Gpf+R1qociV5reqqGaf/hguOxwlAK7aHXjUeHONl7d82muHAHgKkO3xZ FhEh66lAy+fpqDjdM+T5YyYYlp6jTNAqLn3IGYnp6Zh6JZlgxTnyS3Pgek7KWzIyN2I1SJ vqmd3fUxyHsi3DbR6WFfCHquqXdopAs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689260597; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cFIn1CK6FnjNQCiz1JGiV9ILeppGAa06PwBz7dUeBjo=; b=NG3UF1Oh+gXX4fq8PnzhTsDiwMz2hfQuecamTMoF2mbYqPLJQeTBgW2qTadiQNrKROZwAR o5Ppx7cFCf5w9XI1RhwgM82m7f0d5b6N7j9BpRI6ghqaFCDJq8OaP4Eg5L9vNdZKCn5pns GvAf6uALoh1bN05B3zXgWo2PWtvW09M= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-103-IZbkuz1tOU-uyOChWjgE8g-1; Thu, 13 Jul 2023 11:03:15 -0400 X-MC-Unique: IZbkuz1tOU-uyOChWjgE8g-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3113da8b778so540311f8f.3 for ; Thu, 13 Jul 2023 08:03:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689260592; x=1691852592; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=cFIn1CK6FnjNQCiz1JGiV9ILeppGAa06PwBz7dUeBjo=; b=b6IA6NKK3rgkoWvFw05TYXNlnNp85fbjQaI9PtusL5fQnaqs//w1ybhNTwvXFZ7AZv o9zmn8zNAb3JMFglVH4bMatT7VI4cwgAx2zjpU7JX0EW0tykbblkZ3NIvFzP2cLk5NbR uR3mj4CsErYc8Kr+puCTNp6gbsRThaJzwrfzo1oTQnbRQ2/TWzsFJ8UOj8yvIz5thOYr RmVeEeV7UQ4fJ7ivTER1i5TakpdRjhoDSeXIjbJdaMCA8itNyXJ2xR0UmcB/CWtPqrf4 oWsvjEIiUw2BfdZbQliB6a3uwyoULdE5FO7Lgy8lZTJ5A+ju0rPLMvH1xvphSkrgl11I JRag== X-Gm-Message-State: ABy/qLah3IRQ767j3KCN2njGPWAQ7aphF1uiFe6Db+ANOBDs98pVfdjD VOqZ/KskycvKnPgLI+9FC5dG1cOwzRjVSKclnkmCheVDQTcpcwTjl2YoLKTLV7jARdWyw2uCvco Zyor6WYADqjw= X-Received: by 2002:a5d:4990:0:b0:314:38e4:259f with SMTP id r16-20020a5d4990000000b0031438e4259fmr1715198wrq.37.1689260592557; Thu, 13 Jul 2023 08:03:12 -0700 (PDT) X-Google-Smtp-Source: APBJJlFaDnc8gCmS/iGE+xN/QIqC6uWksocY8EZzAU7Kes71J35fzl/XzIXfSkkw7EmyOclyba4XlQ== X-Received: by 2002:a5d:4990:0:b0:314:38e4:259f with SMTP id r16-20020a5d4990000000b0031438e4259fmr1715172wrq.37.1689260592174; Thu, 13 Jul 2023 08:03:12 -0700 (PDT) Received: from redhat.com ([2.52.158.233]) by smtp.gmail.com with ESMTPSA id w8-20020adfd4c8000000b003141e629cb6sm8119734wrk.101.2023.07.13.08.03.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Jul 2023 08:03:11 -0700 (PDT) Date: Thu, 13 Jul 2023 11:03:08 -0400 From: "Michael S. Tsirkin" To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, virtualization@lists.linux-foundation.org, Jason Wang , Xuan Zhuo Subject: Re: [PATCH v1 0/4] virtio-mem: memory unplug/offlining related cleanups Message-ID: <20230713110235-mutt-send-email-mst@kernel.org> References: <20230713145551.2824980-1-david@redhat.com> MIME-Version: 1.0 In-Reply-To: <20230713145551.2824980-1-david@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Rspamd-Queue-Id: E91F640127 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: wafr4sycgee15so3oqqhuhi5rtw63ot7 X-HE-Tag: 1689260597-927534 X-HE-Meta: U2FsdGVkX19ben6HqxZ/4LzHOv9dqFHFGijBZulHmeCWsm3dn2ZMIMhYJkIiIgpo/lmXV3oHW42vpsc4dyGf1bYylBq1dDHcA6olYJGrma5l+Iepe3Xr7uHEMO0OHbqNOvU/b+zVX7M88kyt7HhJlXXUTTdjRkL3LBjX//QedlQdUMguW+XE2GTN7A//nlmaa5y4yN5p1rZOhrYMii6OIlfJAD2wNZQxOmrsHpB1x5VzFlS/cyg22WAxg09eC2TxRDhyToyCUBge6BOJpTb6g2mqXDfpb0i30JpjCoJ7x65GtfL/mIE/3C61+JT0t/+KHu1V/3DP1jmuTijKlHKeHe50ArKPTH4hFUppX+AZ/16qGiqGCFja8yuL5WQc7C52VUj2E72urakOKSNsMTz7R0nEcEQlmfIROLzg8sdHiMeCJ2rmwXJxOHrBf+T+jQA7C+JJAsbDJ7lwHIlTBBruEi0Dg6cRYHIwovpS2/N9BUiqOC9J19PqnPqQN/a37njYZC8eV/u9Mg83dYsuLsyGAa9TFJZgzj8LNaOGdLbaZvHIfkEn5euDzNWBlgz1Ns9kl2yOvkeUZ+aFlJN4e8J19VAxGlpUMnCt8kfjton9MIzK8HFbstKzjemHwDOA2+w+wrk8Mw1hPgaDaQ9x27/T/wsm8XnDuvlsFVaBK3hVdtRiAbgf2lDqNkJCtwaslprLjtUXg5vjne0S5m4faTbdBPA24yrVip7I+jGGAfky74Nl2pluf/LHOiao4vWSiLOvUEMyGoDB0LQTi8l9QwE5ZfY7+SEEaVnnE4EbXejcszxhhO2zv5SzaMynisCqkbJCGW4IykdvMxNbdqMC1cu2bFOgOFNQLlRH8ACbBzU4wg1CE09hR0ZDTGaNbe41dhLsQlGL6nBjGnAmIsbQdT8fW41Dmw1Ih27moPaux+eq2cCI8Zj8hzyLaWEfHSby9F+EpjsDhqearQwC1QXJvFc AhiDKXb4 N90uptL5+zh6ckpaGwcstW3NbQo4XOUY7qo0YKdOcmyYqrelRTPFO+reNeP2ZCBjmY+NomzSDDM1o1idv73sQlSxpn1O2zRNvkfJfOQMP3Oo0O5SjDP66XS+6oc5bb8UUdfomLewPCXXgvxMue14Rr7cz2rFUVx+2aqi92E/ikRVSUUd3IpHplssk9+iMGEXyiqgAJFl9Rqu3fNIw+8AS8jMpgzbXBeoaSs56EyoVxoPvsdsmckfUpCwUfXOeinEtM+P6Up9rp58GB/wdHtuIPYntPmJEsH2Ile7Ar2mD67CH9BIJMItyLyefhY6OnjP+W7wkHbDrPpZ0xmEgwAfgxKyjVIQcCrNxLB+nLGE4XGFt37h4pl2yQ/X96A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 13, 2023 at 04:55:47PM +0200, David Hildenbrand wrote: > Some cleanups+optimizations primarily around offline_and_remove_memory(). > > Patch #1 drops the "unsafe unplug" feature where we might get stuck in > offline_and_remove_memory() forever. > > Patch #2 handles unexpected errors from offline_and_remove_memory() a bit > nicer. > > Patch #3 handles the case where offline_and_remove_memory() failed and > we want to retry later to remove a completely unplugged Linux memory > block, to not have them waste memory forever. > > Patch #4 something I had lying around for longer, which reacts faster > on config changes when unplugging memory. > > Cc: "Michael S. Tsirkin" > Cc: Jason Wang > Cc: Xuan Zhuo This looks like something that's reasonable to put in this linux, right? These are fixes even though they are for theoretical issues. > David Hildenbrand (4): > virtio-mem: remove unsafe unplug in Big Block Mode (BBM) > virtio-mem: convert most offline_and_remove_memory() errors to -EBUSY > virtio-mem: keep retrying on offline_and_remove_memory() errors in Sub > Block Mode (SBM) > virtio-mem: check if the config changed before fake offlining memory > > drivers/virtio/virtio_mem.c | 168 ++++++++++++++++++++++++------------ > 1 file changed, 112 insertions(+), 56 deletions(-) > > > base-commit: 3f01e9fed8454dcd89727016c3e5b2fbb8f8e50c > -- > 2.41.0