linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Baoquan He <bhe@redhat.com>
Cc: kernel test robot <lkp@intel.com>,
	llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
	Linux Memory Management List <linux-mm@kvack.org>,
	Niklas Schnelle <schnelle@linux.ibm.com>,
	Christoph Hellwig <hch@lst.de>,
	"Mike Rapoport (IBM)" <rppt@kernel.org>
Subject: Re: [akpm-mm:mm-unstable 93/173] drivers/clk/clk-fixed-mmio.c:33:2: error: call to undeclared function 'iounmap'; ISO C99 and later do not support implicit function declarations
Date: Fri, 14 Jul 2023 11:08:19 -0700	[thread overview]
Message-ID: <20230714110819.a7a06160032e0f4d350bf99e@linux-foundation.org> (raw)
In-Reply-To: <ZLCP0s5aRLLOfVYt@MiWiFi-R3L-srv>

On Fri, 14 Jul 2023 07:59:14 +0800 Baoquan He <bhe@redhat.com> wrote:

> > > All errors (new ones prefixed by >>):
> > > 
> > >    In file included from drivers/clk/clk-fixed-mmio.c:13:
> > >    In file included from include/linux/io.h:13:
> > >    In file included from arch/s390/include/asm/io.h:78:
> > >    include/asm-generic/io.h:547:31: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
> > >      547 |         val = __raw_readb(PCI_IOBASE + addr);
> > >          |                           ~~~~~~~~~~ ^
> > 
> > Thanks.  When I tried that config I got
> 
> These two kinds of errors have been reported many times.
> 
> This PCI_IOBASE warning will be fixed by Niklas's patch at below:
> 
> https://lore.kernel.org/20230522105049.1467313-1-schnelle@linux.ibm.com/
> 
> 
> Nathan told this when he reviewed by patch at this sub-thread:
> https://lore.kernel.org/all/20230612160237.GA199007@dev-arch.thelio-3990X/T/#u
> 
> Quote his words here:
> ===
> I believe that this series [1] by Niklas Schnelle should take care of
> the PCI_IOBASE warnings (which are not Hexagon specific), so there is no
> need to worry about them when they show up in build reports.
> 
> [1]: https://lore.kernel.org/20230522105049.1467313-1-schnelle@linux.ibm.com/

OK, I'll restore the series "mm: ioremap: Convert architectures to take
GENERIC_IOREMAP way", v8.

This kind of already-was-there warning causes quite some trouble. 
Attempts to fix such fallout are appreciated.



  reply	other threads:[~2023-07-14 18:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-13  2:57 [akpm-mm:mm-unstable 93/173] drivers/clk/clk-fixed-mmio.c:33:2: error: call to undeclared function 'iounmap'; ISO C99 and later do not support implicit function declarations kernel test robot
2023-07-13 16:26 ` Andrew Morton
2023-07-13 23:59   ` Baoquan He
2023-07-14 18:08     ` Andrew Morton [this message]
2023-07-17  7:05     ` Liu, Yujie
2023-07-18  0:06       ` bhe
2023-07-18  6:19         ` Liu, Yujie
2023-07-18  8:47           ` bhe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230714110819.a7a06160032e0f4d350bf99e@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=bhe@redhat.com \
    --cc=hch@lst.de \
    --cc=linux-mm@kvack.org \
    --cc=lkp@intel.com \
    --cc=llvm@lists.linux.dev \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=rppt@kernel.org \
    --cc=schnelle@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).