From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 544F4EB64DC for ; Sat, 15 Jul 2023 04:07:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D58846B0072; Sat, 15 Jul 2023 00:07:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CDFE16B0074; Sat, 15 Jul 2023 00:07:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B81456B0075; Sat, 15 Jul 2023 00:07:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id A83BF6B0072 for ; Sat, 15 Jul 2023 00:07:26 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 7FFE21A004B for ; Sat, 15 Jul 2023 04:07:26 +0000 (UTC) X-FDA: 81012511692.05.F1EC710 Received: from out-7.mta1.migadu.com (out-7.mta1.migadu.com [95.215.58.7]) by imf02.hostedemail.com (Postfix) with ESMTP id 84E1D80008 for ; Sat, 15 Jul 2023 04:07:24 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=DT9marXL; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf02.hostedemail.com: domain of naoya.horiguchi@linux.dev designates 95.215.58.7 as permitted sender) smtp.mailfrom=naoya.horiguchi@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689394044; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=U2Q7rt32186jYQFvLUEX++gzKm12n7FO2FEO9lwjWmk=; b=Ox/lqlmgSros27mOf4IsMJj/kgeZ9fvx6HvQf9l66siclNVWblXp7Jj9gJR3IdGLG9vcxd LjnkjipATbY2JcQl5fGv7hFBIye88yh4RknQKFU1rbmlS8XXgXDFB2Uze37yHOa8uhIlT0 tRURiD0Rum4Jorp1SI0Ibm7afb+fofs= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=DT9marXL; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf02.hostedemail.com: domain of naoya.horiguchi@linux.dev designates 95.215.58.7 as permitted sender) smtp.mailfrom=naoya.horiguchi@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689394044; a=rsa-sha256; cv=none; b=X91ksOu0A7ojrjKLhNxkBt2EAgneWD30asqKnaW4c7fAPOyPs+d7AJTNY0eKThA57V0IBP 0kbmoBm+jvW99d57C6Gm3OxebwnwDsm8rrbQEF1pfwIEKsCIQkH8IXfgLxJgyip1OZDvy4 mUa3zvrI5q4kQEz7ksLHNqZVUffBhiE= Date: Sat, 15 Jul 2023 13:07:13 +0900 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1689394042; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=U2Q7rt32186jYQFvLUEX++gzKm12n7FO2FEO9lwjWmk=; b=DT9marXLx4M1KVinOFTWRRs5dX/E24SD5s4hwxm+uHKeuIyMfuNOmRK5HwMF1kHveBDm/N ibJyvwV8VZD2jd9WyRIXHobeWUJ4P1YNav1dsyFMLcpveLmDEKUIrzIM7p2WKVdE7bYj1r YDPx0NaI6zxR+0xRytxg5LwS/Z43dEU= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Naoya Horiguchi To: Jiaqi Yan Cc: naoya.horiguchi@nec.com, linmiaohe@huawei.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, willy@infradead.org Subject: Re: [PATCH v1] mm/hwpoison: rename hwp_walk* to hwpoison_walk* Message-ID: <20230715040713.GA2352837@u2004> References: <20230713235553.4121855-1-jiaqiyan@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230713235553.4121855-1-jiaqiyan@google.com> X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: 84E1D80008 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: n1hjbeyxb9fh3o65ey483uc8mhx9195q X-HE-Tag: 1689394044-678138 X-HE-Meta: U2FsdGVkX1+gkv/VujhMOnFT8Ls0g5WP3zQEwJejLTszTnTMNO/fxWb3uh05duEINEA15AagpZ2oII4ywCK3wCpM+LI6DeQZY7iRQg9/Se/rwMYYKik4XfVCGFLAsbtqLf8Kz/geote1PKv+ZwO4xPUtY3YAepQH4HJvMcgbBOhHNWLQLWrRyxbW/vB86cyW+cTheoh+0GiqmgKNAuSqeBZxllMdJvsZ8rolIXXZeIRQbH9TjqbBoq6bSnRdAnJUim8Vu53770vZUWaPcYm8JPNukgz8W4mX/5ymw5t0mNb78rUz78nmA1NEdztVec/e3VQHKJXVDLSZCLsbuoo+DrJFYdiyaU/ePBVMK8FlrWHGQAKUpztpEDZqCEd+BRkAKD3T8rd/2yv+VsqHugWnD7JaKb6JRqinhrJvv1dSyv018APIG58c++MOybb1cnzkQMX7g0B7YMeSeOX67cn39l5BM2qwn7frVtn49t7yfdtrRqLPWhRKZtuFCNQ7U8nqnwyJacwfwifT7qwrALuQwooD0KUtLwRLs/Q703nWN297XWen19v9Rwsv6VE4ddnCd3TCPDktJm8tKiYV+KN852sMBGpnjJRWugF6rQnzxNZPn1BuPSDUNsqRJVFZN/oOXzcMkLm2YqCvH/7JZXDLsa93IpxyHs/pwFuMzzhFQ4V9/D9UU6G8RqDd0NF/JcSb9RV7fAuZVq+oCF4fmx0lW12lMmlS+oyiHzhPjbysnic4bCwXc8iZ6ncZA2mvmu/H4TM8oahO582B6egJssABcPv8+tbBhQltIjiAoi0Cgn9+1b/aBDT68Ec/5qfKc9b/oIwudQrxEv6B3pE7Mbzz+8MH8rHQx7wKUUNNiPbhe7uqkYMl0azOMQ+r2RX9y2iNyJqkYNY1l7jEf1fxFvc4uOjU3+AkGtUGspgSLtI58MzwqLZY85TtAD8Jc4r8xFq261EfYyjrT0kUYPQQIMZ 8IVvTLjV nkoqsAp+GacBmqdx42OQzotkPpbyhgCqLtfgpUPJZ4LU5/W8wPQInGOByfdslVXpwB3WD0122bEw5RKhUPfpyjzx1uTmAhinX5/90aYapzkQuQ465o5+M9uX77SneQztQnwdsM6uL541wt987HDoZYn/ICM+TJdK5vqoflVlGNhCz4iHMypWdDUxeRuJ9InpT12TNt7JIDT3mXYfINE+qFDAhxa5mxc0xP9/nvYi98KzEXhFXZstkEwCycqNh2Ze3oRrdZDOxr/wYI3iJRXrcXcUxx5XV+aSrMgqK X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 13, 2023 at 11:55:53PM +0000, Jiaqi Yan wrote: > In the discussion of "Improve hugetlbfs read on HWPOISON hugepages", > Matthew Wilcox suggests hwp is a bad abbreviation of hwpoison, as hwp > is already used as "an acronym by acpi, intel_pstate, some clock > drivers, an ethernet driver, and a scsi driver"[1]. > > So rename hwp_walk and hwp_walk_ops to hwpoison_walk and > hwpoison_walk_ops respectively. > > raw_hwp_(page|list), *_raw_hwp, and raw_hwp_unreliable flag are other > major appearances of "hwp". However, given the "raw" hint in the name, > it is easy to differentiate them from other "hwp" acronyms. Since > renaming them is not as straightforward as renaming hwp_walk*, they > are not covered by this commit. > > [1] https://lore.kernel.org/lkml/20230707201904.953262-5-jiaqiyan@google.com/T/#me6fecb8ce1ad4d5769199c9e162a44bc88f7bdec > > Signed-off-by: Jiaqi Yan Looks good to me. Thank you. Acked-by: Naoya Horiguchi