From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C030AC001B0 for ; Sun, 16 Jul 2023 01:09:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E8D9D6B0071; Sat, 15 Jul 2023 21:09:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E3DFF6B0074; Sat, 15 Jul 2023 21:09:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D05B96B0075; Sat, 15 Jul 2023 21:09:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id C10636B0071 for ; Sat, 15 Jul 2023 21:09:35 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 8EA251202DE for ; Sun, 16 Jul 2023 01:09:35 +0000 (UTC) X-FDA: 81015692310.29.C7AB404 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf01.hostedemail.com (Postfix) with ESMTP id E151C40012 for ; Sun, 16 Jul 2023 01:09:33 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=RNE0S0KQ; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf01.hostedemail.com: domain of chao@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=chao@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689469774; a=rsa-sha256; cv=none; b=ZRIIgaui4gTeq159VwVrbkvhlH4428lbBqBh3f6wSWRgUjiL6UvVKxPVbNbSgjvVg0e6Y9 gsNHnvJkpDPr8lOGuaw2ITAe1rDmRZEYRnOQnbTf7lPGWpXID92TPUcFBhqcQ+0OyzhpUP t17ce3SknkBuK/fwwXWct/GNZibZfJk= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=RNE0S0KQ; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf01.hostedemail.com: domain of chao@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=chao@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689469774; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=lHWTTA67kIdojUfmyvgXKmILJ8BrAFEuc6q6jGxjRIE=; b=qc7E37lnGm8T05Qbq9iqiX/NQR9vw9r4pfYE1xKptgNp4sXlJzmxyh8t++CWXMVLFGxrFQ 1qqS0PHM4rcQWuDFT0IEp7xgWDrFw9IPtewOY73py4yX1Uqyjrr/UnZpYWuA8t11izWXpe wV0mjzh9hcMJIjLlXmHQBpzkSKs21w0= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C831260C50; Sun, 16 Jul 2023 01:09:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C3452C433C7; Sun, 16 Jul 2023 01:09:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689469772; bh=5SSm4qEXPJuLohs5+byCGS3o4lRGePIKkaLKy1/+IXc=; h=From:To:Cc:Subject:Date:From; b=RNE0S0KQf9cRwje4zpnYyVSB45dXyxazFqRNu79k0NvYqvDcqN3SDgAQKkSSlThfu bvt8zjM+7qrgXnrITpz0BXGwD6EIWrjEvP8Sgouy+zj3Ti9+08V0ssNOZS4t84SVjB +i7dELXzNCAV4Ps/cElbr5vod97Fi8CSEMEzQsKkGpjCI4AAnTvKvmFtgbTxa0igmt jaz3LqNmLDx1Uirxipq9HaXZTwq2bhq0XjBjmWxL89463OKLVZYI9/hm0sA1muGdRd sBVyyfPI2Yan0+hwlQsdkB2X/Vo7PgdhJx7e4N8Sl0NgCz4jmCBnYdCKiKthemyOTr QSYdaRb4YsDzw== From: Chao Yu To: sj@kernel.org, akpm@linux-foundation.org, damon@lists.linux.dev Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Chao Yu Subject: [PATCH 1/2] mm/damon/dbgfs: reduce stack usage in str_to_schemes() Date: Sun, 16 Jul 2023 09:09:26 +0800 Message-Id: <20230716010927.3010606-1-chao@kernel.org> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: E151C40012 X-Stat-Signature: 6kgx3nmsyhchqkxr46yj54umuz5rg7sz X-HE-Tag: 1689469773-711571 X-HE-Meta: U2FsdGVkX19Uu9sorjJjpvE0Uohtn5k5lvN6ZDpbjRZCyLOivk2cJlGqqu11YMexAOMXJh/lU3UXVeb6qIAVLuF2vaTrHujQToM/pBKXDf3OHaCEzwp46n5q+l389UIYflr9uTby9JSsa22l6jJAhyJDx9c4qFB4HqJ3uy4xhtENb67ypAvqfTuSevly0380BW/rPnKp07sxJyTzu6QW48xEOplwA0wa0QB7xQwW8tbixPy3sqXFJzirkjh3UAjJRkT2GoVN1fU83Kjmk532qUqZAgPv2R/HrzFVFgvP/5pSZvrf5rYtn3e0YHPAFb1ylUrQGK6z1vTQ05UidwBcpFT8hQ/6KBxNBT9Agn06HBD2iUvOYqLWZiET9UvY9jeza1jP+Jy3gLbKYcnhloSS2tL3ZJXphoQnSunCekXAeRVQK8I8OjVdWnff5dRgyf4OeKvyeyOhs8yNYCI1qIixnVu9k047NgSQNDIkZu3jVJWTPiMawAIXTWgaeZe1AGd1/j6ExUHmVO9VQihn9xhQuJvQOuHuWuB24FKGmHDBgEYBBF4TTPOBxc/aPWJk9xDj7eWNc5GXjB9YOfo8Lb7Y4fv+BFgywPf3rspvRAJj7iTRq9UtfF5DcFVyHLzOdjLG6CFZv8sRVROEaWQuj9rO4WyzsFxRKG614mQK5XEWn0qHZZgS/RKQxKEvuY23zF9pvb6OyFbOkRWKvKhjLgxz/791idQeG6X+gHeyEpAVzP7HQNSIfkVtWeLnlP3cLbfwn1ZV3e9vtWLaQowVs3iT18NAD/2dSLGHnjjoYQWPvWXWMZTpnCXdt3RRiaUkYzC8l+xBWOrDAb1DDCqb/LZx4gIrPXNncjBxjtj94elPhCiqvuB+FBT/LiHLaG5gxIXaSLX6VVWFq11xLPAgXlNOve1lAreAFuiZknbLOL8sYiN75g3uV7aed6mtP2HXyKrND86sBN4m+40PKovTmRl ee5W30w6 P9ocEeG2mA3TpY1graS0Qs2JIELQWWFYl9zvpJ+Shyfdtu2b1uCxQ+D4ga5D6qSZEdAKtUaUqHdhbqpf1HDqrsSo03qjZT+V6/ZA0kv2eDOOfiKW3XZSBKa3pT2dwLpFpwu7h9IQ1RrGTYvP1ugaBSf4X/DAzqoWEwLI7UUuTozjAuLi/2eArVoEe4g08sm+eKF6ZF/hfKMHf/fhBD6rg5jjv/I6EqJZzAvnlWf1Gc9jl7wvELCrAJgf7WWKIvDWbDhx2sBRNW6EKgAMXD2A5pubBu49OUYS1RkfarZ8No9RKRM4YcK4RDOCNOUyNPTTWAaVoCPyUWbq99TpNq0ptdpRs0xH1vIEXmse/5PZp9bsK/IztxHLOYOhYuTPCsOX5GS868sOySfUsdRM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: struct damos_quota quota caused the stack usage of str_to_schemes() to grow beyond the warning limit on 32-bit architectures w/ gcc. mm/damon/dbgfs.c: In function ‘str_to_schemes’: mm/damon/dbgfs.c:292:1: warning: the frame size of 1496 bytes is larger than 1024 bytes [-Wframe-larger-than=] Allocating dynamic memory in str_to_schemes() to fix this issue. Signed-off-by: Chao Yu --- mm/damon/dbgfs.c | 22 ++++++++++++++++------ 1 file changed, 16 insertions(+), 6 deletions(-) diff --git a/mm/damon/dbgfs.c b/mm/damon/dbgfs.c index 124f0f8c97b7..78acc7366895 100644 --- a/mm/damon/dbgfs.c +++ b/mm/damon/dbgfs.c @@ -237,18 +237,26 @@ static struct damos **str_to_schemes(const char *str, ssize_t len, int pos = 0, parsed, ret; unsigned int action_input; enum damos_action action; + struct damos_quota *quota; schemes = kmalloc_array(max_nr_schemes, sizeof(scheme), GFP_KERNEL); if (!schemes) return NULL; + quota = kmalloc(sizeof(struct damos_quota), GFP_KERNEL); + if (!quota) { + kfree(schemes); + return NULL; + } + *nr_schemes = 0; while (pos < len && *nr_schemes < max_nr_schemes) { struct damos_access_pattern pattern = {}; - struct damos_quota quota = {}; struct damos_watermarks wmarks; + memset(quota, 0, sizeof(struct damos_quota)); + ret = sscanf(&str[pos], "%lu %lu %u %u %u %u %u %lu %lu %lu %u %u %u %u %lu %lu %lu %lu%n", &pattern.min_sz_region, &pattern.max_sz_region, @@ -256,10 +264,10 @@ static struct damos **str_to_schemes(const char *str, ssize_t len, &pattern.max_nr_accesses, &pattern.min_age_region, &pattern.max_age_region, - &action_input, "a.ms, - "a.sz, "a.reset_interval, - "a.weight_sz, "a.weight_nr_accesses, - "a.weight_age, &wmarks.metric, + &action_input, "a->ms, + "a->sz, "a->reset_interval, + "a->weight_sz, "a->weight_nr_accesses, + "a->weight_age, &wmarks.metric, &wmarks.interval, &wmarks.high, &wmarks.mid, &wmarks.low, &parsed); if (ret != 18) @@ -278,15 +286,17 @@ static struct damos **str_to_schemes(const char *str, ssize_t len, goto fail; pos += parsed; - scheme = damon_new_scheme(&pattern, action, "a, &wmarks); + scheme = damon_new_scheme(&pattern, action, quota, &wmarks); if (!scheme) goto fail; schemes[*nr_schemes] = scheme; *nr_schemes += 1; } + kfree(quota); return schemes; fail: + kfree(quota); free_schemes_arr(schemes, *nr_schemes); return NULL; } -- 2.40.1