From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8035CEB64DC for ; Mon, 17 Jul 2023 11:41:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A73126B0072; Mon, 17 Jul 2023 07:41:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9FB4F8D0002; Mon, 17 Jul 2023 07:41:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 89BC08D0001; Mon, 17 Jul 2023 07:41:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 7799E6B0072 for ; Mon, 17 Jul 2023 07:41:54 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 449C41C8DF5 for ; Mon, 17 Jul 2023 11:41:54 +0000 (UTC) X-FDA: 81020914548.16.E2BC752 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf18.hostedemail.com (Postfix) with ESMTP id 4234B1C0017 for ; Mon, 17 Jul 2023 11:41:51 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=rIgz1i0y; spf=pass (imf18.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689594112; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wt0yNXIcpXnABF1oqY38G77T49ihfolybh0a+0Bgvg8=; b=Wo1rEU46imtXe0DQrTZ+7xN2e/spM6zG0pBNaURv8GAlI/GbVdX12G5KI1OFAYeqd7cufM H0NVVieFmm2CddC31mieXw9Ipwyal7Wt68ofKCHsZs2H+pXFpmm2qf0q/MxgP8laqsY2Mk J5wYMyrutCKEqdhWTRUpiT6UlQsM1kI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689594112; a=rsa-sha256; cv=none; b=FaY43Omp0Yl5YzKt9JAdLKEZbjpmaL8II/e8C2CPXnqEdWWGjsmZuYmcsYS8TF+ZRFZwX6 CPF/Us/tpvRQoOy0LhQxduiLU73DldmV2o9hMsguxbSklbF9RWuguSjcROXuzrwSd9n32D e/R0fjQeppE3fDFN3Zs2P4GoTeCXey4= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=rIgz1i0y; spf=pass (imf18.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 018B461014; Mon, 17 Jul 2023 11:41:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C5D9FC433C8; Mon, 17 Jul 2023 11:41:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689594110; bh=yU4FuU9GBzJLKMMJ6YPMbnokCAVqtjh1LQe6xjck7Bc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rIgz1i0y9VqdA/C3kMpx8OQuNt5OxBgyURL5YQzROLf1QOzDUuYgTP3snLU+RSKXG GE53TKjbVyFddsOPtolkhThfGN2uj4rE++6Oj4qxfa8uBpYNyo58e51S1dQ5jvQSR3 Q2xiEvuNBf8JTpQpeFDyN+jt5SvpsSXs+X2SEEUw0UIFIT9q58/IncO0dOAJohhmku GzQwewcuyy+ng2oaabhneXNHYdfzfzrPIQgOZUfM1wuzo/eP/PIyZzkZyU7Mv3FmlY dgEfn5ZyL6K2fWaBKb/7d+7+gfidr0iY2NuGUJjLf2g2Q4HKQpiiKiGruaKH2+Jtp0 jGGVe0e5AGfPw== Date: Mon, 17 Jul 2023 14:41:33 +0300 From: Mike Rapoport To: Haifeng Xu Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/mm_init.c: drop node_start_pfn from adjust_zone_range_for_zone_movable() Message-ID: <20230717114133.GE1901145@kernel.org> References: <20230717065811.1262-1-haifeng.xu@shopee.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230717065811.1262-1-haifeng.xu@shopee.com> X-Rspamd-Queue-Id: 4234B1C0017 X-Rspam-User: X-Stat-Signature: qr3t54zoo9okkycozts6314j841mnf3p X-Rspamd-Server: rspam03 X-HE-Tag: 1689594111-315284 X-HE-Meta: U2FsdGVkX184GgS1XNniJf6yxEcgQ/D4xsxex/eJ5RI2nEabzQp4wLgg3qe3Xf5Wcc62upbEwgI63jXsEwzkgjx0q+gnvmpHvX2z/lvi2ryT4+lPHaHxBjnuQsiQ61GkC4zGmuzAut5zEoPxx4YSud6vnRAbr3W+xR+k8u+Uax489wojRj0PQa4gg1OtIgIoGQt4oqD3pvEA6SRnj8yYF0KejXFhVJhp6yQWL15A/MGMqNMz12ZSEyNEezatPQ7pvvQVHoEdAgHoaGTHZLlPJqLOrD6NEP5mv8VP/bjUr7sohWZFWvqCMZiflx9DxrnxAD8g4Tib/kUJm4tIMTuW7SNmx6EPazA8dQHLi6uuvagm+B05vzSe+xktUPu/FBy8r9gA9xZhVqc1PfGgGVkSy4x4W09nkRUg1BAE4QA+punSRzSLr55X1C4juUPnJJLSAwQC343sOYIZM8in/93GQu74KjuMVyJb0NJ0pRWCwxzOLKkJgg6fmREKJ+LtTbGBGV5f8675HPFVxyWtL6N4AEMOb0aEi5UBo4iqivUU+f2C215hLDdfKaMPJoHsU3TwT4IyHzMRw2xAbOJ7SNaA75JVAuK/hGRYdZUJ0IDDp7E15XQ32AkqG5ZmC1s69G/Ve/uf3m7qE9/uMnOUJhwZS6C9ocGlIs7x3R7Hi2PYyUAbACempqvvlDYJp9a88PoNc/poQ7JK2m1XZGaFqM4LoK7V1HZ7ejX0hEIETcoozIAzAhunfII+1AlU8EAg/Jr1reugiUjDpdovlAjiFaLElloBc55Ai1uP0ZfXxBR5U9OOEIeVbLViFa2bFGntBjmMmjljQYEfy9H8NpfBXZTqeWvLqdAPx8THv7PQuMaIwv45uTHmua6IGe7M7bB6Ey9kL0g8GfLvDShiFAa2xkWE/hKP2okvIYCde/Gx+OIO7U6DdWanTPFsIyYj0cuhq2nMzfnshL4rNIzOChksQK9 29kBPMBY nEdB4TiloVJxv7TofUcsnPR3IlXwOsgI4USBtZrYZkYLVaKJsYa65MXQlZF+Za5MiAZKqB79oWbcJhQkno7NDi0XdY1q9gjR+a9XF7mrrT60OUafmLgXVBN3GQ1iU5Wc7iUw1QZt2dowM02gSogL35vcX1EqBJDhgwaJhJBU80fnmQO7VSwKOJbi98/2OKEa35Zw/hrscUeHKPTdCGU7bFxbhQIOyQnmhaatemTqfPXiNu+QOl0e9zLnlBd+JCdSuHTKQCNidtz6SJh2XguFuOY8R8Knczr5SiPZrMWqtMp8vSe8GnNJVspvYdLz/bkl6eSNj0OPjhgBmMHSggNSg+PbVzUpONv0PabjTS+rIMh8K1FBGW35pu5OIdJIKyLEpBXFFbVyyAPcZ6G9IMzjranHeC49NMxX9B3ITophQ7sg8HptwxHairhtAJO4wvYgkILEXmT+MjO9fzEE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jul 17, 2023 at 06:58:11AM +0000, Haifeng Xu wrote: > node_start_pfn is not used in adjust_zone_range_for_zone_movable(), so > it is pointless to waste a function argument. Drop the parameter. > > Signed-off-by: Haifeng Xu Reviewed-by: Mike Rapoport (IBM) > --- > mm/mm_init.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/mm/mm_init.c b/mm/mm_init.c > index a313d1828a6c..23d50541e1f7 100644 > --- a/mm/mm_init.c > +++ b/mm/mm_init.c > @@ -1105,7 +1105,6 @@ void __ref memmap_init_zone_device(struct zone *zone, > */ > static void __init adjust_zone_range_for_zone_movable(int nid, > unsigned long zone_type, > - unsigned long node_start_pfn, > unsigned long node_end_pfn, > unsigned long *zone_start_pfn, > unsigned long *zone_end_pfn) > @@ -1222,9 +1221,8 @@ static unsigned long __init zone_spanned_pages_in_node(int nid, > /* Get the start and end of the zone */ > *zone_start_pfn = clamp(node_start_pfn, zone_low, zone_high); > *zone_end_pfn = clamp(node_end_pfn, zone_low, zone_high); > - adjust_zone_range_for_zone_movable(nid, zone_type, > - node_start_pfn, node_end_pfn, > - zone_start_pfn, zone_end_pfn); > + adjust_zone_range_for_zone_movable(nid, zone_type, node_end_pfn, > + zone_start_pfn, zone_end_pfn); > > /* Check that this node has pages within the zone's required range */ > if (*zone_end_pfn < node_start_pfn || *zone_start_pfn > node_end_pfn) > -- > 2.25.1 > -- Sincerely yours, Mike.