From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE3A5EB64DC for ; Mon, 17 Jul 2023 19:55:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 268026B0072; Mon, 17 Jul 2023 15:55:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 217F86B0074; Mon, 17 Jul 2023 15:55:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0E0A48D0001; Mon, 17 Jul 2023 15:55:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 005C86B0072 for ; Mon, 17 Jul 2023 15:55:30 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id BAB03A0575 for ; Mon, 17 Jul 2023 19:55:30 +0000 (UTC) X-FDA: 81022158420.04.8DAF424 Received: from mx0b-002e3701.pphosted.com (mx0b-002e3701.pphosted.com [148.163.143.35]) by imf16.hostedemail.com (Postfix) with ESMTP id 6656318001C for ; Mon, 17 Jul 2023 19:55:28 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=hpe.com header.s=pps0720 header.b=Xjp5+LVO; dmarc=pass (policy=none) header.from=hpe.com; spf=pass (imf16.hostedemail.com: domain of sivanich@hpe.com designates 148.163.143.35 as permitted sender) smtp.mailfrom=sivanich@hpe.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689623728; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8NvsZuefw9DrKGMEY3hUdCKAZd3Ou40Xkl0Oju3Yjr4=; b=yg2gAPdbf8o8FKLcFxBQ6vVhAHwsdzfjgcMD9XUsU30eYwW9Vs1+dPe2H3jR8rHqAqHqK3 PAGCA6wfQ7xdrFGMr82Hev0oSaRyxxW7XieNA6kg5rCy+M6Wfgo12AOhU3elyVxOjYxe2J HyiHkCkiPvKRoGsnENNITYYOEqZLVno= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=hpe.com header.s=pps0720 header.b=Xjp5+LVO; dmarc=pass (policy=none) header.from=hpe.com; spf=pass (imf16.hostedemail.com: domain of sivanich@hpe.com designates 148.163.143.35 as permitted sender) smtp.mailfrom=sivanich@hpe.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689623728; a=rsa-sha256; cv=none; b=ZcIsj9ctcOFb2NCB7ajNvIvNz7foa2uwldzmI4MgK2eSOzmeSxArOIlOwcXg1O19cKdHo1 26QbPfZIDvxQTnKfsMEgRJPCmVJaVx5w8V311Pu4p5HEoq9XOUXkiVCN3LJzo0XuqFEIDb d1p2OjeNuByd3QD1RPT/W2MTWP9ydto= Received: from pps.filterd (m0150245.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 36HHO7MY025058; Mon, 17 Jul 2023 19:54:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpe.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=pps0720; bh=8NvsZuefw9DrKGMEY3hUdCKAZd3Ou40Xkl0Oju3Yjr4=; b=Xjp5+LVOFk3WX9h4JbMA2THddkGFqn33Jmb+JuxcAgFLEuuQhh6482iqpu/VztW3+Mj5 pVSrhtLynxWrAbPVk0xdMAdeEJhVlMfh0iR341y8grjMvxPmt5lXNbtK1DzlDV3DGW+v QRSLiKIgApWB2GRAhVIA1wz3I8rN7mo7c2Ar70fqcAyCZi0W9Lneke/k1bLprcodVfEK 6fCWV7DJPXhQmoJc3PihtdufOmC64zW18tgDHEhrybGIfFO2wddACTs4wvwZnnD+xpOh VZ9/LaWA6yTZag6iqPlCyIsR8SiLadlV/4DvPBtTqW2BIsB76gZSKbiFGJFTnt7ncciX Bg== Received: from p1lg14880.it.hpe.com (p1lg14880.it.hpe.com [16.230.97.201]) by mx0b-002e3701.pphosted.com (PPS) with ESMTPS id 3rw624kfyg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 17 Jul 2023 19:54:11 +0000 Received: from p1lg14885.dc01.its.hpecorp.net (unknown [10.119.18.236]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by p1lg14880.it.hpe.com (Postfix) with ESMTPS id 2039E800E94; Mon, 17 Jul 2023 19:54:10 +0000 (UTC) Received: from hpe.com (unknown [16.231.227.36]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (Client did not present a certificate) by p1lg14885.dc01.its.hpecorp.net (Postfix) with ESMTPS id CC6C0809FE5; Mon, 17 Jul 2023 19:54:05 +0000 (UTC) Date: Mon, 17 Jul 2023 14:54:03 -0500 From: Dimitri Sivanich To: Matthew Wilcox Cc: David Hildenbrand , Suren Baghdasaryan , Dan Carpenter , linux-mm@kvack.org, Andrew Morton , "Liam R. Howlett" , Laurent Dufour , Michel Lespinasse , Jerome Glisse , Michal Hocko , Vlastimil Babka , Johannes Weiner , Peter Xu , Dimitri Sivanich , Steve Wahl Subject: Re: [bug report] mm: replace vma->vm_flags direct modifications with modifier calls Message-ID: <20230717195403.GA6016@hpe.com> References: <9704a138-60e6-4ede-91f0-844e1df2ad84@moroto.mountain> <331201b2-5f13-8e81-b5d4-b17f8784d498@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Proofpoint-GUID: 0dqh7AYQCmrJEmZxhompRYJ6yylKEqzV X-Proofpoint-ORIG-GUID: 0dqh7AYQCmrJEmZxhompRYJ6yylKEqzV X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-07-17_14,2023-07-13_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 malwarescore=0 mlxscore=0 suspectscore=0 priorityscore=1501 mlxlogscore=728 lowpriorityscore=0 spamscore=0 phishscore=0 adultscore=0 impostorscore=0 clxscore=1011 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2306200000 definitions=main-2307170181 X-Rspamd-Queue-Id: 6656318001C X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: cxtazghgq5j684afqzqhns8e79dpn7wg X-HE-Tag: 1689623728-463638 X-HE-Meta: U2FsdGVkX1+lgBxRpT6tBuLV2YaD2U8r4n8wuNxHclQ3fGZ5PM3l9WVp+hY562VFuA8A0XPF0jvwa5hH7FJ6NxmWWCjSb71dSQNgRoSCsFcSxOvGJwNBWKDZ9j4ME9NyxwOnBlPaqkYHxPn5lYMM2gwGB1tTJmw6c+t4NDuqbA9I8vPamBY7gIva46CPhiXTNtFC65CDbZD/peLkxZkF28e4XmuSlYv9EW7tY9xW0Br7QYvpjVIp1nPLrKUVSq9Zk0n1jzyj/VX+1BWTm7irpBW/cZamY5jZZCKBDKavBs7bnh8STeZ5MxezOHvyHNNel2an6JL7rB9s9DfgXT4l+spSsYb74iHIxssFGS/tXEIisFyQ8bS+hHNDmV9SHVPWPaZz6sXw/wvHiX1aWnSR3t5/7h0rzoKYU/A3GmfM9TMTgMGwT4LAbYt+JNmYlLwF9DbMrCl6ElyNmHNhpQ3hhIPyyBfzFZSV8/w53gH9Z19jXXobQ4oF0dzZRm8V8z9e4/W1uMb2i0mDgpjBw9c0drge/54EXQsfzTo6M/1YgejNJ4lKJvR/FJmysplZ5GcoyEAESgEMxR0jXy7uO8KiBkeYksvjoMZ8/kEGSCVte8GMV/x5Yt7QcRiEyjc/pmxR0n2psrilRkwL64oTBU2lS7NR0eaFnTM/4HkWQfA174C9S0e8uW1Ub+D9L0+0++jPYq3Q8JZOgbtui9tfF1XuUMOZ+Ba77aebmabkjizEnpdZuBBudd2XXN8Jud5v+JOD50JRqx0kSXlc/x4P1ZMw9fz2S5E6LvTtGrwFQUNFodiUMPtapWVhlL95HL5ocFTUXWNAnd90QpUftt/cNnVqM3XgZ52AN2ouFyAHzD5K/SNM7H92iuXFfcqppOiVayTkOCPDSuC9DGr3Ng19ww+cRytP4BpeCGPCfAVeBxUxvG68/DJ6mjbCZyKqRiqL64fjeTSZJpwE1vy6BwUlckm 1y+9xbVb gsro93l4Zjs4hcdeolYfLyHR/yTjjUDormovaOhMb+MgcrajGCHhkyn3P0Uqm3uODVFIgpTs+8jrlnAdtK3Ogo7d/eEUqwsLNDmpmzkargYyGBWRi4hlr00OHtVsjsN4L0OAQo7dEs8Lq4VKu6A2RuMZQRsENQFlE0p2KlNIB/z0ltoh1uYd2/13zdQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jul 12, 2023 at 08:34:10PM +0100, Matthew Wilcox wrote: > On Wed, Jul 12, 2023 at 07:49:53PM +0100, Matthew Wilcox wrote: > > @@ -964,9 +966,12 @@ vm_fault_t gru_fault(struct vm_fault *vmf) > > } > > gru_load_context(gts); > > paddr = gseg_physical_address(gts->ts_gru, gts->ts_ctxnum); > > - remap_pfn_range(vma, vaddr & ~(GRU_GSEG_PAGESIZE - 1), > > - paddr >> PAGE_SHIFT, GRU_GSEG_PAGESIZE, > > - vma->vm_page_prot); > > + > > + pte = pfn_pte(paddr / PAGE_SIZE, vma->vm_page_prot); > > + ptep = vmf->pte - (vaddr % GRU_GSEG_PAGESIZE) / PAGE_SIZE; > > + set_ptes(vma->vm_mm, vaddr & ~(GRU_GSEG_PAGESIZE - 1), > > + ptep, pte_mkspecial(pte), > > + GRU_GSEG_PAGESIZE / PAGE_SIZE); > > } > > Argh, no, this is wrong. The page table isn't mapped at this point. > What we want is a cross between vmf_insert_pfn() and vm_insert_pages(). > Let me add that ... I should be able to test this once you have something ready.