From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF790EB64DC for ; Tue, 18 Jul 2023 16:17:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 705D78D000D; Tue, 18 Jul 2023 12:17:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6B5A88D0001; Tue, 18 Jul 2023 12:17:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 57E4D8D000D; Tue, 18 Jul 2023 12:17:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 4799A8D0001 for ; Tue, 18 Jul 2023 12:17:02 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 09E50B0CCE for ; Tue, 18 Jul 2023 16:17:01 +0000 (UTC) X-FDA: 81025236684.27.B47319F Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf19.hostedemail.com (Postfix) with ESMTP id 13ADA1A0009 for ; Tue, 18 Jul 2023 16:16:59 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=rtLZsrvG; spf=pass (imf19.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689697020; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qRHreu0Oyk2fJ2feJf2gUF+qmWLEaaXWMxpfjfK8uu4=; b=Cv96LxgPkxExlmO8FbilLO+Lp630C4+xI/2U+gpwumdFH8ml0aeOMjdTgtD4kbg5f9+7q/ YQrPPVI9O0DO+PwnSICYsXzQq+/jdJZybeMhaP9f7sjg3xFg7v3cLonPNPLCyyZRIOWPq0 qe8dJOADi2jA/CpW2eM1MEhHDV1Mt6Y= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689697020; a=rsa-sha256; cv=none; b=Jh/h0V6TweSDrO2uAtANexiXi7/NWQerCH2MJ/xUoxf5iOKPBiuuAeZMU1e+A/dl8R6oOi Ydf7iwsOA0sRM5PvuGyGfTF+7mrhUoiZjMnikAJn2mCuM/aSSOml6TOtO3VudvS4mO0Xcn kGkKbbsb3QRnN8UsIyqvmPr+XQD4csA= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=rtLZsrvG; spf=pass (imf19.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A80F961659; Tue, 18 Jul 2023 16:16:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A21CBC433C7; Tue, 18 Jul 2023 16:16:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689697018; bh=gjPI6IYvNwE6IlPyT0VcSbZTdDCqABRF1V0+Aiy19nw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rtLZsrvG3V844S0NtHi5bZj4DXmZL2FnVVLvVnvuc2Nav8IjzSaTUgCI0cGNN2wtC XCnySBLwGOXuaO1LIEIQ94oqLdLrd7Vi1b8YgCI6fvbbl/h4PouklTaw+gmCxum575 6VSF2uO5PeFYPtCAbtz/ayqh+itGf5aSh8bKDZe2pF7URzFvaHdF3zlgb41vGjTzda /6eFbObFX6Xdz4V6GcMUDf1+WJkq7POaQhr+ykdLw1YWkzWHzL91IePR9Yqd7OIEFG 8gmY2mrb9CjKjb3Iq2I9ctgyQk9ogGYY1CqFp/1G5f/ke3QQwUHbRQ5SlW59/idIbN hG90uZw5NNIxA== From: SeongJae Park To: Feng Tang Cc: SeongJae Park , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/damon/core-test: Initialise context before test in damon_test_set_attrs() Date: Tue, 18 Jul 2023 16:16:56 +0000 Message-Id: <20230718161656.78877-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230718052811.1065173-1-feng.tang@intel.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Stat-Signature: z3jjmtyi7wsan8zjf8rjb7zepkzos8we X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 13ADA1A0009 X-Rspam-User: X-HE-Tag: 1689697019-228076 X-HE-Meta: U2FsdGVkX19kbncq7BYSvbpbDTVIqLandQ8Kt1y7rMylAQtwr9C9m0Gvy3rX9ELFy67XiNQmqpAXRlaBgU3glS4dfmAxvFNzthc9ensnde4V8XTX6iCNw38qEKeWuWtgJb4A2hi1UNfjZXvUo0rRt+U7gqqWiczenb0o7PJflpgJz7b6/7ODPGyLylse6PP6B0zm54L2qsbAjr+k/dSzn8w5utSdE7PLPUaLlZFXG0uueEdXI1ojE1bif9sjc/aXDrPuABsCFH4p9PhfApoci6AVuJWSEFMvl/wT0Q7nDNRKun3zOgwOokuXGzTwNrCkaOEBXW+IbwumDRWSY2FaljCzqLz+9hK1s4osYSNc5hUJbHV/YttjDW7dJTJXXxyn3a9mdJOZpFs8SFxbAAi7Pt1WZl2ZOBMvrmmdxTAD7ttvgC4DLSBd0XlRReFtVUb8PXZJwalOC53v8nkRKcVpWNyD7WzRo7fGtJ6kIsEec/NrI3iEWu9EgzqDv5dwsr4mq8LdX/dMpruga5saY3YOwlOwnzqSgSaQs3lfrAMo0VX7q74/25WmcJagNC9EL9+QgxeJxyMrr2pjtM73KupG2ESevGIQ4RrMJbRCvY9xHSpxQVEGKkDiuao7OhnIaWkUA5hGMZyl0hRbOd9+VXUne4noBLrWTfNnTjkTrPWL+oJLfTI3HtxT9c5Ppb7td8rE7hOj9mglK72hvdxOYVC0fy9RiUERdjVaBo5QGvoNCuKNawRhtL39dFtYVtxWFi/ZDcBLfxhsCnaMHnqGDA8eA8Tq5y3zpEeJUKol/7kF50r66/SQyCjhi7VDmYGgWQ252Bk6z7brJkP4Cj5IeudnMr9MG+vGwvK8j84opuCBQfvqu0VblzuJ4SxovZac0SUkhF8XiDf6LZmL0v9qrmXH/3tCLOGnE6htarqp7DxC64nr0nlNaR7RlXd5VtDjxHnHIMJOp0IscQyEfYJqsSY YuFW18GU RlX1yeX7ipJL+RvIDVVCALmpZbvotJh4J+u/fPZ59G+XH4yQOGKs1pIbxpiommxoQiZ1qBx+Ym1xvX+vR8CXNbV5hWos9+wNZOj7uRCvtflnyOxfsEXQs7DNL5U5dXhoo/rbShn8xbXhsvQjrH15UbRn3d2kBOl2sfBmKpf0Ah6aJmvAhKBz71WdKT0StHzGC5Cv9cE2CHkXPXvgCYLfE/dNvG4OcB+cYzlEdqulqKk7RjC9VD73tijo+biZJKnHDeuzFx71eQwt+V5ve/v/aLzKW0SdCvDr3xYnT6rNa3TYmNCDzJypYpev40C074IiLApPZSgCiWkFBWPBHJddtJr93dbgb10EcsJPX3gyoWXKChzOiG+OMUwhvzrdgLBSC9TRhvJf3P4ysaCcChF4zI146zA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Feng Tang, On Tue, 18 Jul 2023 13:28:11 +0800 Feng Tang wrote: > Running kunit test for 6.5-rc1 hits one bug: > > ok 10 damon_test_update_monitoring_result > general protection fault, probably for non-canonical address 0x1bffa5c419cfb81: 0000 [#1] PREEMPT SMP NOPTI > CPU: 1 PID: 110 Comm: kunit_try_catch Tainted: G N 6.5.0-rc2 #15 > Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.15.0-1 04/01/2014 > RIP: 0010:damon_set_attrs+0xb9/0x120 > Code: f8 00 00 00 4c 8d 58 e0 48 39 c3 74 ba 41 ba 59 17 b7 d1 49 8b 43 10 4d > 8d 4b 10 48 8d 70 e0 49 39 c1 74 50 49 8b 40 08 31 d2 <69> 4e 18 10 27 00 00 > 49 f7 30 31 d2 48 89 c5 89 c8 f7 f5 31 d2 89 > RSP: 0000:ffffc900005bfd40 EFLAGS: 00010246 > RAX: ffffffff81159fc0 RBX: ffffc900005bfeb8 RCX: 0000000000000000 > RDX: 0000000000000000 RSI: 01bffa5c419cfb69 RDI: ffffc900005bfd70 > RBP: ffffc90000013c10 R08: ffffc900005bfdc0 R09: ffffffff81ff10ed > R10: 00000000d1b71759 R11: ffffffff81ff10dd R12: ffffc90000013a78 > R13: ffff88810eb78180 R14: ffffffff818297c0 R15: ffffc90000013c28 > FS: 0000000000000000(0000) GS:ffff88813bd00000(0000) knlGS:0000000000000000 > CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > CR2: 0000000000000000 CR3: 0000000002a1c001 CR4: 0000000000370ee0 > DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 > DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 > Call Trace: > > damon_test_set_attrs+0x63/0x1f0 > kunit_generic_run_threadfn_adapter+0x17/0x30 > kthread+0xfd/0x130 Great. But it would be even greater if you could this kind of output after decoding the addreses using 'scripts/decode_stacktrace.sh` or 'scripts/faddr2line' from next time if possible. > > The problem seems to be related with the damon_ctx was used without > being initialized. Fix it by adding the initialization. Somehow the test always passed on my test machine, but maybe that's due to some different behavior of my compiler. I agree that could be the root cause because 'damon_set_attrs()' calls 'damon_update_monitoring_results()', which accesses the context's fields including the targets list. Since the list is not initialized in this test code, it would cause such error. > > Fixes: aa13779be6b7 ("mm/damon/core-test: add a test for damon_set_attrs()") > Signed-off-by: Feng Tang Reviewed-by: SeongJae Park Thanks, SJ > --- > mm/damon/core-test.h | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/mm/damon/core-test.h b/mm/damon/core-test.h > index c11210124344..bb07721909e1 100644 > --- a/mm/damon/core-test.h > +++ b/mm/damon/core-test.h > @@ -320,25 +320,25 @@ static void damon_test_update_monitoring_result(struct kunit *test) > > static void damon_test_set_attrs(struct kunit *test) > { > - struct damon_ctx ctx; > + struct damon_ctx *c = damon_new_ctx(); > struct damon_attrs valid_attrs = { > .min_nr_regions = 10, .max_nr_regions = 1000, > .sample_interval = 5000, .aggr_interval = 100000,}; > struct damon_attrs invalid_attrs; > > - KUNIT_EXPECT_EQ(test, damon_set_attrs(&ctx, &valid_attrs), 0); > + KUNIT_EXPECT_EQ(test, damon_set_attrs(c, &valid_attrs), 0); > > invalid_attrs = valid_attrs; > invalid_attrs.min_nr_regions = 1; > - KUNIT_EXPECT_EQ(test, damon_set_attrs(&ctx, &invalid_attrs), -EINVAL); > + KUNIT_EXPECT_EQ(test, damon_set_attrs(c, &invalid_attrs), -EINVAL); > > invalid_attrs = valid_attrs; > invalid_attrs.max_nr_regions = 9; > - KUNIT_EXPECT_EQ(test, damon_set_attrs(&ctx, &invalid_attrs), -EINVAL); > + KUNIT_EXPECT_EQ(test, damon_set_attrs(c, &invalid_attrs), -EINVAL); > > invalid_attrs = valid_attrs; > invalid_attrs.aggr_interval = 4999; > - KUNIT_EXPECT_EQ(test, damon_set_attrs(&ctx, &invalid_attrs), -EINVAL); > + KUNIT_EXPECT_EQ(test, damon_set_attrs(c, &invalid_attrs), -EINVAL); > } > > static struct kunit_case damon_test_cases[] = { > -- > 2.34.1 > > >