From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C68EDEB64DA for ; Wed, 19 Jul 2023 04:32:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EF4AB28002A; Wed, 19 Jul 2023 00:32:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EA3768D0012; Wed, 19 Jul 2023 00:32:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D6BE328002A; Wed, 19 Jul 2023 00:32:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id C4DC58D0012 for ; Wed, 19 Jul 2023 00:32:43 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 7F49F16013F for ; Wed, 19 Jul 2023 04:32:43 +0000 (UTC) X-FDA: 81027090606.20.380153B Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf13.hostedemail.com (Postfix) with ESMTP id E1F0320008 for ; Wed, 19 Jul 2023 04:32:41 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=kXMpg8Bb; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf13.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689741162; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wt0yNXIcpXnABF1oqY38G77T49ihfolybh0a+0Bgvg8=; b=kk8z6pIsmzl6Y6wEmnvQK6dvz0QpHWIZUpS28RnIpHIATVpphCZaPHUCIQQeoiHavypPA3 /us4DG3+ujOFh6mR9o8yIvBo9FGUTnSzIfSKrSqIXB1viC6kwgCX14vVDPbucbU49rGmi+ OlJcNjWOFH65iLS+Cq/TxgH+JQ6bHwM= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=kXMpg8Bb; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf13.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689741162; a=rsa-sha256; cv=none; b=aUubd9CylvNYBqUGNC1yEQ13mCIDFk3F/rE2wYE7hlB7fPocp1qANfL8xbEHFlV0S4G6gb 2sTzW1eJt26DnFyap5pOwK7QHznAflclQtL5TGcqT2KdLoWDbADc/9bVGNDhM+c96Cmlcz +vGbkumz6baLFviPkNynv8+9x9PXq0s= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B17CE60B4A; Wed, 19 Jul 2023 04:32:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 17576C433C8; Wed, 19 Jul 2023 04:32:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689741159; bh=yU4FuU9GBzJLKMMJ6YPMbnokCAVqtjh1LQe6xjck7Bc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kXMpg8BbhJZJNkpHSPLHr1qjWo5E4zGZfD5bHPWtIg/l2IeZ57hgDzj44YOHivqZG AS0MuLpTF7gFAwMDxhTP0wq2ZUexx34z7lJUYYP7q7TGtsA2UBl/l/92sxdgi/7L7e Yz20BMiMcSCvwSg9FqRVOzMMs5SqCYdCvtg+cj2/CNrExK/BzkoFXxMjs6S8tRICQA HvR2ElBn+SOBXOXfpbChVH6AY8RX0N7hToZKNj92DBMFp+UI3qn96vq6CnrqFbQBAU GHUePA8+GH7wYnA2mIbdIavTA7+38AwRVLGr+hOL1g4zl9aQTIfq5rDM9xENyPoPF+ xnILTX+hjNBsw== Date: Wed, 19 Jul 2023 07:32:18 +0300 From: Mike Rapoport To: Haifeng Xu Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/mm_init.c: drop node_start_pfn from adjust_zone_range_for_zone_movable() Message-ID: <20230719043218.GF1901145@kernel.org> References: <20230717065811.1262-1-haifeng.xu@shopee.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230717065811.1262-1-haifeng.xu@shopee.com> X-Rspam-User: X-Stat-Signature: cuugj46cxzryixauwk3bmr4aup5mmski X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: E1F0320008 X-HE-Tag: 1689741161-375301 X-HE-Meta: U2FsdGVkX18NUNP0eevN6RfivpFkEW966ZYzdKTlFFUCkVDGpQAaLhbKV3VwodFsOewkd9xonMDai2V4F6svd60cAxQdVWBY7uirmYkssZ7PN6d+GhlRkrcWMMhP3Rj0BaWW8Q0KizoIxAdBkfR/6UhEQUOeXyDM5q0U5hgzrvzA1KkMwaH9YFNCjhx7wYnKncUIHxxYBhKmORaZCxsFvCN0LNmJHXQAMUUi6I6EtpvxQuTh4PBrikdN7C2cCKxVJ3fZBdxbG+PMGW9xj0D5ToIRa7v4AG4O5y6DDs0VzMWHZFyKPXfJNx/XJkQpOwZM6mSxEITE5sl3RxnxXG3OCyYCQt4QVSbBOUFPhyRHZwI/AcOAWXA7crWR+wRXZw0RFuUQF+mwD+WUgaHxh1ttOH66jtxkMIjcXnDmPeShe8W6kJjCSmB0wnqnLLO4uubAUjP4JRo0fa9rb2CNNPR5AWBjMRAKj6mjudnxZ8fWWZklrClbtDfb8en7S7Lr/U8Ee0VEnEhHL+P17Un4J2Bge59C2+zGfaGvfYBOhgdtg+0clqLwi8uV1mnfWohNEAH1Oxgb2hls5fLbI+cpoQZIDFMhhf+6oKX4SaWXD/5oa9LEMe9reGevFWL9m22aMQ2mmWEn6FV3oBAj8CFn+3lBS21Htweb4uCc0UghOyFJFNS+A+APS8hORrIuTUz36u8r5LAI8WWGbcxNLY21vPj8jBFdH4ZTwXynbRHEOqRGmzOD7pK+L8IPABOi2JRVYc/KPTQKfT1U/OhuOWx8sDn4yhVbu0ffSCS0OijscgdZzaKyMiPKuZeTit1NSBcxTFqyfFPO3Dm77Sjs8MFWoKoa7Nzkmw6b63h49bzIIfSkJGUeRbpDuDKlKd/rgTaaYIRGI352fHgK2kk0YUvi3pXVASfON5uT94qWCBqv3bE6L5I2r7HCMiL8Y0DWzSOIZPNWPVPn0VVDI01wh/4z2YM lAHOEdVS PDkO2GrSO7T8AUbQHllcLO37aKhT/3dke8biW52/NQewQfMorUCPuN82l5x9GipXgysnu8RFdGGlnEX2JNkykUB/YANJYBq116Xftj/rtr59wwguDMcpLMwJUKsKDNSxXBS2ASP2JQs4+1VL/1pFb4S93xksk7+u09f6u2DYunPXYsOQ1uki2/jcGEppbNlVdrKTvB7tTOfh/qoR1o+v5n3AwtjSLwDZIjjRfM71/xLfISxMHdNq+P05pU+GlzboseHHkWouLXAkwDUlR2wsZ1lwHVEN9QP9t4shQeza7whURsJya+gEWRNDWwaWpxNQF7+s0ZyXWMfaaxA2CO6pife8Nnh0+HguexcV/sQH0/vA2J3XLl3+w2nMpIvX+NjDtz+lMA+ifsrHvpQtIqs17CV6ctImlmIvFGyCKGNMV3sl9QW7r28nFGZEw5braonjCRxXThSd2CDuSu+k= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jul 17, 2023 at 06:58:11AM +0000, Haifeng Xu wrote: > node_start_pfn is not used in adjust_zone_range_for_zone_movable(), so > it is pointless to waste a function argument. Drop the parameter. > > Signed-off-by: Haifeng Xu Reviewed-by: Mike Rapoport (IBM) > --- > mm/mm_init.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/mm/mm_init.c b/mm/mm_init.c > index a313d1828a6c..23d50541e1f7 100644 > --- a/mm/mm_init.c > +++ b/mm/mm_init.c > @@ -1105,7 +1105,6 @@ void __ref memmap_init_zone_device(struct zone *zone, > */ > static void __init adjust_zone_range_for_zone_movable(int nid, > unsigned long zone_type, > - unsigned long node_start_pfn, > unsigned long node_end_pfn, > unsigned long *zone_start_pfn, > unsigned long *zone_end_pfn) > @@ -1222,9 +1221,8 @@ static unsigned long __init zone_spanned_pages_in_node(int nid, > /* Get the start and end of the zone */ > *zone_start_pfn = clamp(node_start_pfn, zone_low, zone_high); > *zone_end_pfn = clamp(node_end_pfn, zone_low, zone_high); > - adjust_zone_range_for_zone_movable(nid, zone_type, > - node_start_pfn, node_end_pfn, > - zone_start_pfn, zone_end_pfn); > + adjust_zone_range_for_zone_movable(nid, zone_type, node_end_pfn, > + zone_start_pfn, zone_end_pfn); > > /* Check that this node has pages within the zone's required range */ > if (*zone_end_pfn < node_start_pfn || *zone_start_pfn > node_end_pfn) > -- > 2.25.1 > -- Sincerely yours, Mike.